All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: "Guo Ren" <guoren@kernel.org>, "Björn Töpel" <bjorn@kernel.org>,
	"liaochang (A)" <liaochang1@huawei.com>,
	palmer@dabbelt.com, paul.walmsley@sifive.com,
	conor.dooley@microchip.com, penberg@kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Guo Ren" <guoren@linux.alibaba.com>
Subject: Re: [PATCH] riscv: kprobe: Optimize kprobe with accurate atomicity
Date: Mon, 20 Feb 2023 10:35:57 +0000	[thread overview]
Message-ID: <Y/NNDXlXth2HgSUf@FVFF77S0Q05N> (raw)
In-Reply-To: <20230217002351.112635f4fb35f84002666d29@kernel.org>

On Fri, Feb 17, 2023 at 12:23:51AM +0900, Masami Hiramatsu wrote:
> On Tue, 31 Jan 2023 10:33:05 +0000
> Mark Rutland <mark.rutland@arm.com> wrote:
> 
> > On Tue, Jan 31, 2023 at 09:48:29AM +0800, Guo Ren wrote:
> > > On Mon, Jan 30, 2023 at 11:49 PM Mark Rutland <mark.rutland@arm.com> wrote:
> > Masami, Steve, and I had a chat at the tracing summit late last year (which
> > unfortunately, was not recorded), and what we'd like to do is get each
> > architecture to have FPROBE (and FTRACE_WITH_ARGS), at which point OPTPROBE
> > and KRETPROBE become redundant and could be removed.
> 
> No, the fprobe will replace the KRETPROBE but not OPTPROBE. The OPTPROBE
> is completely different one. Fprobe is used only for function entry, but
> optprobe is applied to the function body.

Sorry, I had OPTPROBE and KPROBE_ON_FTRACE confused in my head, and was
thinking that FPROBE would supersede KPROBE_ON_FTRACE and KRETPROBE.

> > i.e. we'd keep KPROBES as a "you can trace any instruction" feature, but in the
> > few cases where OPTPROBES can make things fater by using FTRACE, you should
> > just use that directly via FPROBE.
> 
> I think what you are saying is KPROBE_ON_FTRACE, and that will be replaced by
> FPROBES.

Yes, sorry for the confusion.

Mark.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: "Guo Ren" <guoren@kernel.org>, "Björn Töpel" <bjorn@kernel.org>,
	"liaochang (A)" <liaochang1@huawei.com>,
	palmer@dabbelt.com, paul.walmsley@sifive.com,
	conor.dooley@microchip.com, penberg@kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Guo Ren" <guoren@linux.alibaba.com>
Subject: Re: [PATCH] riscv: kprobe: Optimize kprobe with accurate atomicity
Date: Mon, 20 Feb 2023 10:35:57 +0000	[thread overview]
Message-ID: <Y/NNDXlXth2HgSUf@FVFF77S0Q05N> (raw)
In-Reply-To: <20230217002351.112635f4fb35f84002666d29@kernel.org>

On Fri, Feb 17, 2023 at 12:23:51AM +0900, Masami Hiramatsu wrote:
> On Tue, 31 Jan 2023 10:33:05 +0000
> Mark Rutland <mark.rutland@arm.com> wrote:
> 
> > On Tue, Jan 31, 2023 at 09:48:29AM +0800, Guo Ren wrote:
> > > On Mon, Jan 30, 2023 at 11:49 PM Mark Rutland <mark.rutland@arm.com> wrote:
> > Masami, Steve, and I had a chat at the tracing summit late last year (which
> > unfortunately, was not recorded), and what we'd like to do is get each
> > architecture to have FPROBE (and FTRACE_WITH_ARGS), at which point OPTPROBE
> > and KRETPROBE become redundant and could be removed.
> 
> No, the fprobe will replace the KRETPROBE but not OPTPROBE. The OPTPROBE
> is completely different one. Fprobe is used only for function entry, but
> optprobe is applied to the function body.

Sorry, I had OPTPROBE and KPROBE_ON_FTRACE confused in my head, and was
thinking that FPROBE would supersede KPROBE_ON_FTRACE and KRETPROBE.

> > i.e. we'd keep KPROBES as a "you can trace any instruction" feature, but in the
> > few cases where OPTPROBES can make things fater by using FTRACE, you should
> > just use that directly via FPROBE.
> 
> I think what you are saying is KPROBE_ON_FTRACE, and that will be replaced by
> FPROBES.

Yes, sorry for the confusion.

Mark.

  reply	other threads:[~2023-02-20 10:36 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 16:15 [PATCH] riscv: kprobe: Optimize kprobe with accurate atomicity guoren
2023-01-26 16:15 ` guoren
2023-01-28  3:52 ` liaochang (A)
2023-01-28  3:52   ` liaochang (A)
2023-01-28  4:45   ` Guo Ren
2023-01-28  4:45     ` Guo Ren
2023-01-30 15:28     ` Björn Töpel
2023-01-30 15:28       ` Björn Töpel
2023-01-30 15:49       ` Mark Rutland
2023-01-30 15:49         ` Mark Rutland
2023-01-30 16:56         ` Björn Töpel
2023-01-30 16:56           ` Björn Töpel
2023-01-31  1:48         ` Guo Ren
2023-01-31  1:48           ` Guo Ren
2023-01-31  7:12           ` Björn Töpel
2023-01-31  7:12             ` Björn Töpel
2023-01-31  8:30             ` Guo Ren
2023-01-31  8:30               ` Guo Ren
2023-01-31 10:33           ` Mark Rutland
2023-01-31 10:33             ` Mark Rutland
2023-02-16 15:23             ` Masami Hiramatsu
2023-02-16 15:23               ` Masami Hiramatsu
2023-02-20 10:35               ` Mark Rutland [this message]
2023-02-20 10:35                 ` Mark Rutland
2023-02-21  1:30               ` Guo Ren
2023-02-21  1:30                 ` Guo Ren
2023-01-31  1:01       ` Guo Ren
2023-01-31  1:01         ` Guo Ren
2023-01-31  1:09         ` Guo Ren
2023-01-31  1:09           ` Guo Ren
2023-01-31  7:03           ` Björn Töpel
2023-01-31  7:03             ` Björn Töpel
2023-01-31  8:27             ` Guo Ren
2023-01-31  8:27               ` Guo Ren
2023-01-31  6:40         ` Björn Töpel
2023-01-31  6:40           ` Björn Töpel
2023-01-31  8:15           ` Guo Ren
2023-01-31  8:15             ` Guo Ren
2023-01-31 10:56             ` Andrea Parri
2023-01-31 10:56               ` Andrea Parri
2023-01-31 13:23               ` Guo Ren
2023-01-31 13:23                 ` Guo Ren
2023-02-16  7:54                 ` Björn Töpel
2023-02-16  7:54                   ` Björn Töpel
2023-02-17  2:28                   ` Guo Ren
2023-02-17  2:28                     ` Guo Ren
2023-02-17  7:32                     ` Björn Töpel
2023-02-17  7:32                       ` Björn Töpel
2023-02-21  1:56                       ` Guo Ren
2023-02-21  1:56                         ` Guo Ren
2023-02-16 15:42 ` Masami Hiramatsu
2023-02-16 15:42   ` Masami Hiramatsu
2023-02-21  0:57   ` Guo Ren
2023-02-21  0:57     ` Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y/NNDXlXth2HgSUf@FVFF77S0Q05N \
    --to=mark.rutland@arm.com \
    --cc=bjorn@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=guoren@kernel.org \
    --cc=guoren@linux.alibaba.com \
    --cc=liaochang1@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mhiramat@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.