* [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff
@ 2023-01-27 17:30 Ville Syrjala
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 1/4] drm/i915/vrr: Fix "window2" handling Ville Syrjala
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Ville Syrjala @ 2023-01-27 17:30 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
A bunch of stuff related to vblank length/start.
v2: Fix inactive pipe handling
Fix SAGV handling
Fix some typos
Ville Syrjälä (4):
drm/i915/vrr: Fix "window2" handling
drm/i915/psr: Fix the delayed vblank w/a
drm/i915: Extract skl_wm_latency()
drm/i915: Reject wm levels that exceed vblank time
drivers/gpu/drm/i915/display/intel_psr.c | 9 +-
drivers/gpu/drm/i915/display/intel_vrr.c | 10 +-
drivers/gpu/drm/i915/display/skl_watermark.c | 155 +++++++++++++++++--
3 files changed, 144 insertions(+), 30 deletions(-)
--
2.39.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH v2 1/4] drm/i915/vrr: Fix "window2" handling
2023-01-27 17:30 [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Ville Syrjala
@ 2023-01-27 17:30 ` Ville Syrjala
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 2/4] drm/i915/psr: Fix the delayed vblank w/a Ville Syrjala
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjala @ 2023-01-27 17:30 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The "window2" delay is just the difference of vactive
(undelayed vblank) vs. vblank_start (delayed vblank).
Just use vblank_start during the VRR calculations so
that things work correctly regardless of whether delayed
vblank is used or not.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_vrr.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 5ff6aed9575e..4228f26b4c11 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -144,17 +144,11 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,
* is deprecated.
*/
if (DISPLAY_VER(i915) >= 13) {
- /*
- * FIXME: Subtract Window2 delay from below value.
- *
- * Window2 specifies time required to program DSB (Window2) in
- * number of scan lines. Assuming 0 for no DSB.
- */
crtc_state->vrr.guardband =
- crtc_state->vrr.vmin + 1 - adjusted_mode->crtc_vdisplay;
+ crtc_state->vrr.vmin + 1 - adjusted_mode->crtc_vblank_start;
} else {
crtc_state->vrr.pipeline_full =
- min(255, crtc_state->vrr.vmin - adjusted_mode->crtc_vdisplay -
+ min(255, crtc_state->vrr.vmin - adjusted_mode->crtc_vblank_start -
crtc_state->framestart_delay - 1);
}
--
2.39.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH v2 2/4] drm/i915/psr: Fix the delayed vblank w/a
2023-01-27 17:30 [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Ville Syrjala
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 1/4] drm/i915/vrr: Fix "window2" handling Ville Syrjala
@ 2023-01-27 17:30 ` Ville Syrjala
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 3/4] drm/i915: Extract skl_wm_latency() Ville Syrjala
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjala @ 2023-01-27 17:30 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fix the code to correctly determine whether delayed vblank
is used or not.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 7a72e15e6836..eb9a0cd18652 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1170,13 +1170,8 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp,
*/
if (IS_MTL_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0) ||
IS_DISPLAY_VER(dev_priv, 12, 13)) {
- u16 vtotal, vblank;
-
- vtotal = crtc_state->uapi.adjusted_mode.crtc_vtotal -
- crtc_state->uapi.adjusted_mode.crtc_vdisplay;
- vblank = crtc_state->uapi.adjusted_mode.crtc_vblank_end -
- crtc_state->uapi.adjusted_mode.crtc_vblank_start;
- if (vblank > vtotal)
+ if (crtc_state->hw.adjusted_mode.crtc_vblank_start !=
+ crtc_state->hw.adjusted_mode.crtc_vdisplay)
intel_de_rmw(dev_priv, GEN8_CHICKEN_DCPR_1, 0,
wa_16013835468_bit_get(intel_dp));
}
--
2.39.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH v2 3/4] drm/i915: Extract skl_wm_latency()
2023-01-27 17:30 [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Ville Syrjala
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 1/4] drm/i915/vrr: Fix "window2" handling Ville Syrjala
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 2/4] drm/i915/psr: Fix the delayed vblank w/a Ville Syrjala
@ 2023-01-27 17:30 ` Ville Syrjala
2023-02-22 9:25 ` Hogander, Jouni
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 4/4] drm/i915: Reject wm levels that exceed vblank time Ville Syrjala
` (3 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjala @ 2023-01-27 17:30 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Extract the skl+ wm latency determination into a small helper
so that everyone has the same idea what the latency should be.
This introduces a slight functional change in that
skl_cursor_allocation() will now start to account for the
extra 4 usec that the kbk/cfl/cml IPC w/a adds.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/skl_watermark.c | 40 +++++++++++++-------
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index ae4e9e680c2e..65c746d018b5 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -704,6 +704,28 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state,
const struct skl_wm_level *result_prev,
struct skl_wm_level *result /* out */);
+static unsigned int skl_wm_latency(struct drm_i915_private *i915, int level,
+ const struct skl_wm_params *wp)
+{
+ unsigned int latency = i915->display.wm.skl_latency[level];
+
+ if (latency == 0)
+ return 0;
+
+ /*
+ * WaIncreaseLatencyIPCEnabled: kbl,cfl
+ * Display WA #1141: kbl,cfl
+ */
+ if ((IS_KABYLAKE(i915) || IS_COFFEELAKE(i915) || IS_COMETLAKE(i915)) &&
+ skl_watermark_ipc_enabled(i915))
+ latency += 4;
+
+ if (skl_needs_memory_bw_wa(i915) && wp->x_tiled)
+ latency += 15;
+
+ return latency;
+}
+
static unsigned int
skl_cursor_allocation(const struct intel_crtc_state *crtc_state,
int num_active)
@@ -723,7 +745,7 @@ skl_cursor_allocation(const struct intel_crtc_state *crtc_state,
drm_WARN_ON(&i915->drm, ret);
for (level = 0; level <= max_level; level++) {
- unsigned int latency = i915->display.wm.skl_latency[level];
+ unsigned int latency = skl_wm_latency(i915, level, &wp);
skl_compute_plane_wm(crtc_state, plane, level, latency, &wp, &wm, &wm);
if (wm.min_ddb_alloc == U16_MAX)
@@ -1834,17 +1856,6 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state,
return;
}
- /*
- * WaIncreaseLatencyIPCEnabled: kbl,cfl
- * Display WA #1141: kbl,cfl
- */
- if ((IS_KABYLAKE(i915) || IS_COFFEELAKE(i915) || IS_COMETLAKE(i915)) &&
- skl_watermark_ipc_enabled(i915))
- latency += 4;
-
- if (skl_needs_memory_bw_wa(i915) && wp->x_tiled)
- latency += 15;
-
method1 = skl_wm_method1(i915, wp->plane_pixel_rate,
wp->cpp, latency, wp->dbuf_block_size);
method2 = skl_wm_method2(wp->plane_pixel_rate,
@@ -1971,7 +1982,7 @@ skl_compute_wm_levels(const struct intel_crtc_state *crtc_state,
for (level = 0; level <= max_level; level++) {
struct skl_wm_level *result = &levels[level];
- unsigned int latency = i915->display.wm.skl_latency[level];
+ unsigned int latency = skl_wm_latency(i915, level, wm_params);
skl_compute_plane_wm(crtc_state, plane, level, latency,
wm_params, result_prev, result);
@@ -1991,7 +2002,8 @@ static void tgl_compute_sagv_wm(const struct intel_crtc_state *crtc_state,
unsigned int latency = 0;
if (i915->display.sagv.block_time_us)
- latency = i915->display.sagv.block_time_us + i915->display.wm.skl_latency[0];
+ latency = i915->display.sagv.block_time_us +
+ skl_wm_latency(i915, 0, wm_params);
skl_compute_plane_wm(crtc_state, plane, 0, latency,
wm_params, &levels[0],
--
2.39.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH v2 4/4] drm/i915: Reject wm levels that exceed vblank time
2023-01-27 17:30 [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Ville Syrjala
` (2 preceding siblings ...)
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 3/4] drm/i915: Extract skl_wm_latency() Ville Syrjala
@ 2023-01-27 17:30 ` Ville Syrjala
2023-01-27 19:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: vblank stuff (rev2) Patchwork
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjala @ 2023-01-27 17:30 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The pipe needs a certain amount of time during vblank to prefill
sufficiently. If the vblank is too short the relevant watermark
level must be disabled.
Start implementing the necessary calculations to check this.
Scaler and DSC prefill are left out for now as handling those
is not entirely trivial.
Also the PSR latency reporting override chicken bits would
need to be correctly configured based on the results of these
calculations. Just add some FIXMEs for now.
TODO: bspec isn't exactly crystal clear in its explanations
so quite a few open questions remain...
v2: Skip inacive pipes
Handle SAGV latency
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/skl_watermark.c | 117 ++++++++++++++++++-
1 file changed, 115 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index 65c746d018b5..715f389cd872 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -8,6 +8,7 @@
#include "intel_atomic.h"
#include "intel_atomic_plane.h"
#include "intel_bw.h"
+#include "intel_crtc.h"
#include "intel_de.h"
#include "intel_display.h"
#include "intel_display_power.h"
@@ -720,7 +721,7 @@ static unsigned int skl_wm_latency(struct drm_i915_private *i915, int level,
skl_watermark_ipc_enabled(i915))
latency += 4;
- if (skl_needs_memory_bw_wa(i915) && wp->x_tiled)
+ if (skl_needs_memory_bw_wa(i915) && wp && wp->x_tiled)
latency += 15;
return latency;
@@ -2195,6 +2196,118 @@ static int icl_build_plane_wm(struct intel_crtc_state *crtc_state,
return 0;
}
+static bool
+skl_is_vblank_too_short(const struct intel_crtc_state *crtc_state,
+ int wm0_lines, int latency)
+{
+ const struct drm_display_mode *adjusted_mode =
+ &crtc_state->hw.adjusted_mode;
+
+ /* FIXME missing scaler and DSC pre-fill time */
+ return crtc_state->framestart_delay +
+ intel_usecs_to_scanlines(adjusted_mode, latency) +
+ wm0_lines >
+ adjusted_mode->crtc_vtotal - adjusted_mode->crtc_vblank_start;
+}
+
+static int skl_max_wm0_lines(const struct intel_crtc_state *crtc_state)
+{
+ struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+ enum plane_id plane_id;
+ int wm0_lines = 0;
+
+ for_each_plane_id_on_crtc(crtc, plane_id) {
+ const struct skl_plane_wm *wm = &crtc_state->wm.skl.optimal.planes[plane_id];
+
+ /* FIXME what about !skl_wm_has_lines() platforms? */
+ wm0_lines = max_t(int, wm0_lines, wm->wm[0].lines);
+ }
+
+ return wm0_lines;
+}
+
+static int skl_max_wm_level_for_vblank(struct intel_crtc_state *crtc_state,
+ int wm0_lines)
+{
+ struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+ struct drm_i915_private *i915 = to_i915(crtc->base.dev);
+ int level;
+
+ for (level = ilk_wm_max_level(i915); level >= 0; level--) {
+ int latency;
+
+ /*
+ * FIXME is it correct to use 0 latency for wm0 here?
+ * FIXME should we care about the latency w/a's?
+ * FIXME what if we don't have latency for all levels?
+ */
+ latency = level == 0 ?
+ 0 : skl_wm_latency(i915, level, NULL);
+
+ if (!skl_is_vblank_too_short(crtc_state, wm0_lines, latency))
+ return level;
+ }
+
+ return -EINVAL;
+}
+
+static int skl_wm_check_vblank(struct intel_crtc_state *crtc_state)
+{
+ struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+ struct drm_i915_private *i915 = to_i915(crtc->base.dev);
+ int wm0_lines, level;
+
+ if (!crtc_state->hw.active)
+ return 0;
+
+ wm0_lines = skl_max_wm0_lines(crtc_state);
+
+ level = skl_max_wm_level_for_vblank(crtc_state, wm0_lines);
+ if (level < 0)
+ return level;
+
+ /*
+ * FIXME PSR needs to toggle LATENCY_REPORTING_REMOVED_PIPE_*
+ * based on whether we're limited by the vblank duration.
+ *
+ * FIXME also related to skl+ w/a 1136 (also unimplemented as of
+ * now) perhaps?
+ */
+
+ for (level++; level <= ilk_wm_max_level(i915); level++) {
+ enum plane_id plane_id;
+
+ for_each_plane_id_on_crtc(crtc, plane_id) {
+ struct skl_plane_wm *wm =
+ &crtc_state->wm.skl.optimal.planes[plane_id];
+
+ /*
+ * FIXME just clear enable or flag the entire
+ * thing as bad via min_ddb_alloc=U16_MAX?
+ */
+ wm->wm[level].enable = false;
+ wm->uv_wm[level].enable = false;
+ }
+ }
+
+ if (DISPLAY_VER(i915) >= 12 &&
+ i915->display.sagv.block_time_us &&
+ skl_is_vblank_too_short(crtc_state, wm0_lines,
+ i915->display.sagv.block_time_us)) {
+ enum plane_id plane_id;
+
+ for_each_plane_id_on_crtc(crtc, plane_id) {
+ struct skl_plane_wm *wm =
+ &crtc_state->wm.skl.optimal.planes[plane_id];
+
+ wm->sagv.wm0.enable = false;
+ wm->sagv.trans_wm.enable = false;
+ }
+ }
+
+ return 0;
+}
+
static int skl_build_pipe_wm(struct intel_atomic_state *state,
struct intel_crtc *crtc)
{
@@ -2224,7 +2337,7 @@ static int skl_build_pipe_wm(struct intel_atomic_state *state,
crtc_state->wm.skl.optimal = crtc_state->wm.skl.raw;
- return 0;
+ return skl_wm_check_vblank(crtc_state);
}
static void skl_ddb_entry_write(struct drm_i915_private *i915,
--
2.39.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: vblank stuff (rev2)
2023-01-27 17:30 [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Ville Syrjala
` (3 preceding siblings ...)
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 4/4] drm/i915: Reject wm levels that exceed vblank time Ville Syrjala
@ 2023-01-27 19:53 ` Patchwork
2023-01-28 0:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-22 13:41 ` [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Hogander, Jouni
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-27 19:53 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6914 bytes --]
== Series Details ==
Series: drm/i915: vblank stuff (rev2)
URL : https://patchwork.freedesktop.org/series/112170/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12656 -> Patchwork_112170v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/index.html
Participating hosts (25 -> 25)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_112170v2:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rpls-1}: NOTRUN -> [ABORT][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/bat-rpls-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_pm_rpm@module-reload:
- {bat-rplp-1}: [PASS][2] -> [DMESG-FAIL][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/bat-rplp-1/igt@i915_pm_rpm@module-reload.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/bat-rplp-1/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@dmabuf:
- {bat-rplp-1}: [PASS][4] -> [DMESG-WARN][5] +13 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/bat-rplp-1/igt@i915_selftest@live@dmabuf.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/bat-rplp-1/igt@i915_selftest@live@dmabuf.html
Known issues
------------
Here are the changes found in Patchwork_112170v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][8] ([i915#7156])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#5334] / [i915#7872])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][10] ([i915#1886])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [PASS][11] -> [ABORT][12] ([i915#4983])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][13] ([fdo#109271]) +15 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- {bat-adln-1}: [INCOMPLETE][14] ([i915#4983] / [i915#7609]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/bat-adln-1/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@guc:
- {bat-rpls-2}: [DMESG-WARN][16] ([i915#7852]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/bat-rpls-2/igt@i915_selftest@live@guc.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/bat-rpls-2/igt@i915_selftest@live@guc.html
* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [ABORT][18] -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/bat-rpls-1/igt@i915_selftest@live@reset.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_suspend@basic-s3-without-i915:
- {bat-adlm-1}: [ABORT][20] -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/bat-adlm-1/igt@i915_suspend@basic-s3-without-i915.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/bat-adlm-1/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7156]: https://gitlab.freedesktop.org/drm/intel/issues/7156
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
Build changes
-------------
* Linux: CI_DRM_12656 -> Patchwork_112170v2
CI-20190529: 20190529
CI_DRM_12656: 5a9d8eeec978f2373afe9e049eaa42f67b42074a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7140: ec87a6a636b9337ac9c8fec57350812bcb48fc09 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112170v2: 5a9d8eeec978f2373afe9e049eaa42f67b42074a @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5864bf503848 drm/i915: Reject wm levels that exceed vblank time
1d9e8eb3b0dd drm/i915: Extract skl_wm_latency()
93740cd62edf drm/i915/psr: Fix the delayed vblank w/a
b9253f4b1703 drm/i915/vrr: Fix "window2" handling
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/index.html
[-- Attachment #2: Type: text/html, Size: 7708 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: vblank stuff (rev2)
2023-01-27 17:30 [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Ville Syrjala
` (4 preceding siblings ...)
2023-01-27 19:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: vblank stuff (rev2) Patchwork
@ 2023-01-28 0:20 ` Patchwork
2023-02-22 13:41 ` [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Hogander, Jouni
6 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-28 0:20 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 21889 bytes --]
== Series Details ==
Series: drm/i915: vblank stuff (rev2)
URL : https://patchwork.freedesktop.org/series/112170/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12656_full -> Patchwork_112170v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/index.html
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_112170v2_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_suspend@basic-s3@smem:
- {shard-tglu}: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-tglu-4/igt@gem_exec_suspend@basic-s3@smem.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-tglu-6/igt@gem_exec_suspend@basic-s3@smem.html
Known issues
------------
Here are the changes found in Patchwork_112170v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-glk5/igt@gem_exec_fair@basic-none-solo@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-glk7/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271]) +10 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-glk7/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][6] ([i915#6268]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-tglu-2/igt@gem_ctx_exec@basic-nohangcheck.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-tglu-4/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_balancer@fairslice:
- {shard-rkl}: [SKIP][8] ([i915#6259]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-5/igt@gem_exec_balancer@fairslice.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-3/igt@gem_exec_balancer@fairslice.html
* igt@gem_exec_fair@basic-deadline:
- {shard-rkl}: [FAIL][10] ([i915#2846]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-3/igt@gem_exec_fair@basic-deadline.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-5/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][12] ([i915#2842]) -> [PASS][13] +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-glk7/igt@gem_exec_fair@basic-none-share@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-glk3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- {shard-rkl}: [FAIL][14] ([i915#2842]) -> [PASS][15] +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-1/igt@gem_exec_fair@basic-none@vcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-5/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_reloc@basic-write-read-noreloc:
- {shard-rkl}: [SKIP][16] ([i915#3281]) -> [PASS][17] +9 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-3/igt@gem_exec_reloc@basic-write-read-noreloc.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-5/igt@gem_exec_reloc@basic-write-read-noreloc.html
* igt@gem_pwrite_snooped:
- {shard-rkl}: [SKIP][18] ([i915#3282]) -> [PASS][19] +6 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-3/igt@gem_pwrite_snooped.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-5/igt@gem_pwrite_snooped.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [ABORT][20] -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-glk5/igt@gen9_exec_parse@allowed-single.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-glk7/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@shadow-peek:
- {shard-rkl}: [SKIP][22] ([i915#2527]) -> [PASS][23] +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-3/igt@gen9_exec_parse@shadow-peek.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-5/igt@gen9_exec_parse@shadow-peek.html
* igt@i915_pm_dc@dc5-dpms:
- {shard-rkl}: [FAIL][24] -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-5/igt@i915_pm_dc@dc5-dpms.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-4/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-rkl}: [SKIP][26] ([i915#3361]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-5/igt@i915_pm_dc@dc6-dpms.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-6/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- {shard-dg1}: [FAIL][28] ([i915#3591]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][30] ([i915#1397]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-4/igt@i915_pm_rpm@dpms-lpsp.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-6/igt@i915_pm_rpm@dpms-lpsp.html
- {shard-tglu}: [SKIP][32] ([i915#1397]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-tglu-6/igt@i915_pm_rpm@dpms-lpsp.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-tglu-8/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@drm-resources-equal:
- {shard-rkl}: [SKIP][34] ([fdo#109308]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-5/igt@i915_pm_rpm@drm-resources-equal.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-6/igt@i915_pm_rpm@drm-resources-equal.html
* igt@i915_pm_rpm@modeset-non-lpsp:
- {shard-dg1}: [SKIP][36] ([i915#1397]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-dg1-17/igt@i915_pm_rpm@modeset-non-lpsp.html
* igt@kms_big_fb@linear-32bpp-rotate-0:
- {shard-rkl}: [SKIP][38] ([i915#1845] / [i915#4098]) -> [PASS][39] +35 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-4/igt@kms_big_fb@linear-32bpp-rotate-0.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-6/igt@kms_big_fb@linear-32bpp-rotate-0.html
* igt@kms_big_fb@x-tiled-addfb-size-offset-overflow:
- {shard-tglu}: [SKIP][40] ([i915#1845] / [i915#7651]) -> [PASS][41] +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-tglu-6/igt@kms_big_fb@x-tiled-addfb-size-offset-overflow.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-tglu-8/igt@kms_big_fb@x-tiled-addfb-size-offset-overflow.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs:
- {shard-tglu}: [SKIP][42] ([i915#7651]) -> [PASS][43] +22 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-tglu-6/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-tglu-8/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt:
- {shard-tglu}: [SKIP][44] ([i915#1849]) -> [PASS][45] +6 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-tglu-8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render:
- {shard-rkl}: [SKIP][46] ([i915#1849] / [i915#4098]) -> [PASS][47] +26 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html
* igt@kms_plane@plane-panning-bottom-right@pipe-a-planes:
- {shard-rkl}: [SKIP][48] ([i915#1849]) -> [PASS][49] +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-1/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-6/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
* igt@kms_psr@sprite_mmap_gtt:
- {shard-rkl}: [SKIP][50] ([i915#1072]) -> [PASS][51] +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-4/igt@kms_psr@sprite_mmap_gtt.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-6/igt@kms_psr@sprite_mmap_gtt.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- {shard-tglu}: [SKIP][52] ([fdo#109274]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-tglu-6/igt@kms_universal_plane@disable-primary-vs-flip-pipe-d.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-tglu-8/igt@kms_universal_plane@disable-primary-vs-flip-pipe-d.html
* igt@prime_vgem@basic-fence-flip:
- {shard-rkl}: [SKIP][54] ([fdo#109295] / [i915#3708] / [i915#4098]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-5/igt@prime_vgem@basic-fence-flip.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-6/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@coherency-gtt:
- {shard-rkl}: [SKIP][56] ([fdo#109295] / [fdo#111656] / [i915#3708]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-3/igt@prime_vgem@coherency-gtt.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-5/igt@prime_vgem@coherency-gtt.html
* igt@testdisplay:
- {shard-rkl}: [SKIP][58] ([i915#4098]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12656/shard-rkl-1/igt@testdisplay.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/shard-rkl-6/igt@testdisplay.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
Build changes
-------------
* Linux: CI_DRM_12656 -> Patchwork_112170v2
CI-20190529: 20190529
CI_DRM_12656: 5a9d8eeec978f2373afe9e049eaa42f67b42074a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7140: ec87a6a636b9337ac9c8fec57350812bcb48fc09 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112170v2: 5a9d8eeec978f2373afe9e049eaa42f67b42074a @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112170v2/index.html
[-- Attachment #2: Type: text/html, Size: 15949 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Extract skl_wm_latency()
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 3/4] drm/i915: Extract skl_wm_latency() Ville Syrjala
@ 2023-02-22 9:25 ` Hogander, Jouni
2023-02-22 13:34 ` Ville Syrjälä
0 siblings, 1 reply; 10+ messages in thread
From: Hogander, Jouni @ 2023-02-22 9:25 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
On Fri, 2023-01-27 at 19:30 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Extract the skl+ wm latency determination into a small helper
> so that everyone has the same idea what the latency should be.
>
> This introduces a slight functional change in that
> skl_cursor_allocation() will now start to account for the
> extra 4 usec that the kbk/cfl/cml IPC w/a adds.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/skl_watermark.c | 40 +++++++++++++-----
> --
> 1 file changed, 26 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c
> b/drivers/gpu/drm/i915/display/skl_watermark.c
> index ae4e9e680c2e..65c746d018b5 100644
> --- a/drivers/gpu/drm/i915/display/skl_watermark.c
> +++ b/drivers/gpu/drm/i915/display/skl_watermark.c
> @@ -704,6 +704,28 @@ static void skl_compute_plane_wm(const struct
> intel_crtc_state *crtc_state,
> const struct skl_wm_level
> *result_prev,
> struct skl_wm_level *result /* out
> */);
>
> +static unsigned int skl_wm_latency(struct drm_i915_private *i915,
> int level,
> + const struct skl_wm_params *wp)
> +{
> + unsigned int latency = i915->display.wm.skl_latency[level];
> +
> + if (latency == 0)
> + return 0;
What does it mean if latency is 0 here? Why it is ok to skip checks for
ipc_enabled and memory bandwidth workaround?
> +
> + /*
> + * WaIncreaseLatencyIPCEnabled: kbl,cfl
> + * Display WA #1141: kbl,cfl
> + */
> + if ((IS_KABYLAKE(i915) || IS_COFFEELAKE(i915) ||
> IS_COMETLAKE(i915)) &&
> + skl_watermark_ipc_enabled(i915))
> + latency += 4;
> +
> + if (skl_needs_memory_bw_wa(i915) && wp->x_tiled)
> + latency += 15;
> +
> + return latency;
> +}
> +
> static unsigned int
> skl_cursor_allocation(const struct intel_crtc_state *crtc_state,
> int num_active)
> @@ -723,7 +745,7 @@ skl_cursor_allocation(const struct
> intel_crtc_state *crtc_state,
> drm_WARN_ON(&i915->drm, ret);
>
> for (level = 0; level <= max_level; level++) {
> - unsigned int latency = i915-
> >display.wm.skl_latency[level];
> + unsigned int latency = skl_wm_latency(i915, level,
> &wp);
>
> skl_compute_plane_wm(crtc_state, plane, level,
> latency, &wp, &wm, &wm);
> if (wm.min_ddb_alloc == U16_MAX)
> @@ -1834,17 +1856,6 @@ static void skl_compute_plane_wm(const struct
> intel_crtc_state *crtc_state,
> return;
> }
>
> - /*
> - * WaIncreaseLatencyIPCEnabled: kbl,cfl
> - * Display WA #1141: kbl,cfl
> - */
> - if ((IS_KABYLAKE(i915) || IS_COFFEELAKE(i915) ||
> IS_COMETLAKE(i915)) &&
> - skl_watermark_ipc_enabled(i915))
> - latency += 4;
> -
> - if (skl_needs_memory_bw_wa(i915) && wp->x_tiled)
> - latency += 15;
> -
> method1 = skl_wm_method1(i915, wp->plane_pixel_rate,
> wp->cpp, latency, wp-
> >dbuf_block_size);
> method2 = skl_wm_method2(wp->plane_pixel_rate,
> @@ -1971,7 +1982,7 @@ skl_compute_wm_levels(const struct
> intel_crtc_state *crtc_state,
>
> for (level = 0; level <= max_level; level++) {
> struct skl_wm_level *result = &levels[level];
> - unsigned int latency = i915-
> >display.wm.skl_latency[level];
> + unsigned int latency = skl_wm_latency(i915, level,
> wm_params);
>
> skl_compute_plane_wm(crtc_state, plane, level,
> latency,
> wm_params, result_prev, result);
> @@ -1991,7 +2002,8 @@ static void tgl_compute_sagv_wm(const struct
> intel_crtc_state *crtc_state,
> unsigned int latency = 0;
>
> if (i915->display.sagv.block_time_us)
> - latency = i915->display.sagv.block_time_us + i915-
> >display.wm.skl_latency[0];
> + latency = i915->display.sagv.block_time_us +
> + skl_wm_latency(i915, 0, wm_params);
>
> skl_compute_plane_wm(crtc_state, plane, 0, latency,
> wm_params, &levels[0],
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Extract skl_wm_latency()
2023-02-22 9:25 ` Hogander, Jouni
@ 2023-02-22 13:34 ` Ville Syrjälä
0 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2023-02-22 13:34 UTC (permalink / raw)
To: Hogander, Jouni; +Cc: intel-gfx@lists.freedesktop.org
On Wed, Feb 22, 2023 at 09:25:56AM +0000, Hogander, Jouni wrote:
> On Fri, 2023-01-27 at 19:30 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Extract the skl+ wm latency determination into a small helper
> > so that everyone has the same idea what the latency should be.
> >
> > This introduces a slight functional change in that
> > skl_cursor_allocation() will now start to account for the
> > extra 4 usec that the kbk/cfl/cml IPC w/a adds.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/display/skl_watermark.c | 40 +++++++++++++-----
> > --
> > 1 file changed, 26 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c
> > b/drivers/gpu/drm/i915/display/skl_watermark.c
> > index ae4e9e680c2e..65c746d018b5 100644
> > --- a/drivers/gpu/drm/i915/display/skl_watermark.c
> > +++ b/drivers/gpu/drm/i915/display/skl_watermark.c
> > @@ -704,6 +704,28 @@ static void skl_compute_plane_wm(const struct
> > intel_crtc_state *crtc_state,
> > const struct skl_wm_level
> > *result_prev,
> > struct skl_wm_level *result /* out
> > */);
> >
> > +static unsigned int skl_wm_latency(struct drm_i915_private *i915,
> > int level,
> > + const struct skl_wm_params *wp)
> > +{
> > + unsigned int latency = i915->display.wm.skl_latency[level];
> > +
> > + if (latency == 0)
> > + return 0;
>
> What does it mean if latency is 0 here? Why it is ok to skip checks for
> ipc_enabled and memory bandwidth workaround?
Zero latency means this watermark level is disabled.
> > +
> > + /*
> > + * WaIncreaseLatencyIPCEnabled: kbl,cfl
> > + * Display WA #1141: kbl,cfl
> > + */
> > + if ((IS_KABYLAKE(i915) || IS_COFFEELAKE(i915) ||
> > IS_COMETLAKE(i915)) &&
> > + skl_watermark_ipc_enabled(i915))
> > + latency += 4;
> > +
> > + if (skl_needs_memory_bw_wa(i915) && wp->x_tiled)
> > + latency += 15;
> > +
> > + return latency;
> > +}
> > +
> > static unsigned int
> > skl_cursor_allocation(const struct intel_crtc_state *crtc_state,
> > int num_active)
> > @@ -723,7 +745,7 @@ skl_cursor_allocation(const struct
> > intel_crtc_state *crtc_state,
> > drm_WARN_ON(&i915->drm, ret);
> >
> > for (level = 0; level <= max_level; level++) {
> > - unsigned int latency = i915-
> > >display.wm.skl_latency[level];
> > + unsigned int latency = skl_wm_latency(i915, level,
> > &wp);
> >
> > skl_compute_plane_wm(crtc_state, plane, level,
> > latency, &wp, &wm, &wm);
> > if (wm.min_ddb_alloc == U16_MAX)
> > @@ -1834,17 +1856,6 @@ static void skl_compute_plane_wm(const struct
> > intel_crtc_state *crtc_state,
> > return;
> > }
> >
> > - /*
> > - * WaIncreaseLatencyIPCEnabled: kbl,cfl
> > - * Display WA #1141: kbl,cfl
> > - */
> > - if ((IS_KABYLAKE(i915) || IS_COFFEELAKE(i915) ||
> > IS_COMETLAKE(i915)) &&
> > - skl_watermark_ipc_enabled(i915))
> > - latency += 4;
> > -
> > - if (skl_needs_memory_bw_wa(i915) && wp->x_tiled)
> > - latency += 15;
> > -
> > method1 = skl_wm_method1(i915, wp->plane_pixel_rate,
> > wp->cpp, latency, wp-
> > >dbuf_block_size);
> > method2 = skl_wm_method2(wp->plane_pixel_rate,
> > @@ -1971,7 +1982,7 @@ skl_compute_wm_levels(const struct
> > intel_crtc_state *crtc_state,
> >
> > for (level = 0; level <= max_level; level++) {
> > struct skl_wm_level *result = &levels[level];
> > - unsigned int latency = i915-
> > >display.wm.skl_latency[level];
> > + unsigned int latency = skl_wm_latency(i915, level,
> > wm_params);
> >
> > skl_compute_plane_wm(crtc_state, plane, level,
> > latency,
> > wm_params, result_prev, result);
> > @@ -1991,7 +2002,8 @@ static void tgl_compute_sagv_wm(const struct
> > intel_crtc_state *crtc_state,
> > unsigned int latency = 0;
> >
> > if (i915->display.sagv.block_time_us)
> > - latency = i915->display.sagv.block_time_us + i915-
> > >display.wm.skl_latency[0];
> > + latency = i915->display.sagv.block_time_us +
> > + skl_wm_latency(i915, 0, wm_params);
> >
> > skl_compute_plane_wm(crtc_state, plane, 0, latency,
> > wm_params, &levels[0],
>
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff
2023-01-27 17:30 [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Ville Syrjala
` (5 preceding siblings ...)
2023-01-28 0:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-02-22 13:41 ` Hogander, Jouni
6 siblings, 0 replies; 10+ messages in thread
From: Hogander, Jouni @ 2023-02-22 13:41 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
On Fri, 2023-01-27 at 19:30 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> A bunch of stuff related to vblank length/start.
>
> v2: Fix inactive pipe handling
> Fix SAGV handling
> Fix some typos
For the whole set:
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
>
> Ville Syrjälä (4):
> drm/i915/vrr: Fix "window2" handling
> drm/i915/psr: Fix the delayed vblank w/a
> drm/i915: Extract skl_wm_latency()
> drm/i915: Reject wm levels that exceed vblank time
>
> drivers/gpu/drm/i915/display/intel_psr.c | 9 +-
> drivers/gpu/drm/i915/display/intel_vrr.c | 10 +-
> drivers/gpu/drm/i915/display/skl_watermark.c | 155
> +++++++++++++++++--
> 3 files changed, 144 insertions(+), 30 deletions(-)
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-02-22 13:41 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-27 17:30 [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Ville Syrjala
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 1/4] drm/i915/vrr: Fix "window2" handling Ville Syrjala
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 2/4] drm/i915/psr: Fix the delayed vblank w/a Ville Syrjala
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 3/4] drm/i915: Extract skl_wm_latency() Ville Syrjala
2023-02-22 9:25 ` Hogander, Jouni
2023-02-22 13:34 ` Ville Syrjälä
2023-01-27 17:30 ` [Intel-gfx] [PATCH v2 4/4] drm/i915: Reject wm levels that exceed vblank time Ville Syrjala
2023-01-27 19:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: vblank stuff (rev2) Patchwork
2023-01-28 0:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-22 13:41 ` [Intel-gfx] [PATCH v2 0/4] drm/i915: vblank stuff Hogander, Jouni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.