* [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug
@ 2023-02-27 10:06 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2023-02-27 10:06 UTC (permalink / raw)
To: Kieran Bingham
Cc: Laurent Pinchart, David Airlie, Daniel Vetter, dri-devel,
linux-renesas-soc, kernel-janitors
The drmm_encoder_alloc() function returns error pointers. It never
returns NULL. Fix the check accordingly.
Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
index b1787be31e92..7ecec7b04a8d 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
@@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu,
renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base,
&rcar_du_encoder_funcs, DRM_MODE_ENCODER_NONE,
NULL);
- if (!renc)
- return -ENOMEM;
+ if (IS_ERR(renc))
+ return PTR_ERR(renc);
renc->output = output;
--
2.39.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug
@ 2023-02-27 10:06 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2023-02-27 10:06 UTC (permalink / raw)
To: Kieran Bingham
Cc: kernel-janitors, dri-devel, linux-renesas-soc, Laurent Pinchart
The drmm_encoder_alloc() function returns error pointers. It never
returns NULL. Fix the check accordingly.
Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
index b1787be31e92..7ecec7b04a8d 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
@@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu,
renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base,
&rcar_du_encoder_funcs, DRM_MODE_ENCODER_NONE,
NULL);
- if (!renc)
- return -ENOMEM;
+ if (IS_ERR(renc))
+ return PTR_ERR(renc);
renc->output = output;
--
2.39.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug
2023-02-27 10:06 ` Dan Carpenter
@ 2023-02-27 11:31 ` Kieran Bingham
-1 siblings, 0 replies; 6+ messages in thread
From: Kieran Bingham @ 2023-02-27 11:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Laurent Pinchart, David Airlie, Daniel Vetter, dri-devel,
linux-renesas-soc, kernel-janitors
Quoting Dan Carpenter (2023-02-27 10:06:59)
> The drmm_encoder_alloc() function returns error pointers. It never
> returns NULL. Fix the check accordingly.
Yes, indeed. Thanks.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> index b1787be31e92..7ecec7b04a8d 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> @@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu,
> renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base,
> &rcar_du_encoder_funcs, DRM_MODE_ENCODER_NONE,
> NULL);
> - if (!renc)
> - return -ENOMEM;
> + if (IS_ERR(renc))
> + return PTR_ERR(renc);
>
> renc->output = output;
>
> --
> 2.39.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug
@ 2023-02-27 11:31 ` Kieran Bingham
0 siblings, 0 replies; 6+ messages in thread
From: Kieran Bingham @ 2023-02-27 11:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: kernel-janitors, dri-devel, linux-renesas-soc, Laurent Pinchart
Quoting Dan Carpenter (2023-02-27 10:06:59)
> The drmm_encoder_alloc() function returns error pointers. It never
> returns NULL. Fix the check accordingly.
Yes, indeed. Thanks.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> index b1787be31e92..7ecec7b04a8d 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> @@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu,
> renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base,
> &rcar_du_encoder_funcs, DRM_MODE_ENCODER_NONE,
> NULL);
> - if (!renc)
> - return -ENOMEM;
> + if (IS_ERR(renc))
> + return PTR_ERR(renc);
>
> renc->output = output;
>
> --
> 2.39.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug
2023-02-27 10:06 ` Dan Carpenter
@ 2023-02-27 14:38 ` Laurent Pinchart
-1 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2023-02-27 14:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kieran Bingham, David Airlie, Daniel Vetter, dri-devel,
linux-renesas-soc, kernel-janitors
Hi Dan,
Thank you for the patch.
On Mon, Feb 27, 2023 at 01:06:59PM +0300, Dan Carpenter wrote:
> The drmm_encoder_alloc() function returns error pointers. It never
> returns NULL. Fix the check accordingly.
>
> Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> index b1787be31e92..7ecec7b04a8d 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> @@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu,
> renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base,
> &rcar_du_encoder_funcs, DRM_MODE_ENCODER_NONE,
> NULL);
> - if (!renc)
> - return -ENOMEM;
> + if (IS_ERR(renc))
> + return PTR_ERR(renc);
>
> renc->output = output;
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug
@ 2023-02-27 14:38 ` Laurent Pinchart
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2023-02-27 14:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: kernel-janitors, dri-devel, linux-renesas-soc, Kieran Bingham
Hi Dan,
Thank you for the patch.
On Mon, Feb 27, 2023 at 01:06:59PM +0300, Dan Carpenter wrote:
> The drmm_encoder_alloc() function returns error pointers. It never
> returns NULL. Fix the check accordingly.
>
> Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> index b1787be31e92..7ecec7b04a8d 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> @@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu,
> renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base,
> &rcar_du_encoder_funcs, DRM_MODE_ENCODER_NONE,
> NULL);
> - if (!renc)
> - return -ENOMEM;
> + if (IS_ERR(renc))
> + return PTR_ERR(renc);
>
> renc->output = output;
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-27 14:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-27 10:06 [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug Dan Carpenter
2023-02-27 10:06 ` Dan Carpenter
2023-02-27 11:31 ` Kieran Bingham
2023-02-27 11:31 ` Kieran Bingham
2023-02-27 14:38 ` Laurent Pinchart
2023-02-27 14:38 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.