Re: [Intel-xe] [PATCH v2 01/11] drm/xe: Remove outdated build workaround

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Feb 16, 2023 at 04:52:16PM -0800, Lucas De Marchi wrote:
> Use the more common "call cc-disable-warning" way to disable warnings.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/xe/Makefile | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index abd804d622e6..18257cd7227d 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -13,14 +13,8 @@
>  # will most likely get a sudden build breakage... Hopefully we will fix
>  # new warnings before CI updates!
>  subdir-ccflags-y := -Wall -Wextra
> -# making these call cc-disable-warning breaks when trying to build xe.mod.o
> -# by calling make M=drivers/gpu/drm/xe. This doesn't happen in upstream tree,
> -# so it was somehow fixed by the changes in the build system. Move it back to
> -# $(call cc-disable-warning, ...) after rebase.
> -subdir-ccflags-y += -Wno-unused-parameter
> -subdir-ccflags-y += -Wno-type-limits
> -#subdir-ccflags-y += $(call cc-disable-warning, unused-parameter)
> -#subdir-ccflags-y += $(call cc-disable-warning, type-limits)
> +subdir-ccflags-y += $(call cc-disable-warning, unused-parameter)
> +subdir-ccflags-y += $(call cc-disable-warning, type-limits)
>  subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)
>  subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
>  # clang warnings
> -- 
> 2.39.0
>