From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v4 6/6] serial: 8250_em: Add serial8250_em_{reg_update(),out_helper()}
Date: Fri, 17 Feb 2023 17:15:00 +0200 [thread overview]
Message-ID: <Y++Z9G/ouZQE/BTM@smile.fi.intel.com> (raw)
In-Reply-To: <OS0PR01MB5922982DB09B8F1DFD70602186A19@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On Fri, Feb 17, 2023 at 02:35:16PM +0000, Biju Das wrote:
> Hi Andy,
> > Subject: Re: [PATCH v4 6/6] serial: 8250_em: Add
> > serial8250_em_{reg_update(),out_helper()}
> > On Fri, Feb 17, 2023 at 11:42:55AM +0000, Biju Das wrote:
...
> > > + switch (off) {
> > > + case UART_FCR_EM:
> > > + fcr = value;
> > > + break;
> > > + case UART_LCR:
> > > + lcr = value;
> > > + break;
> > > + case UART_MCR:
> > > + mcr = value;
> >
> > Missing break; statement.
>
> OK, will fix this in next version.
>
> The original driver has some missing breaks[1].
> So for consistency I dropped this. same for below.
I see. Perhaps you can add another patch that adds them there first?
> [1] https://elixir.bootlin.com/linux/v6.2-rc8/source/drivers/tty/serial/8250/8250_em.c#L45
> > > + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-17 15:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 11:42 [PATCH v4 0/6] Update Renesas {EMMA mobile, RZ/V2M} UART Port type Biju Das
2023-02-17 11:42 ` [PATCH v4 1/6] serial: 8250_em: Use dev_err_probe() Biju Das
2023-02-17 14:03 ` Andy Shevchenko
2023-02-17 14:14 ` Biju Das
2023-02-17 11:42 ` [PATCH v4 2/6] serial: 8250_em: Drop slab.h Biju Das
2023-02-17 14:05 ` Andy Shevchenko
2023-02-17 14:30 ` Biju Das
2023-02-17 15:13 ` Andy Shevchenko
2023-02-17 15:17 ` Biju Das
2023-02-17 11:42 ` [PATCH v4 3/6] serial: 8250_em: Use devm_clk_get_enabled() Biju Das
2023-02-17 11:42 ` [PATCH v4 4/6] serial: 8250_em: Update port type as PORT_16750 Biju Das
2023-02-17 14:06 ` Andy Shevchenko
2023-02-17 14:53 ` Biju Das
2023-02-17 11:42 ` [PATCH v4 5/6] serial: 8250_em: Use pseudo offset for UART_FCR Biju Das
2023-02-17 11:46 ` Ilpo Järvinen
2023-02-17 11:56 ` Biju Das
2023-02-17 12:00 ` Ilpo Järvinen
2023-02-17 12:11 ` Biju Das
2023-02-17 12:42 ` Ilpo Järvinen
2023-02-17 12:58 ` Biju Das
2023-02-17 13:03 ` Ilpo Järvinen
2023-02-17 11:42 ` [PATCH v4 6/6] serial: 8250_em: Add serial8250_em_{reg_update(),out_helper()} Biju Das
2023-02-17 14:14 ` Andy Shevchenko
2023-02-17 14:35 ` Biju Das
2023-02-17 15:15 ` Andy Shevchenko [this message]
2023-02-17 15:24 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y++Z9G/ouZQE/BTM@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.