From: Joerg Roedel <joro@8bytes.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Leon Romanovsky <leon@kernel.org>,
Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
bhelgaas@google.com, jean-philippe@linaro.org,
darren@os.amperecomputing.com, scott@os.amperecomputing.com,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev
Subject: Re: [PATCH] PCI/ATS: Allow to enable ATS on VFs even if it is not enabled on PF
Date: Thu, 16 Feb 2023 11:23:29 +0100 [thread overview]
Message-ID: <Y+4EITP08CKPWMWl@8bytes.org> (raw)
In-Reply-To: <20230215205726.GA3213227@bhelgaas>
On Wed, Feb 15, 2023 at 02:57:26PM -0600, Bjorn Helgaas wrote:
> [+cc Will, Robin, Joerg for arm-smmu-v3 page size question]
>
> On Sun, Feb 12, 2023 at 08:14:48PM +0200, Leon Romanovsky wrote:
> > On Wed, Feb 08, 2023 at 10:43:21AM -0800, Ganapatrao Kulkarni wrote:
> > > As per PCIe specification(section 10.5), If a VF implements an
> > > ATS capability, its associated PF must implement an ATS capability.
> > > The ATS Capabilities in VFs and their associated PFs are permitted to
> > > be enabled independently.
Well, the spec is one thing, existing hardware the other. Have you
checked the history of the PF-before-VF requirement before making that
change?
It is possible that early PASID-capable hardware actually required
PF-before-VF enablement of ATS.
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Leon Romanovsky <leon@kernel.org>,
Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
bhelgaas@google.com, jean-philippe@linaro.org,
darren@os.amperecomputing.com, scott@os.amperecomputing.com,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev
Subject: Re: [PATCH] PCI/ATS: Allow to enable ATS on VFs even if it is not enabled on PF
Date: Thu, 16 Feb 2023 11:23:29 +0100 [thread overview]
Message-ID: <Y+4EITP08CKPWMWl@8bytes.org> (raw)
In-Reply-To: <20230215205726.GA3213227@bhelgaas>
On Wed, Feb 15, 2023 at 02:57:26PM -0600, Bjorn Helgaas wrote:
> [+cc Will, Robin, Joerg for arm-smmu-v3 page size question]
>
> On Sun, Feb 12, 2023 at 08:14:48PM +0200, Leon Romanovsky wrote:
> > On Wed, Feb 08, 2023 at 10:43:21AM -0800, Ganapatrao Kulkarni wrote:
> > > As per PCIe specification(section 10.5), If a VF implements an
> > > ATS capability, its associated PF must implement an ATS capability.
> > > The ATS Capabilities in VFs and their associated PFs are permitted to
> > > be enabled independently.
Well, the spec is one thing, existing hardware the other. Have you
checked the history of the PF-before-VF requirement before making that
change?
It is possible that early PASID-capable hardware actually required
PF-before-VF enablement of ATS.
Regards,
Joerg
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-16 10:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 18:43 [PATCH] PCI/ATS: Allow to enable ATS on VFs even if it is not enabled on PF Ganapatrao Kulkarni
2023-02-12 18:14 ` Leon Romanovsky
2023-02-15 20:57 ` Bjorn Helgaas
2023-02-15 20:57 ` Bjorn Helgaas
2023-02-16 7:26 ` Leon Romanovsky
2023-02-16 7:26 ` Leon Romanovsky
2023-02-16 7:46 ` Leon Romanovsky
2023-02-16 7:46 ` Leon Romanovsky
2023-02-16 10:47 ` Jean-Philippe Brucker
2023-02-16 10:47 ` Jean-Philippe Brucker
2023-02-16 10:23 ` Joerg Roedel [this message]
2023-02-16 10:23 ` Joerg Roedel
2023-02-16 11:12 ` Jean-Philippe Brucker
2023-02-16 11:12 ` Jean-Philippe Brucker
2023-02-16 11:36 ` Ganapatrao Kulkarni
2023-02-16 11:36 ` Ganapatrao Kulkarni
2023-02-21 9:13 ` Ganapatrao Kulkarni
2023-02-21 9:13 ` Ganapatrao Kulkarni
2023-02-21 15:46 ` Bjorn Helgaas
2023-02-21 15:46 ` Bjorn Helgaas
2023-02-23 15:45 ` Jean-Philippe Brucker
2023-02-23 15:45 ` Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+4EITP08CKPWMWl@8bytes.org \
--to=joro@8bytes.org \
--cc=bhelgaas@google.com \
--cc=darren@os.amperecomputing.com \
--cc=gankulkarni@os.amperecomputing.com \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=scott@os.amperecomputing.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.