From: Simon Horman <simon.horman@corigine.com>
To: Oz Shlomo <ozsh@nvidia.com>
Cc: netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Roi Dayan <roid@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
Marcelo Ricardo Leitner <mleitner@redhat.com>,
Baowen Zheng <baowen.zheng@corigine.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Edward Cree <ecree.xilinx@gmail.com>
Subject: Re: [PATCH net-next v2 5/9] net/sched: support per action hw stats
Date: Mon, 6 Feb 2023 11:52:41 +0100 [thread overview]
Message-ID: <Y+Db+TORfF4a6gHA@corigine.com> (raw)
In-Reply-To: <20230205135525.27760-6-ozsh@nvidia.com>
On Sun, Feb 05, 2023 at 03:55:21PM +0200, Oz Shlomo wrote:
> There are currently two mechanisms for populating hardware stats:
> 1. Using flow_offload api to query the flow's statistics.
> The api assumes that the same stats values apply to all
> the flow's actions.
> This assumption breaks when action drops or jumps over following
> actions.
> 2. Using hw_action api to query specific action stats via a driver
> callback method. This api assures the correct action stats for
> the offloaded action, however, it does not apply to the rest of the
> actions in the flow's actions array.
>
> Extend the flow_offload stats callback to indicate that a per action
> stats update is required.
> Use the existing flow_offload_action api to query the action's hw stats.
> In addition, currently the tc action stats utility only updates hw actions.
> Reuse the existing action stats cb infrastructure to query any action
> stats.
>
> Signed-off-by: Oz Shlomo <ozsh@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-02-06 10:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 13:55 [PATCH net-next v2 0/9] add support for per action hw stats Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 1/9] net/sched: optimize action stats api calls Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 2/9] net/sched: act_pedit, setup offload action for action stats query Oz Shlomo
2023-02-06 10:49 ` Simon Horman
2023-02-06 11:48 ` Jamal Hadi Salim
2023-02-06 11:49 ` Jamal Hadi Salim
2023-02-06 11:50 ` Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 3/9] net/sched: pass flow_stats instead of multiple stats args Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 4/9] net/sched: introduce flow_offload action cookie Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 5/9] net/sched: support per action hw stats Oz Shlomo
2023-02-06 10:52 ` Simon Horman [this message]
2023-02-05 13:55 ` [PATCH net-next v2 6/9] net/mlx5e: TC, add hw counter to branching actions Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 7/9] net/mlx5e: TC, store tc action cookies per attr Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 8/9] net/sched: TC, map tc action cookie to a hw counter Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 9/9] net/sched: TC, support per action stats Oz Shlomo
2023-02-06 11:03 ` Simon Horman
2023-02-06 13:10 ` Roi Dayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+Db+TORfF4a6gHA@corigine.com \
--to=simon.horman@corigine.com \
--cc=baowen.zheng@corigine.com \
--cc=ecree.xilinx@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@nvidia.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.