From: Roi Dayan <roid@nvidia.com>
To: Simon Horman <simon.horman@corigine.com>, Oz Shlomo <ozsh@nvidia.com>
Cc: netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Jiri Pirko <jiri@nvidia.com>,
Marcelo Ricardo Leitner <mleitner@redhat.com>,
Baowen Zheng <baowen.zheng@corigine.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Edward Cree <ecree.xilinx@gmail.com>
Subject: Re: [PATCH net-next v2 9/9] net/sched: TC, support per action stats
Date: Mon, 6 Feb 2023 15:10:02 +0200 [thread overview]
Message-ID: <f769cbc4-0d13-d951-9a6d-ff792300a1aa@nvidia.com> (raw)
In-Reply-To: <Y+DehoC/fE9LA0uI@corigine.com>
On 06/02/2023 13:03, Simon Horman wrote:
> On Sun, Feb 05, 2023 at 03:55:25PM +0200, Oz Shlomo wrote:
>> Extend the action stats callback implementation to update stats for actions
>> that are associated with hw counters.
>> Note that the callback may be called from tc action utility or from tc
>> flower. Both apis expect the driver to return the stats difference from
>> the last update. As such, query the raw counter value and maintain
>> the diff from the last api call in the tc layer, instead of the fs_core
>> layer.
>>
>> Signed-off-by: Oz Shlomo <ozsh@nvidia.com>
>> Reviewed-by: Roi Dayan <roid@nvidia.com>
>
> nit: I think the prefix for this patch should be 'net/mlx5e'
it should. missed it i guess. also prev patch 8/9 ".. TC, support per action stats".
thanks
>
>> ---
>> .../net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 2 +-
>> .../ethernet/mellanox/mlx5/core/en/tc/act_stats.c | 44 ++++++++++++++++++++++
>> .../ethernet/mellanox/mlx5/core/en/tc/act_stats.h | 4 ++
>> .../net/ethernet/mellanox/mlx5/core/en/tc_priv.h | 1 +
>> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 39 +++++++++++++------
>> drivers/net/ethernet/mellanox/mlx5/core/en_tc.h | 2 +
>> .../net/ethernet/mellanox/mlx5/core/fs_counters.c | 10 +++++
>> include/linux/mlx5/fs.h | 2 +
>> 8 files changed, 91 insertions(+), 13 deletions(-)
>
> ...
prev parent reply other threads:[~2023-02-06 13:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 13:55 [PATCH net-next v2 0/9] add support for per action hw stats Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 1/9] net/sched: optimize action stats api calls Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 2/9] net/sched: act_pedit, setup offload action for action stats query Oz Shlomo
2023-02-06 10:49 ` Simon Horman
2023-02-06 11:48 ` Jamal Hadi Salim
2023-02-06 11:49 ` Jamal Hadi Salim
2023-02-06 11:50 ` Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 3/9] net/sched: pass flow_stats instead of multiple stats args Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 4/9] net/sched: introduce flow_offload action cookie Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 5/9] net/sched: support per action hw stats Oz Shlomo
2023-02-06 10:52 ` Simon Horman
2023-02-05 13:55 ` [PATCH net-next v2 6/9] net/mlx5e: TC, add hw counter to branching actions Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 7/9] net/mlx5e: TC, store tc action cookies per attr Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 8/9] net/sched: TC, map tc action cookie to a hw counter Oz Shlomo
2023-02-05 13:55 ` [PATCH net-next v2 9/9] net/sched: TC, support per action stats Oz Shlomo
2023-02-06 11:03 ` Simon Horman
2023-02-06 13:10 ` Roi Dayan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f769cbc4-0d13-d951-9a6d-ff792300a1aa@nvidia.com \
--to=roid@nvidia.com \
--cc=baowen.zheng@corigine.com \
--cc=ecree.xilinx@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@nvidia.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.