From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pin-yen Lin <treapking@chromium.org>
Cc: "Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <robert.foss@linaro.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Daniel Scally" <djrscally@gmail.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Prashant Malani" <pmalani@chromium.org>,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
linux-kernel@vger.kernel.org,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
devicetree@vger.kernel.org, "Allen Chen" <allen.chen@ite.com.tw>,
"Lyude Paul" <lyude@redhat.com>,
linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Marek Vasut" <marex@denx.de>, "Xin Ji" <xji@analogixsemi.com>,
"Stephen Boyd" <swboyd@chromium.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Javier Martinez Canillas" <javierm@redhat.com>,
chrome-platform@lists.linux.dev,
"Chen-Yu Tsai" <wenst@chromium.org>,
"José Expósito" <jose.exposito89@gmail.com>
Subject: Re: [PATCH v11 5/9] drm/bridge: anx7625: Check for Type-C during panel registration
Date: Mon, 6 Feb 2023 14:11:08 +0200 [thread overview]
Message-ID: <Y+DuXKlcAQfErVik@smile.fi.intel.com> (raw)
In-Reply-To: <20230204133040.1236799-6-treapking@chromium.org>
On Sat, Feb 04, 2023 at 09:30:36PM +0800, Pin-yen Lin wrote:
> The output port endpoints can be connected to USB-C connectors.
> Running drm_of_find_panel_or_bridge() with such endpoints leads to
> a continuous return value of -EPROBE_DEFER, even though there is
> no panel present.
>
> To avoid this, check for the existence of a "mode-switch" property in
> the port endpoint, and skip panel registration completely if so.
...
> + /*
> + * Don't bother finding a panel if a Type-C `mode-switch` property is
> + * present in one of the endpoints.
> + */
> + for_each_endpoint_of_node(np, sw) {
> + if (of_property_read_bool(sw, "mode-switch")) {
Might be that the same helper can be used here. Dunno if the endpoint traverse
should be used for the other driver as well.
> + of_node_put(sw);
> + return 0;
> + }
> + }
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pin-yen Lin <treapking@chromium.org>
Cc: "Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
dri-devel@lists.freedesktop.org,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Marek Vasut" <marex@denx.de>,
chrome-platform@lists.linux.dev,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
linux-acpi@vger.kernel.org, "Chen-Yu Tsai" <wenst@chromium.org>,
devicetree@vger.kernel.org,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Allen Chen" <allen.chen@ite.com.tw>,
"Stephen Boyd" <swboyd@chromium.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
"Xin Ji" <xji@analogixsemi.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Robert Foss" <robert.foss@linaro.org>,
"Daniel Scally" <djrscally@gmail.com>,
"Prashant Malani" <pmalani@chromium.org>,
"José Expósito" <jose.exposito89@gmail.com>
Subject: Re: [PATCH v11 5/9] drm/bridge: anx7625: Check for Type-C during panel registration
Date: Mon, 6 Feb 2023 14:11:08 +0200 [thread overview]
Message-ID: <Y+DuXKlcAQfErVik@smile.fi.intel.com> (raw)
In-Reply-To: <20230204133040.1236799-6-treapking@chromium.org>
On Sat, Feb 04, 2023 at 09:30:36PM +0800, Pin-yen Lin wrote:
> The output port endpoints can be connected to USB-C connectors.
> Running drm_of_find_panel_or_bridge() with such endpoints leads to
> a continuous return value of -EPROBE_DEFER, even though there is
> no panel present.
>
> To avoid this, check for the existence of a "mode-switch" property in
> the port endpoint, and skip panel registration completely if so.
...
> + /*
> + * Don't bother finding a panel if a Type-C `mode-switch` property is
> + * present in one of the endpoints.
> + */
> + for_each_endpoint_of_node(np, sw) {
> + if (of_property_read_bool(sw, "mode-switch")) {
Might be that the same helper can be used here. Dunno if the endpoint traverse
should be used for the other driver as well.
> + of_node_put(sw);
> + return 0;
> + }
> + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-06 12:11 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 13:30 [PATCH v11 0/9] Register Type-C mode-switch in DP bridge endpoints Pin-yen Lin
2023-02-04 13:30 ` Pin-yen Lin
2023-02-04 13:30 ` [PATCH v11 1/9] device property: Add remote endpoint to devcon matcher Pin-yen Lin
2023-02-04 13:30 ` Pin-yen Lin
2023-02-05 21:11 ` Sakari Ailus
2023-02-05 21:11 ` Sakari Ailus
2023-02-09 4:28 ` Pin-yen Lin
2023-02-09 4:28 ` Pin-yen Lin
2023-02-09 8:24 ` Sakari Ailus
2023-02-09 8:24 ` Sakari Ailus
2023-02-04 13:30 ` [PATCH v11 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks Pin-yen Lin
2023-02-04 13:30 ` Pin-yen Lin
2023-02-04 13:30 ` [PATCH v11 3/9] drm/display: Add Type-C switch helpers Pin-yen Lin
2023-02-04 13:30 ` Pin-yen Lin
2023-02-06 12:08 ` Andy Shevchenko
2023-02-06 12:08 ` Andy Shevchenko
2023-02-06 12:15 ` Jani Nikula
2023-02-06 12:15 ` Jani Nikula
2023-02-07 21:25 ` Andi Shyti
2023-02-07 21:25 ` Andi Shyti
2023-02-20 8:41 ` Pin-yen Lin
2023-02-20 9:02 ` Pin-yen Lin
2023-02-20 9:02 ` Pin-yen Lin
2023-02-04 13:30 ` [PATCH v11 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support Pin-yen Lin
2023-02-04 13:30 ` Pin-yen Lin
2023-02-06 8:43 ` Chen-Yu Tsai
2023-02-06 8:43 ` Chen-Yu Tsai
2023-02-04 13:30 ` [PATCH v11 5/9] drm/bridge: anx7625: Check for Type-C during panel registration Pin-yen Lin
2023-02-04 13:30 ` Pin-yen Lin
2023-02-06 12:11 ` Andy Shevchenko [this message]
2023-02-06 12:11 ` Andy Shevchenko
2023-02-04 13:30 ` [PATCH v11 6/9] drm/bridge: anx7625: Register Type C mode switches Pin-yen Lin
2023-02-04 13:30 ` Pin-yen Lin
2023-02-06 12:16 ` Andy Shevchenko
2023-02-06 12:16 ` Andy Shevchenko
2023-02-17 15:31 ` Nícolas F. R. A. Prado
2023-02-17 15:31 ` Nícolas F. R. A. Prado
2023-02-04 13:30 ` [PATCH v11 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support Pin-yen Lin
2023-02-04 13:30 ` Pin-yen Lin
2023-02-06 10:22 ` Chen-Yu Tsai
2023-02-06 10:22 ` Chen-Yu Tsai
2023-02-07 20:52 ` Rob Herring
2023-02-07 20:52 ` Rob Herring
2023-02-09 3:59 ` Pin-yen Lin
2023-02-09 3:59 ` Pin-yen Lin
2023-02-09 13:58 ` Rob Herring
2023-02-09 13:58 ` Rob Herring
2023-02-10 8:43 ` Pin-yen Lin
2023-02-10 8:43 ` Pin-yen Lin
2023-02-04 13:30 ` [PATCH v11 8/9] drm/bridge: it6505: Fix Kconfig indentation Pin-yen Lin
2023-02-04 13:30 ` Pin-yen Lin
2023-02-04 13:30 ` [PATCH v11 9/9] drm/bridge: it6505: Register Type C mode switches Pin-yen Lin
2023-02-04 13:30 ` Pin-yen Lin
2023-02-06 12:17 ` Andy Shevchenko
2023-02-06 12:17 ` Andy Shevchenko
2023-02-06 8:40 ` [PATCH v11 0/9] Register Type-C mode-switch in DP bridge endpoints Chen-Yu Tsai
2023-02-06 8:40 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+DuXKlcAQfErVik@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=allen.chen@ite.com.tw \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hsinyi@chromium.org \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jose.exposito89@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=pmalani@chromium.org \
--cc=rafael@kernel.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=swboyd@chromium.org \
--cc=treapking@chromium.org \
--cc=tzimmermann@suse.de \
--cc=wenst@chromium.org \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.