From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Arun.Ramadoss@microchip.com,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Wei Fang <wei.fang@nxp.com>,
kernel@pengutronix.de, intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v4 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6
Date: Mon, 6 Feb 2023 21:21:39 +0100 [thread overview]
Message-ID: <Y+FhU+5KJrEYX2CU@lunn.ch> (raw)
In-Reply-To: <20230206183706.GH12366@pengutronix.de>
> SmartEEE will be probably a bit more challenging. If MAC do not
> advertise EEE support, SmartEEE can be enabled. But it would break PTP
> if SmartEEE is active. Except SmartEEE capable PHY implements own PTP
> support. In any case, user space will need extra information to
> identify potential issues.
If we have a MAC driver which does not implement the ethtool set_eee()
and get_eee() ops, and a dev->phydev with the SmartEEE flag set, we
could have net/ethtool/eee.c call direct into phylib.
As for PTP and EEE, maybe we want the core PTP code to try calling
get_eee() and at minimum issue a warning if it is enabled, if it
thinks MAC PTP is being used?
Andrew
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Vladimir Oltean <olteanv@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Wei Fang <wei.fang@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Arun.Ramadoss@microchip.com,
intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net-next v4 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6
Date: Mon, 6 Feb 2023 21:21:39 +0100 [thread overview]
Message-ID: <Y+FhU+5KJrEYX2CU@lunn.ch> (raw)
In-Reply-To: <20230206183706.GH12366@pengutronix.de>
> SmartEEE will be probably a bit more challenging. If MAC do not
> advertise EEE support, SmartEEE can be enabled. But it would break PTP
> if SmartEEE is active. Except SmartEEE capable PHY implements own PTP
> support. In any case, user space will need extra information to
> identify potential issues.
If we have a MAC driver which does not implement the ethtool set_eee()
and get_eee() ops, and a dev->phydev with the SmartEEE flag set, we
could have net/ethtool/eee.c call direct into phylib.
As for PTP and EEE, maybe we want the core PTP code to try calling
get_eee() and at minimum issue a warning if it is enabled, if it
thinks MAC PTP is being used?
Andrew
next prev parent reply other threads:[~2023-02-06 20:22 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 14:58 [Intel-wired-lan] [PATCH net-next v4 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6 Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 01/23] net: dsa: microchip: enable EEE support Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-04 0:14 ` [Intel-wired-lan] " Vladimir Oltean
2023-02-04 0:14 ` Vladimir Oltean
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 02/23] net: phy: add genphy_c45_read_eee_abilities() function Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 17:12 ` [Intel-wired-lan] " Andrew Lunn
2023-02-01 17:12 ` Andrew Lunn
2023-02-04 0:54 ` [Intel-wired-lan] " Vladimir Oltean
2023-02-04 0:54 ` Vladimir Oltean
2023-02-06 10:49 ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 10:49 ` Oleksij Rempel
2023-02-06 11:22 ` [Intel-wired-lan] " Vladimir Oltean
2023-02-06 11:22 ` Vladimir Oltean
2023-02-06 15:42 ` [Intel-wired-lan] " Andrew Lunn
2023-02-06 15:42 ` Andrew Lunn
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 03/23] net: phy: micrel: add ksz9477_get_features() Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 04/23] net: phy: export phy_check_valid() function Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 17:15 ` [Intel-wired-lan] " Andrew Lunn
2023-02-01 17:15 ` Andrew Lunn
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 05/23] net: phy: add genphy_c45_ethtool_get/set_eee() support Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 17:20 ` [Intel-wired-lan] " Andrew Lunn
2023-02-01 17:20 ` Andrew Lunn
2023-02-01 20:18 ` [Intel-wired-lan] " Jakub Kicinski
2023-02-01 20:18 ` Jakub Kicinski
2023-02-04 1:11 ` [Intel-wired-lan] " Vladimir Oltean
2023-02-04 1:11 ` Vladimir Oltean
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 06/23] net: phy: c22: migrate to genphy_c45_write_eee_adv() Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 17:28 ` [Intel-wired-lan] " Andrew Lunn
2023-02-01 17:28 ` Andrew Lunn
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 07/23] net: phy: c45: " Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 08/23] net: phy: migrate phy_init_eee() to genphy_c45_eee_is_active() Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 16:41 ` [Intel-wired-lan] " Andrew Lunn
2023-02-01 16:41 ` Andrew Lunn
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 09/23] net: phy: start using genphy_c45_ethtool_get/set_eee() Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 10/23] net: phy: add driver specific get/set_eee support Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 11/23] net: phy: at803x: implement ethtool access to SmartEEE functionality Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 12/23] net: phy: at803x: ar8035: fix EEE support for half duplex links Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 13/23] net: phy: add PHY specifica flag to signal SmartEEE support Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 14/23] net: phy: at803x: add PHY_SMART_EEE flag to AR8035 Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 15/23] net: phy: add phy_has_smarteee() helper Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 16/23] net: fec: add support for PHYs with SmartEEE support Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 17/23] e1000e: replace EEE ethtool helpers to linkmode variants Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 18/23] igb: " Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 19/23] igc: " Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 20/23] tg3: " Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 21/23] r8152: " Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 22/23] net: usb: ax88179_178a: " Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-01 14:58 ` [Intel-wired-lan] [PATCH net-next v4 23/23] net: mdio: drop EEE ethtool helpers in favor " Oleksij Rempel
2023-02-01 14:58 ` Oleksij Rempel
2023-02-04 0:13 ` [Intel-wired-lan] [PATCH net-next v4 00/23] net: add EEE support for KSZ9477 and AR8035 with i.MX6 Vladimir Oltean
2023-02-04 0:13 ` Vladimir Oltean
2023-02-06 5:47 ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 5:47 ` Oleksij Rempel
2023-02-06 14:10 ` [Intel-wired-lan] " Vladimir Oltean
2023-02-06 14:10 ` Vladimir Oltean
2023-02-06 15:39 ` [Intel-wired-lan] " Andrew Lunn
2023-02-06 15:39 ` Andrew Lunn
2023-02-06 18:37 ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 18:37 ` Oleksij Rempel
2023-02-06 20:21 ` Andrew Lunn [this message]
2023-02-06 20:21 ` Andrew Lunn
2023-02-06 18:25 ` [Intel-wired-lan] " Oleksij Rempel
2023-02-06 18:25 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+FhU+5KJrEYX2CU@lunn.ch \
--to=andrew@lunn.ch \
--cc=Arun.Ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=wei.fang@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.