All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pawel Chmielewski <pawel.chmielewski@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: netdev@vger.kernel.org, intel-wired-lan@osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH 1/1] ice: add support BIG TCP on IPv6
Date: Tue, 7 Feb 2023 17:26:34 +0100	[thread overview]
Message-ID: <Y+J7uhD5hamFiiSL@baltimore> (raw)
In-Reply-To: <6eed8aad-1520-5789-264e-b952b6ff4502@molgen.mpg.de>

On Mon, Feb 06, 2023 at 05:53:00PM +0100, Paul Menzel wrote:
> Dear Pawel,
> 
> 
> Thank you for your patch.
> 
> Am 06.02.23 um 16:59 schrieb Pawel Chmielewski:
> > This change enables sending BIG TCP packets on IPv6 in the ice driver using
> > generic ipv6_hopopt_jumbo_remove helper for stripping HBH header.
> > 
> > Tested:
> > netperf -t TCP_RR -H 2001:db8:0:f101::1  -- -r80000,80000 -O MIN_LATENCY,P90_LATENCY,P99_LATENCY,THROUGHPUT
> > 
> > Results varied from one setup to another, but in every case we got lower
> > latencies and increased transactions rate.
> 
> Please give some concrete examples nevertheless.
Of course. I'll send v2 with the results. Thank you.

> 
> 
> Kind regards,
> 
> Paul
> 
> 
> > Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
> > ---
> >   drivers/net/ethernet/intel/ice/ice.h      | 2 ++
> >   drivers/net/ethernet/intel/ice/ice_main.c | 2 ++
> >   drivers/net/ethernet/intel/ice/ice_txrx.c | 3 +++
> >   3 files changed, 7 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
> > index 3d26ff4122e0..c774fdd482cd 100644
> > --- a/drivers/net/ethernet/intel/ice/ice.h
> > +++ b/drivers/net/ethernet/intel/ice/ice.h
> > @@ -122,6 +122,8 @@
> >   #define ICE_MAX_MTU	(ICE_AQ_SET_MAC_FRAME_SIZE_MAX - ICE_ETH_PKT_HDR_PAD)
> > +#define ICE_MAX_TSO_SIZE 131072
> > +
> >   #define ICE_UP_TABLE_TRANSLATE(val, i) \
> >   		(((val) << ICE_AQ_VSI_UP_TABLE_UP##i##_S) & \
> >   		  ICE_AQ_VSI_UP_TABLE_UP##i##_M)
> > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> > index 22b8ad058286..8c74a48ad0d3 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_main.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> > @@ -3421,6 +3421,8 @@ static void ice_set_netdev_features(struct net_device *netdev)
> >   	 * be changed at runtime
> >   	 */
> >   	netdev->hw_features |= NETIF_F_RXFCS;
> > +
> > +	netif_set_tso_max_size(netdev, ICE_MAX_TSO_SIZE);
> >   }
> >   /**
> > diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c
> > index ccf09c957a1c..bef927afb766 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_txrx.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
> > @@ -2297,6 +2297,9 @@ ice_xmit_frame_ring(struct sk_buff *skb, struct ice_tx_ring *tx_ring)
> >   	ice_trace(xmit_frame_ring, tx_ring, skb);
> > +	if (unlikely(ipv6_hopopt_jumbo_remove(skb)))
> > +		goto out_drop;
> > +
> >   	count = ice_xmit_desc_count(skb);
> >   	if (ice_chk_linearize(skb, count)) {
> >   		if (__skb_linearize(skb))
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Pawel Chmielewski <pawel.chmielewski@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: <netdev@vger.kernel.org>, <intel-wired-lan@osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH 1/1] ice: add support BIG TCP on IPv6
Date: Tue, 7 Feb 2023 17:26:34 +0100	[thread overview]
Message-ID: <Y+J7uhD5hamFiiSL@baltimore> (raw)
In-Reply-To: <6eed8aad-1520-5789-264e-b952b6ff4502@molgen.mpg.de>

On Mon, Feb 06, 2023 at 05:53:00PM +0100, Paul Menzel wrote:
> Dear Pawel,
> 
> 
> Thank you for your patch.
> 
> Am 06.02.23 um 16:59 schrieb Pawel Chmielewski:
> > This change enables sending BIG TCP packets on IPv6 in the ice driver using
> > generic ipv6_hopopt_jumbo_remove helper for stripping HBH header.
> > 
> > Tested:
> > netperf -t TCP_RR -H 2001:db8:0:f101::1  -- -r80000,80000 -O MIN_LATENCY,P90_LATENCY,P99_LATENCY,THROUGHPUT
> > 
> > Results varied from one setup to another, but in every case we got lower
> > latencies and increased transactions rate.
> 
> Please give some concrete examples nevertheless.
Of course. I'll send v2 with the results. Thank you.

> 
> 
> Kind regards,
> 
> Paul
> 
> 
> > Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
> > ---
> >   drivers/net/ethernet/intel/ice/ice.h      | 2 ++
> >   drivers/net/ethernet/intel/ice/ice_main.c | 2 ++
> >   drivers/net/ethernet/intel/ice/ice_txrx.c | 3 +++
> >   3 files changed, 7 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
> > index 3d26ff4122e0..c774fdd482cd 100644
> > --- a/drivers/net/ethernet/intel/ice/ice.h
> > +++ b/drivers/net/ethernet/intel/ice/ice.h
> > @@ -122,6 +122,8 @@
> >   #define ICE_MAX_MTU	(ICE_AQ_SET_MAC_FRAME_SIZE_MAX - ICE_ETH_PKT_HDR_PAD)
> > +#define ICE_MAX_TSO_SIZE 131072
> > +
> >   #define ICE_UP_TABLE_TRANSLATE(val, i) \
> >   		(((val) << ICE_AQ_VSI_UP_TABLE_UP##i##_S) & \
> >   		  ICE_AQ_VSI_UP_TABLE_UP##i##_M)
> > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> > index 22b8ad058286..8c74a48ad0d3 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_main.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> > @@ -3421,6 +3421,8 @@ static void ice_set_netdev_features(struct net_device *netdev)
> >   	 * be changed at runtime
> >   	 */
> >   	netdev->hw_features |= NETIF_F_RXFCS;
> > +
> > +	netif_set_tso_max_size(netdev, ICE_MAX_TSO_SIZE);
> >   }
> >   /**
> > diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c
> > index ccf09c957a1c..bef927afb766 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_txrx.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
> > @@ -2297,6 +2297,9 @@ ice_xmit_frame_ring(struct sk_buff *skb, struct ice_tx_ring *tx_ring)
> >   	ice_trace(xmit_frame_ring, tx_ring, skb);
> > +	if (unlikely(ipv6_hopopt_jumbo_remove(skb)))
> > +		goto out_drop;
> > +
> >   	count = ice_xmit_desc_count(skb);
> >   	if (ice_chk_linearize(skb, count)) {
> >   		if (__skb_linearize(skb))

  reply	other threads:[~2023-02-07 16:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 15:59 [Intel-wired-lan] [PATCH 1/1] ice: add support BIG TCP on IPv6 Pawel Chmielewski
2023-02-06 15:59 ` Pawel Chmielewski
2023-02-06 16:53 ` [Intel-wired-lan] " Paul Menzel
2023-02-06 16:53   ` Paul Menzel
2023-02-07 16:26   ` Pawel Chmielewski [this message]
2023-02-07 16:26     ` Pawel Chmielewski
2023-02-13  8:49 ` G, GurucharanX
2023-02-13  8:49   ` G, GurucharanX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+J7uhD5hamFiiSL@baltimore \
    --to=pawel.chmielewski@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    --cc=netdev@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.