From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Takashi Iwai <tiwai@suse.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Geoff Levand <geoff@infradead.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
alsa-devel@alsa-project.org, kernel@pengutronix.de,
linux-tegra@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3] ALSA: core: Make snd_card_free() return void
Date: Wed, 8 Feb 2023 12:33:00 +0100 [thread overview]
Message-ID: <Y+OIbIEn4QSQCB7M@orome> (raw)
In-Reply-To: <20230207191907.467756-4-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
On Tue, Feb 07, 2023 at 08:19:07PM +0100, Uwe Kleine-König wrote:
> The function returns 0 unconditionally. Make it return void instead and
> simplify all callers accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> include/sound/core.h | 2 +-
> sound/core/init.c | 6 ++----
> sound/pci/hda/hda_tegra.c | 6 ++----
> sound/ppc/snd_ps3.c | 4 +---
> 4 files changed, 6 insertions(+), 12 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Geoff Levand <geoff@infradead.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
alsa-devel@alsa-project.org, kernel@pengutronix.de,
linux-tegra@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3] ALSA: core: Make snd_card_free() return void
Date: Wed, 8 Feb 2023 12:33:00 +0100 [thread overview]
Message-ID: <Y+OIbIEn4QSQCB7M@orome> (raw)
In-Reply-To: <20230207191907.467756-4-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
On Tue, Feb 07, 2023 at 08:19:07PM +0100, Uwe Kleine-König wrote:
> The function returns 0 unconditionally. Make it return void instead and
> simplify all callers accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> include/sound/core.h | 2 +-
> sound/core/init.c | 6 ++----
> sound/pci/hda/hda_tegra.c | 6 ++----
> sound/ppc/snd_ps3.c | 4 +---
> 4 files changed, 6 insertions(+), 12 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: alsa-devel@alsa-project.org, Geoff Levand <geoff@infradead.org>,
Takashi Iwai <tiwai@suse.com>,
Nicholas Piggin <npiggin@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
kernel@pengutronix.de, linux-tegra@vger.kernel.org,
Jaroslav Kysela <perex@perex.cz>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3] ALSA: core: Make snd_card_free() return void
Date: Wed, 8 Feb 2023 12:33:00 +0100 [thread overview]
Message-ID: <Y+OIbIEn4QSQCB7M@orome> (raw)
In-Reply-To: <20230207191907.467756-4-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
On Tue, Feb 07, 2023 at 08:19:07PM +0100, Uwe Kleine-König wrote:
> The function returns 0 unconditionally. Make it return void instead and
> simplify all callers accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> include/sound/core.h | 2 +-
> sound/core/init.c | 6 ++----
> sound/pci/hda/hda_tegra.c | 6 ++----
> sound/ppc/snd_ps3.c | 4 +---
> 4 files changed, 6 insertions(+), 12 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-02-08 11:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 19:19 [PATCH 0/3] ALSA: core: Make some functions return void Uwe Kleine-König
2023-02-07 19:19 ` Uwe Kleine-König
2023-02-07 19:19 ` [PATCH 1/3] ALSA: core: Make snd_card_disconnect() " Uwe Kleine-König
2023-02-07 19:19 ` [PATCH 2/3] ALSA: core: Make snd_card_free_when_closed() " Uwe Kleine-König
2023-02-07 19:19 ` [PATCH 3/3] ALSA: core: Make snd_card_free() " Uwe Kleine-König
2023-02-07 19:19 ` Uwe Kleine-König
2023-02-08 2:10 ` Geoff Levand
2023-02-08 2:10 ` Geoff Levand
2023-02-08 11:33 ` Thierry Reding [this message]
2023-02-08 11:33 ` Thierry Reding
2023-02-08 11:33 ` Thierry Reding
2023-02-08 8:33 ` [PATCH 0/3] ALSA: core: Make some functions " Takashi Sakamoto
2023-02-08 8:33 ` Takashi Sakamoto
2023-02-08 8:33 ` Takashi Sakamoto
2023-02-08 9:25 ` Uwe Kleine-König
2023-02-08 8:39 ` Jaroslav Kysela
2023-02-08 8:39 ` Jaroslav Kysela
2023-02-08 12:41 ` Takashi Iwai
2023-02-08 12:41 ` Takashi Iwai
2023-02-08 12:41 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+OIbIEn4QSQCB7M@orome \
--to=thierry.reding@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=christophe.leroy@csgroup.eu \
--cc=geoff@infradead.org \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.