Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Maxim Mikityanskiy]

Hello,

I use HP Dragonfly G2, Arch linux, kernel 6.1.9, and I upgraded the
firmware from 1.9.1 to 1.11 (using fwupdmgr/LVFS), and this upgrade
broke tablet mode detection on my laptop. I did some debugging, and
that's what I found:

1. On both firmware versions: hp-wmi registers SW_TABLET_MODE, but never
reports events. Although HPWMI_EVENT_GUID is present on my system,
hp_wmi_notify never gets any events of any kind. Good thing is that at
least hp_wmi_get_tablet_mode (/sys/devices/platform/hp-wmi/tablet) works
on my laptop.

2. "Intel HID switches" is the device that reports actual SW_TABLET_MODE
events on firmware 1.9.1, but not anymore on firmware 1.11.
SW_TABLET_MODE is registered after the first event (by auto_add_switch,
on firmware 1.9.1 only).

3. SW_TABLET_MODE reported by "Intel HID switches" (on firmware 1.9.1)
differs from /sys/devices/platform/hp-wmi/tablet, when the laptop is not
fully folded, but put into a stand position (the hinge is open more than
180°, the keyboard faces the table). The reason is because hp-wmi only
treats system_device_mode[0] == 6 as tablet, but 5 (stand mode) isn't
included, while "Intel HID switches" report SW_TABLET_MODE = 1 in the
stand mode.

I'm pretty sure about my findings, I flashed each of these two firmware
versions again and tested what happens in hp-wmi and intel/hid, of
course without changing any software versions.

Regarding point 3, I can send a patch for hp-wmi, but it's not going to
be useful for my laptop because of point 1, and I can't be fully sure it
doesn't break other HP laptops (unless Jorge confirms?).

Now back to the main topic. There are two directions that I see:

1. Fix the regression in the firmware and make Intel HID switches work
again. Unfortunately, I didn't have success reporting the firmware bug
via HP customer support, and they don't seem to admit the bug or even
having uploaded their firmware to LVFS. If Jorge (or anyone else on the
mailing list) could give me some contact of a person responsible for
firmware on LVFS or the proper way to file a bug report, I would highly
appreciate it. Maybe Alex has an idea why intel/hid could stop working?

2. Somehow tweak hp-wmi to start getting events on my laptop and switch
to SW_TABLET_MODE reports from hp-wmi (also fixing the stand mode
reports). For this, I would need help from Jorge (or someone who knows
HP laptop internals), I don't have ideas why it might be broken for me.

I will appreciate any help, and I'm happy to provide additional
information if needed.

Thanks,
Max

RE: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Lopez, Jorge A (Security)]

Hi Maxim,

Thank you for the detailed debugging and information.  

The BIOS upgrade should have not affected the tablet mode behaviour.  Unfortunately, HP does not have an official process to support HP Dragonfly G2 under Linux that I am aware of with exception of a few HP team members.  Nonetheless, this is unacceptable, and I will forward the information to the BIOS team for them to investigate.
Personally, I work in a different team so I will try to get a patch out depending on BIOS team response.  



Regards,

Jorge Lopez
Hewlett-Packard 

"Once you stop learning, you start dying"
Albert Einstein

> -----Original Message-----
> From: Maxim Mikityanskiy <maxtram95@gmail.com>
> Sent: Tuesday, February 7, 2023 8:07 AM
> To: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>; Alex Hung
> <alexhung@gmail.com>; Hans de Goede <hdegoede@redhat.com>; Mark
> Gross <markgross@kernel.org>; platform-driver-x86@vger.kernel.org
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>; Mario Limonciello
> <mario.limonciello@amd.com>; Barnabás Pőcze <pobrn@protonmail.com>;
> Rishit Bansal <rishitbansal0@gmail.com>; Enver Balalic
> <balalic.enver@gmail.com>
> Subject: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2
> 
> CAUTION: External Email
> 
> Hello,
> 
> I use HP Dragonfly G2, Arch linux, kernel 6.1.9, and I upgraded the firmware
> from 1.9.1 to 1.11 (using fwupdmgr/LVFS), and this upgrade broke tablet
> mode detection on my laptop. I did some debugging, and that's what I
> found:
> 
> 1. On both firmware versions: hp-wmi registers SW_TABLET_MODE, but
> never reports events. Although HPWMI_EVENT_GUID is present on my
> system, hp_wmi_notify never gets any events of any kind. Good thing is that
> at least hp_wmi_get_tablet_mode (/sys/devices/platform/hp-wmi/tablet)
> works on my laptop.
> 
> 2. "Intel HID switches" is the device that reports actual SW_TABLET_MODE
> events on firmware 1.9.1, but not anymore on firmware 1.11.
> SW_TABLET_MODE is registered after the first event (by auto_add_switch,
> on firmware 1.9.1 only).
> 
> 3. SW_TABLET_MODE reported by "Intel HID switches" (on firmware 1.9.1)
> differs from /sys/devices/platform/hp-wmi/tablet, when the laptop is not
> fully folded, but put into a stand position (the hinge is open more than
> 180°, the keyboard faces the table). The reason is because hp-wmi only
> treats system_device_mode[0] == 6 as tablet, but 5 (stand mode) isn't
> included, while "Intel HID switches" report SW_TABLET_MODE = 1 in the
> stand mode.
> 
> I'm pretty sure about my findings, I flashed each of these two firmware
> versions again and tested what happens in hp-wmi and intel/hid, of course
> without changing any software versions.
> 
> Regarding point 3, I can send a patch for hp-wmi, but it's not going to be
> useful for my laptop because of point 1, and I can't be fully sure it doesn't
> break other HP laptops (unless Jorge confirms?).
> 
> Now back to the main topic. There are two directions that I see:
> 
> 1. Fix the regression in the firmware and make Intel HID switches work
> again. Unfortunately, I didn't have success reporting the firmware bug via
> HP customer support, and they don't seem to admit the bug or even having
> uploaded their firmware to LVFS. If Jorge (or anyone else on the mailing list)
> could give me some contact of a person responsible for firmware on LVFS or
> the proper way to file a bug report, I would highly appreciate it. Maybe Alex
> has an idea why intel/hid could stop working?
> 
> 2. Somehow tweak hp-wmi to start getting events on my laptop and switch
> to SW_TABLET_MODE reports from hp-wmi (also fixing the stand mode
> reports). For this, I would need help from Jorge (or someone who knows HP
> laptop internals), I don't have ideas why it might be broken for me.
> 
> I will appreciate any help, and I'm happy to provide additional information
> if needed.
> 
> Thanks,
> Max

Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Maxim Mikityanskiy]

On Tue, Feb 07, 2023 at 04:14:18PM +0000, Lopez, Jorge A (Security) wrote:
> Hi Maxim,
> 
> Thank you for the detailed debugging and information.  
> 
> The BIOS upgrade should have not affected the tablet mode behaviour.  Unfortunately, HP does not have an official process to support HP Dragonfly G2 under Linux that I am aware of with exception of a few HP team members.  Nonetheless, this is unacceptable, and I will forward the information to the BIOS team for them to investigate.
> Personally, I work in a different team so I will try to get a patch out depending on BIOS team response.  

Thanks a lot Jorge, you are really helpful! Let's see what the BIOS team
says then, please keep me updated.

> 
> 
> 
> Regards,
> 
> Jorge Lopez
> Hewlett-Packard 
> 
> "Once you stop learning, you start dying"
> Albert Einstein
> 
> > -----Original Message-----
> > From: Maxim Mikityanskiy <maxtram95@gmail.com>
> > Sent: Tuesday, February 7, 2023 8:07 AM
> > To: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>; Alex Hung
> > <alexhung@gmail.com>; Hans de Goede <hdegoede@redhat.com>; Mark
> > Gross <markgross@kernel.org>; platform-driver-x86@vger.kernel.org
> > Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>; Mario Limonciello
> > <mario.limonciello@amd.com>; Barnabás Pőcze <pobrn@protonmail.com>;
> > Rishit Bansal <rishitbansal0@gmail.com>; Enver Balalic
> > <balalic.enver@gmail.com>
> > Subject: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2
> > 
> > CAUTION: External Email
> > 
> > Hello,
> > 
> > I use HP Dragonfly G2, Arch linux, kernel 6.1.9, and I upgraded the firmware
> > from 1.9.1 to 1.11 (using fwupdmgr/LVFS), and this upgrade broke tablet
> > mode detection on my laptop. I did some debugging, and that's what I
> > found:
> > 
> > 1. On both firmware versions: hp-wmi registers SW_TABLET_MODE, but
> > never reports events. Although HPWMI_EVENT_GUID is present on my
> > system, hp_wmi_notify never gets any events of any kind. Good thing is that
> > at least hp_wmi_get_tablet_mode (/sys/devices/platform/hp-wmi/tablet)
> > works on my laptop.
> > 
> > 2. "Intel HID switches" is the device that reports actual SW_TABLET_MODE
> > events on firmware 1.9.1, but not anymore on firmware 1.11.
> > SW_TABLET_MODE is registered after the first event (by auto_add_switch,
> > on firmware 1.9.1 only).
> > 
> > 3. SW_TABLET_MODE reported by "Intel HID switches" (on firmware 1.9.1)
> > differs from /sys/devices/platform/hp-wmi/tablet, when the laptop is not
> > fully folded, but put into a stand position (the hinge is open more than
> > 180°, the keyboard faces the table). The reason is because hp-wmi only
> > treats system_device_mode[0] == 6 as tablet, but 5 (stand mode) isn't
> > included, while "Intel HID switches" report SW_TABLET_MODE = 1 in the
> > stand mode.
> > 
> > I'm pretty sure about my findings, I flashed each of these two firmware
> > versions again and tested what happens in hp-wmi and intel/hid, of course
> > without changing any software versions.
> > 
> > Regarding point 3, I can send a patch for hp-wmi, but it's not going to be
> > useful for my laptop because of point 1, and I can't be fully sure it doesn't
> > break other HP laptops (unless Jorge confirms?).
> > 
> > Now back to the main topic. There are two directions that I see:
> > 
> > 1. Fix the regression in the firmware and make Intel HID switches work
> > again. Unfortunately, I didn't have success reporting the firmware bug via
> > HP customer support, and they don't seem to admit the bug or even having
> > uploaded their firmware to LVFS. If Jorge (or anyone else on the mailing list)
> > could give me some contact of a person responsible for firmware on LVFS or
> > the proper way to file a bug report, I would highly appreciate it. Maybe Alex
> > has an idea why intel/hid could stop working?
> > 
> > 2. Somehow tweak hp-wmi to start getting events on my laptop and switch
> > to SW_TABLET_MODE reports from hp-wmi (also fixing the stand mode
> > reports). For this, I would need help from Jorge (or someone who knows HP
> > laptop internals), I don't have ideas why it might be broken for me.
> > 
> > I will appreciate any help, and I'm happy to provide additional information
> > if needed.
> > 
> > Thanks,
> > Max
> 

Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Richard Hughes]

On Tue, 7 Feb 2023 at 14:18, Maxim Mikityanskiy <maxtram95@gmail.com> wrote:
> If Jorge (or anyone else on the
> mailing list) could give me some contact of a person responsible for
> firmware on LVFS or the proper way to file a bug report, I would highly
> appreciate it.

You can open an issue here:
https://github.com/fwupd/missing-firmware-hp/issues -- but for this
kind of thing I'm happy to demote builds out of the stable remote
myself as firmware updates should *never* intentionally break things.
Jorge, have you contacted the correct people or do you want me to
demote the firmware for you?

Richard

Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Richard Hughes]

On Wed, 8 Feb 2023 at 19:27, Lopez, Jorge A (Security)
<jorge.lopez2@hp.com> wrote:
> Please do ahead and demote the firmware for me.

Okay, now I'm double confused; the only HP Elite Dragonfly G2 firmware
on the LVFS has never been in any stable branch. Maxim -- are you sure
you got the firmware from the LVFS (and not automatically through
Windows Update) and if so can you please send me the output of
"fwupdmgr get-devices" off-list please.

Richard.

Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Maxim Mikityanskiy]

On Wed, Feb 08, 2023 at 08:09:16PM +0000, Richard Hughes wrote:
> On Wed, 8 Feb 2023 at 19:27, Lopez, Jorge A (Security)
> <jorge.lopez2@hp.com> wrote:
> > Please do ahead and demote the firmware for me.
> 
> Okay, now I'm double confused; the only HP Elite Dragonfly G2 firmware
> on the LVFS has never been in any stable branch.

This is the firmware on LVFS, it's marked as stable:

https://fwupd.org/lvfs/devices/com.hp.laptop.system.T90.firmware

dmidecode says:

Handle 0x0001, DMI type 0, 26 bytes
BIOS Information
	Vendor: HP
	Version: T90 Ver. 01.09.01
	Release Date: 05/05/2022

> Maxim -- are you sure
> you got the firmware from the LVFS (and not automatically through
> Windows Update)

Yes, I'm pretty sure, I don't have any Windows, and I used fwupdmgr to
upgrade (and then downgrade).

> and if so can you please send me the output of
> "fwupdmgr get-devices" off-list please.

Sure, will send in a few minutes.

> 
> Richard.

Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Richard Hughes]

On Wed, 8 Feb 2023 at 21:43, Maxim Mikityanskiy <maxtram95@gmail.com> wrote:
> > Okay, now I'm double confused; the only HP Elite Dragonfly G2 firmware
> > on the LVFS has never been in any stable branch.

Ahh, I didn't expect T90 as the firmware name; found it.

I emailed the BIOS team some time ago and asked them for a response
but got nothing back. Sorry this happened to you -- vendors are under
strict instructions never to break things like this for a security
update.

Jorge, can you communicate this more clearly internally please and let
me know what to do about the LVFS updates please.

Richard

RE: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Lopez, Jorge A (Security)]

Hi Richard,

I am sorry no response has been given to Maxim's enquiry.   Let me approach the BIOS team and see what I can do from my end.


Regards,

Jorge Lopez
HP Inc

“Once you stop learning, you start dying”
Albert Einstein

> -----Original Message-----
> From: Richard Hughes <hughsient@gmail.com>
> Sent: Monday, April 24, 2023 5:37 AM
> To: Maxim Mikityanskiy <maxtram95@gmail.com>
> Cc: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>; Alex Hung
> <alexhung@gmail.com>; Hans de Goede <hdegoede@redhat.com>; Mark
> Gross <markgross@kernel.org>; platform-driver-x86@vger.kernel.org; Kai-
> Heng Feng <kai.heng.feng@canonical.com>; Mario Limonciello
> <mario.limonciello@amd.com>; Barnabás Pőcze <pobrn@protonmail.com>;
> Rishit Bansal <rishitbansal0@gmail.com>; Enver Balalic
> <balalic.enver@gmail.com>
> Subject: Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2
> 
> CAUTION: External Email
> 
> On Wed, 8 Feb 2023 at 21:43, Maxim Mikityanskiy <maxtram95@gmail.com>
> wrote:
> > > Okay, now I'm double confused; the only HP Elite Dragonfly G2
> > > firmware on the LVFS has never been in any stable branch.
> 
> Ahh, I didn't expect T90 as the firmware name; found it.
> 
> I emailed the BIOS team some time ago and asked them for a response but
> got nothing back. Sorry this happened to you -- vendors are under strict
> instructions never to break things like this for a security update.
> 
> Jorge, can you communicate this more clearly internally please and let me
> know what to do about the LVFS updates please.
> 
> Richard

RE: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Lopez, Jorge A (Security)]

[-- Attachment #1: Type: text/plain, Size: 3155 bytes --]

Hi Richard,

I reached out to BIOS team and here is their response.  Let me know if additional information is needed.


>> HP Elite Dragonfly Max/Dragonfly G2 Notebook PC T90 System Update is in 'Embargo State', so it is not officially released.
>> Customer should wait until the version below is finalized and moved to Stable state.

>> HP Elite Dragonfly Max/Dragonfly G2 Notebook PC T90 System Update

>> BTW, the name on LVFS will be changed per customer request in CQ2 refresh.  Customers want to have product names included in the name.  The last columns in tables are the name to be displayed on LVFS from CQ2 refresh.  See attached JPEG for upcoming LVFS name changes in CQ2 refresh.


Regards,

Jorge Lopez
HP Inc

“Once you stop learning, you start dying”
Albert Einstein

> -----Original Message-----
> From: Lopez, Jorge A (Security)
> Sent: Monday, April 24, 2023 9:18 AM
> To: Richard Hughes <hughsient@gmail.com>; Maxim Mikityanskiy
> <maxtram95@gmail.com>
> Cc: Alex Hung <alexhung@gmail.com>; Hans de Goede
> <hdegoede@redhat.com>; Mark Gross <markgross@kernel.org>; platform-
> driver-x86@vger.kernel.org; Kai-Heng Feng <kai.heng.feng@canonical.com>;
> Mario Limonciello <mario.limonciello@amd.com>; Barnabás Pőcze
> <pobrn@protonmail.com>; Rishit Bansal <rishitbansal0@gmail.com>; Enver
> Balalic <balalic.enver@gmail.com>
> Subject: RE: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2
> 
> Hi Richard,
> 
> I am sorry no response has been given to Maxim's enquiry.   Let me
> approach the BIOS team and see what I can do from my end.
> 
> 
> Regards,
> 
> Jorge Lopez
> HP Inc
> 
> “Once you stop learning, you start dying”
> Albert Einstein
> 
> > -----Original Message-----
> > From: Richard Hughes <hughsient@gmail.com>
> > Sent: Monday, April 24, 2023 5:37 AM
> > To: Maxim Mikityanskiy <maxtram95@gmail.com>
> > Cc: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>; Alex Hung
> > <alexhung@gmail.com>; Hans de Goede <hdegoede@redhat.com>; Mark
> Gross
> > <markgross@kernel.org>; platform-driver-x86@vger.kernel.org; Kai- Heng
> > Feng <kai.heng.feng@canonical.com>; Mario Limonciello
> > <mario.limonciello@amd.com>; Barnabás Pőcze
> <pobrn@protonmail.com>;
> > Rishit Bansal <rishitbansal0@gmail.com>; Enver Balalic
> > <balalic.enver@gmail.com>
> > Subject: Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly
> G2
> >
> > CAUTION: External Email
> >
> > On Wed, 8 Feb 2023 at 21:43, Maxim Mikityanskiy
> <maxtram95@gmail.com>
> > wrote:
> > > > Okay, now I'm double confused; the only HP Elite Dragonfly G2
> > > > firmware on the LVFS has never been in any stable branch.
> >
> > Ahh, I didn't expect T90 as the firmware name; found it.
> >
> > I emailed the BIOS team some time ago and asked them for a response
> > but got nothing back. Sorry this happened to you -- vendors are under
> > strict instructions never to break things like this for a security update.
> >
> > Jorge, can you communicate this more clearly internally please and let
> > me know what to do about the LVFS updates please.
> >
> > Richard


[-- Attachment #2: LVFS-name-changes-for-CQ2.jpg --]
[-- Type: image/jpeg, Size: 358155 bytes --]

Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Maxim Mikityanskiy]

On Tue, 25 Apr 2023 at 18:05, Lopez, Jorge A (Security)
<jorge.lopez2@hp.com> wrote:
>
> Hi Richard,
>
> I reached out to BIOS team and here is their response.  Let me know if additional information is needed.

Hi Jorge!

Thanks a lot for getting a response from the BIOS team.

> >> HP Elite Dragonfly Max/Dragonfly G2 Notebook PC T90 System Update is in 'Embargo State', so it is not officially released.
> >> Customer should wait until the version below is finalized and moved to Stable state.

This clearly doesn't match what I see on LVFS:

https://fwupd.org/lvfs/devices/com.hp.laptop.system.T90.firmware

01.11.00 and 01.12.00 are both marked as stable here, and fwupd
suggests these versions for an upgrade. What do they mean when they
say it's not officially released and not in the stable state?

> >> HP Elite Dragonfly Max/Dragonfly G2 Notebook PC T90 System Update
>
> >> BTW, the name on LVFS will be changed per customer request in CQ2 refresh.  Customers want to have product names included in the name.  The last columns in tables are the name to be displayed on LVFS from CQ2 refresh.  See attached JPEG for upcoming LVFS name changes in CQ2 refresh.

That's a great change, having the laptop name explicitly will be much clearer.

>
>
> Regards,
>
> Jorge Lopez
> HP Inc
>
> “Once you stop learning, you start dying”
> Albert Einstein
>
> > -----Original Message-----
> > From: Lopez, Jorge A (Security)
> > Sent: Monday, April 24, 2023 9:18 AM
> > To: Richard Hughes <hughsient@gmail.com>; Maxim Mikityanskiy
> > <maxtram95@gmail.com>
> > Cc: Alex Hung <alexhung@gmail.com>; Hans de Goede
> > <hdegoede@redhat.com>; Mark Gross <markgross@kernel.org>; platform-
> > driver-x86@vger.kernel.org; Kai-Heng Feng <kai.heng.feng@canonical.com>;
> > Mario Limonciello <mario.limonciello@amd.com>; Barnabás Pőcze
> > <pobrn@protonmail.com>; Rishit Bansal <rishitbansal0@gmail.com>; Enver
> > Balalic <balalic.enver@gmail.com>
> > Subject: RE: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2
> >
> > Hi Richard,
> >
> > I am sorry no response has been given to Maxim's enquiry.   Let me
> > approach the BIOS team and see what I can do from my end.
> >
> >
> > Regards,
> >
> > Jorge Lopez
> > HP Inc
> >
> > “Once you stop learning, you start dying”
> > Albert Einstein
> >
> > > -----Original Message-----
> > > From: Richard Hughes <hughsient@gmail.com>
> > > Sent: Monday, April 24, 2023 5:37 AM
> > > To: Maxim Mikityanskiy <maxtram95@gmail.com>
> > > Cc: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>; Alex Hung
> > > <alexhung@gmail.com>; Hans de Goede <hdegoede@redhat.com>; Mark
> > Gross
> > > <markgross@kernel.org>; platform-driver-x86@vger.kernel.org; Kai- Heng
> > > Feng <kai.heng.feng@canonical.com>; Mario Limonciello
> > > <mario.limonciello@amd.com>; Barnabás Pőcze
> > <pobrn@protonmail.com>;
> > > Rishit Bansal <rishitbansal0@gmail.com>; Enver Balalic
> > > <balalic.enver@gmail.com>
> > > Subject: Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly
> > G2
> > >
> > > CAUTION: External Email
> > >
> > > On Wed, 8 Feb 2023 at 21:43, Maxim Mikityanskiy
> > <maxtram95@gmail.com>
> > > wrote:
> > > > > Okay, now I'm double confused; the only HP Elite Dragonfly G2
> > > > > firmware on the LVFS has never been in any stable branch.
> > >
> > > Ahh, I didn't expect T90 as the firmware name; found it.
> > >
> > > I emailed the BIOS team some time ago and asked them for a response
> > > but got nothing back. Sorry this happened to you -- vendors are under
> > > strict instructions never to break things like this for a security update.
> > >
> > > Jorge, can you communicate this more clearly internally please and let
> > > me know what to do about the LVFS updates please.
> > >
> > > Richard
>

RE: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Lopez, Jorge A (Security)]

Hi Maxim,


From: Maxim Mikityanskiy <maxtram95@gmail.com> 
Sent: Thursday, April 27, 2023 11:37 AM
To: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>
Cc: Richard Hughes <hughsient@gmail.com>; Alex Hung <alexhung@gmail.com>; Hans de Goede <hdegoede@redhat.com>; Mark Gross <markgross@kernel.org>; platform-driver-x86@vger.kernel.org; Kai-Heng Feng <kai.heng.feng@canonical.com>; Mario Limonciello <mario.limonciello@amd.com>; Barnabás Pőcze <pobrn@protonmail.com>; Rishit Bansal <rishitbansal0@gmail.com>; Enver Balalic <balalic.enver@gmail.com>
Subject: Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

CAUTION: External Email 
On Tue, 25 Apr 2023 at 18:05, Lopez, Jorge A (Security)
<mailto:jorge.lopez2@hp.com> wrote:
> >
> > Hi Richard,
> >
> > I reached out to BIOS team and here is their response. Let me know if additional information is needed.

> > Hi Jorge!

> Thanks a lot for getting a response from the BIOS team.

You are welcome.  Sorry it took so long to get a response.

> > >> HP Elite Dragonfly Max/Dragonfly G2 Notebook PC T90 System Update is in 'Embargo State', so it is not officially released.
> > >> Customer should wait until the version below is finalized and moved to Stable state.

> This clearly doesn't match what I see on LVFS:

> https://fwupd.org/lvfs/devices/com.hp.laptop.system.T90.firmware

> 01.11.00 and 01.12.00 are both marked as stable here, and fwupd
> suggests these versions for an upgrade. What do they mean when they
> say it's not officially released and not in the stable state?

The firmware which state is stable is under a generic name 'HP Commercial Laptop T90 Family System Update'.   This BIOS is not specific to your system.   This is the reason why the name convention is changing and eliminate confusion.

The BIOS specific to your notebook is found under ' HP Elite Dragonfly Max/Dragonfly G2 Notebook PC T90 System Update' which status is 'embargo-hp-ws'.  BIOS in 'embargo' state are not declared as stable or released.   The LVFS documentation describes the firmware state flow as Private -> Embargo -> Testing -> Stable


> > >> HP Elite Dragonfly Max/Dragonfly G2 Notebook PC T90 System Update
> >
> > >> BTW, the name on LVFS will be changed per customer request in CQ2 refresh. Customers want to have product names included in the name. The last columns in tables are the name to be displayed on LVFS from CQ2 refresh. See attached JPEG for upcoming LVFS name changes in CQ2 refresh.

> That's a great change, having the laptop name explicitly will be much clearer.

Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2

[Maxim Mikityanskiy]

On Thu, 27 Apr 2023 at 22:26, Lopez, Jorge A (Security)
<jorge.lopez2@hp.com> wrote:
>
> Hi Maxim,
>
>
> From: Maxim Mikityanskiy <maxtram95@gmail.com>
> Sent: Thursday, April 27, 2023 11:37 AM
> To: Lopez, Jorge A (Security) <jorge.lopez2@hp.com>
> Cc: Richard Hughes <hughsient@gmail.com>; Alex Hung <alexhung@gmail.com>; Hans de Goede <hdegoede@redhat.com>; Mark Gross <markgross@kernel.org>; platform-driver-x86@vger.kernel.org; Kai-Heng Feng <kai.heng.feng@canonical.com>; Mario Limonciello <mario.limonciello@amd.com>; Barnabás Pőcze <pobrn@protonmail.com>; Rishit Bansal <rishitbansal0@gmail.com>; Enver Balalic <balalic.enver@gmail.com>
> Subject: Re: Firmware upgrade broke SW_TABLET_MODE on HP Dragonfly G2
>
> CAUTION: External Email
> On Tue, 25 Apr 2023 at 18:05, Lopez, Jorge A (Security)
> <mailto:jorge.lopez2@hp.com> wrote:
> > >
> > > Hi Richard,
> > >
> > > I reached out to BIOS team and here is their response. Let me know if additional information is needed.
>
> > > Hi Jorge!
>
> > Thanks a lot for getting a response from the BIOS team.
>
> You are welcome.  Sorry it took so long to get a response.
>
> > > >> HP Elite Dragonfly Max/Dragonfly G2 Notebook PC T90 System Update is in 'Embargo State', so it is not officially released.
> > > >> Customer should wait until the version below is finalized and moved to Stable state.
>
> > This clearly doesn't match what I see on LVFS:
>
> > https://fwupd.org/lvfs/devices/com.hp.laptop.system.T90.firmware
>
> > 01.11.00 and 01.12.00 are both marked as stable here, and fwupd
> > suggests these versions for an upgrade. What do they mean when they
> > say it's not officially released and not in the stable state?
>
> The firmware which state is stable is under a generic name 'HP Commercial Laptop T90 Family System Update'.   This BIOS is not specific to your system.   This is the reason why the name convention is changing and eliminate confusion.
>
> The BIOS specific to your notebook is found under ' HP Elite Dragonfly Max/Dragonfly G2 Notebook PC T90 System Update' which status is 'embargo-hp-ws'.  BIOS in 'embargo' state are not declared as stable or released.   The LVFS documentation describes the firmware state flow as Private -> Embargo -> Testing -> Stable

Thanks for the explanation of the renaming process!

There seems to be a miscommunication between me and the firmware team,
though. Sure, if they are planning a rename, and if the next version
will be released under a new name, I'll test it. In the meanwhile,
they are releasing updates under the old name, the last two have a
regression, and the versions on LVFS under the old name match the
firmware upgrade packages for Windows (which makes me think there is
only one firmware branch, and renaming is not a complete replacement
with a whole different firmware — please correct me if I'm wrong):

https://support.hp.com/ph-en/drivers/selfservice/hp-elite-dragonfly-g2-notebook-pc/34514046

I'm running the firmware which is officially released (under the old
name), marked as stable, and even had an upgrade to 01.12.00 after I
reported the bug on 01.11.00. Why do they say I need to wait for the
rename to happen first? Or do they mean that the next version fixes my
bug, and it will be released under the new name?

I'm just concerned that due to some miscommunication the firmware team
doesn't treat me seriously, because they think I'm running some
unofficial firmware, while I'm running the only available at the
moment official and stable firmware, whose versions also match Windows
upgrade packages. I'm afraid to waste time, which might make fixing
the bug harder, and also might make testing impossible, if a new
firmware version won't allow downgrade to 01.09.01.

Could you communicate that for me please? If they fixed the bug, and I
only need to wait for a new release, which will be under a new name,
I'll wait patiently. If they didn't even treat my request seriously
because they thought I'm on some beta or unofficial firmware, I'd like
to make things clear.

Thanks,
Max

>
>
> > > >> HP Elite Dragonfly Max/Dragonfly G2 Notebook PC T90 System Update
> > >
> > > >> BTW, the name on LVFS will be changed per customer request in CQ2 refresh. Customers want to have product names included in the name. The last columns in tables are the name to be displayed on LVFS from CQ2 refresh. See attached JPEG for upcoming LVFS name changes in CQ2 refresh.
>
> > That's a great change, having the laptop name explicitly will be much clearer.
>