All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrik Grimler <henrik@grimler.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	alim.akhtar@samsung.com, m.szyprowski@samsung.com,
	jenneron@protonmail.com, markuss.broks@gmail.com,
	martin.juecker@gmail.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 1/2] ARM: dts: exynos: drop mshc aliases
Date: Thu, 9 Feb 2023 15:56:53 +0100	[thread overview]
Message-ID: <Y+UJtZ2fpk+TSwqU@L14.lan> (raw)
In-Reply-To: <29d63a50-bdfe-ef50-c173-cb9e37923758@linaro.org>

Hi Krzysztof,

Thanks for reviewing!

On Thu, Feb 09, 2023 at 03:39:37PM +0100, Krzysztof Kozlowski wrote:
> On 28/01/2023 14:31, Henrik Grimler wrote:
> > They are no longer needed after commit a13e8ef6008d ("mmc: dw_mmc:
> > exynos: use common_caps").
> > 
> 
> Are you sure? That commit explicitly says that the caps should be set
> from DT and Exynos DT does not set it everywhere...
> 
> plus if alias is missing, then the ctrl_id in dw_mmc.c is 0 and such
> caps are applied everywhere - to every DWMMC device.

Yeah, you are right, David pointed this out in the ARM64 patchset [1]
as well, so I will look it over again and send new versions (when
discussion on this version is finalised).

> Best regards,
> Krzysztof

[1] https://patchwork.kernel.org/project/linux-samsung-soc/patch/20230203204000.14410-2-henrik@grimler.se/#25197132

Best regards,
Henrik Grimler

WARNING: multiple messages have this Message-ID (diff)
From: Henrik Grimler <henrik@grimler.se>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	alim.akhtar@samsung.com, m.szyprowski@samsung.com,
	jenneron@protonmail.com, markuss.broks@gmail.com,
	martin.juecker@gmail.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 1/2] ARM: dts: exynos: drop mshc aliases
Date: Thu, 9 Feb 2023 15:56:53 +0100	[thread overview]
Message-ID: <Y+UJtZ2fpk+TSwqU@L14.lan> (raw)
In-Reply-To: <29d63a50-bdfe-ef50-c173-cb9e37923758@linaro.org>

Hi Krzysztof,

Thanks for reviewing!

On Thu, Feb 09, 2023 at 03:39:37PM +0100, Krzysztof Kozlowski wrote:
> On 28/01/2023 14:31, Henrik Grimler wrote:
> > They are no longer needed after commit a13e8ef6008d ("mmc: dw_mmc:
> > exynos: use common_caps").
> > 
> 
> Are you sure? That commit explicitly says that the caps should be set
> from DT and Exynos DT does not set it everywhere...
> 
> plus if alias is missing, then the ctrl_id in dw_mmc.c is 0 and such
> caps are applied everywhere - to every DWMMC device.

Yeah, you are right, David pointed this out in the ARM64 patchset [1]
as well, so I will look it over again and send new versions (when
discussion on this version is finalised).

> Best regards,
> Krzysztof

[1] https://patchwork.kernel.org/project/linux-samsung-soc/patch/20230203204000.14410-2-henrik@grimler.se/#25197132

Best regards,
Henrik Grimler

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-02-09 14:57 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230128133213eucas1p274ea3393199fe711fba8f542197e1dea@eucas1p2.samsung.com>
2023-01-28 13:31 ` [PATCH v2 0/2] ARM: dts: add mmc aliases for Exynos devices Henrik Grimler
2023-01-28 13:31   ` Henrik Grimler
2023-01-28 13:31   ` [PATCH v2 1/2] ARM: dts: exynos: drop mshc aliases Henrik Grimler
2023-01-28 13:31     ` Henrik Grimler
2023-01-30 13:27     ` Marek Szyprowski
2023-01-30 13:27       ` Marek Szyprowski
2023-02-09 14:39     ` Krzysztof Kozlowski
2023-02-09 14:39       ` Krzysztof Kozlowski
2023-02-09 14:56       ` Henrik Grimler [this message]
2023-02-09 14:56         ` Henrik Grimler
2023-01-28 13:31   ` [PATCH v2 2/2] ARM: dts: exynos: add mmc aliases Henrik Grimler
2023-01-28 13:31     ` Henrik Grimler
2023-01-30 13:28     ` Marek Szyprowski
2023-01-30 13:28       ` Marek Szyprowski
2023-02-09 14:23     ` Krzysztof Kozlowski
2023-02-09 14:23       ` Krzysztof Kozlowski
2023-02-09 14:50       ` Marek Szyprowski
2023-02-09 14:50         ` Marek Szyprowski
2023-02-09 15:18         ` Krzysztof Kozlowski
2023-02-09 15:18           ` Krzysztof Kozlowski
2023-02-09 18:20           ` Henrik Grimler
2023-02-09 18:20             ` Henrik Grimler
2023-02-09 15:06     ` Rob Herring
2023-02-09 15:06       ` Rob Herring
2023-02-09 15:22       ` David Virag
2023-02-09 15:22         ` David Virag
2023-02-09 18:07         ` Henrik Grimler
2023-02-09 18:07           ` Henrik Grimler
2023-01-30 13:28   ` [PATCH v2 0/2] ARM: dts: add mmc aliases for Exynos devices Marek Szyprowski
2023-01-30 13:28     ` Marek Szyprowski
2023-01-30 19:59     ` Henrik Grimler
2023-01-30 19:59       ` Henrik Grimler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+UJtZ2fpk+TSwqU@L14.lan \
    --to=henrik@grimler.se \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jenneron@protonmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=markuss.broks@gmail.com \
    --cc=martin.juecker@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.