From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Clément Léger" <clement.leger@bootlin.com>
Cc: "Sergey Shtylyov" <s.shtylyov@omp.ru>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Wong Vee Khee" <veekhee@apple.com>,
"Kurt Kanzenbach" <kurt@linutronix.de>,
"Revanth Kumar Uppala" <ruppala@nvidia.com>,
"Tan Tee Min" <tee.min.tan@linux.intel.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Milan Stevanovic" <milan.stevanovic@se.com>,
"Jimmy Lalande" <jimmy.lalande@se.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
"Mohammad Athari Bin Ismail" <mohammad.athari.ismail@intel.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v3 5/6] net: stmmac: add support for RZ/N1 GMAC
Date: Fri, 10 Feb 2023 11:09:40 +0000 [thread overview]
Message-ID: <Y+Yl9AvJN5ClU3ZD@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230209151632.275883-6-clement.leger@bootlin.com>
On Thu, Feb 09, 2023 at 04:16:31PM +0100, Clément Léger wrote:
> +struct rzn1_dwmac {
> + struct phylink_pcs *pcs;
> +};
Please see my comments on your previous patch series as to why I don't
think you need this structure nor its associated memory allocations.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Clément Léger" <clement.leger@bootlin.com>
Cc: "Sergey Shtylyov" <s.shtylyov@omp.ru>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Wong Vee Khee" <veekhee@apple.com>,
"Kurt Kanzenbach" <kurt@linutronix.de>,
"Revanth Kumar Uppala" <ruppala@nvidia.com>,
"Tan Tee Min" <tee.min.tan@linux.intel.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Milan Stevanovic" <milan.stevanovic@se.com>,
"Jimmy Lalande" <jimmy.lalande@se.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
"Mohammad Athari Bin Ismail" <mohammad.athari.ismail@intel.com>,
"Jon Hunter" <jonathanh@nvidia.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v3 5/6] net: stmmac: add support for RZ/N1 GMAC
Date: Fri, 10 Feb 2023 11:09:40 +0000 [thread overview]
Message-ID: <Y+Yl9AvJN5ClU3ZD@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230209151632.275883-6-clement.leger@bootlin.com>
On Thu, Feb 09, 2023 at 04:16:31PM +0100, Clément Léger wrote:
> +struct rzn1_dwmac {
> + struct phylink_pcs *pcs;
> +};
Please see my comments on your previous patch series as to why I don't
think you need this structure nor its associated memory allocations.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-10 11:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 15:16 [PATCH net-next v3 0/6] net: stmmac: add renesas,rzn1-gmac support Clément Léger
2023-02-09 15:16 ` Clément Léger
2023-02-09 15:16 ` [PATCH net-next v3 1/6] net: pcs: rzn1-miic: add pcs_early_setup() function Clément Léger
2023-02-09 15:16 ` Clément Léger
2023-02-09 15:16 ` [PATCH net-next v3 2/6] net: stmmac: add support to use a generic phylink_pcs as PCS Clément Léger
2023-02-09 15:16 ` Clément Léger
2023-02-09 15:16 ` [PATCH net-next v3 3/6] net: stmmac: add support to provide pcs from platform data Clément Léger
2023-02-09 15:16 ` Clément Léger
2023-02-09 15:16 ` [PATCH net-next v3 4/6] dt-bindings: net: renesas,rzn1-gmac: Document RZ/N1 GMAC support Clément Léger
2023-02-09 15:16 ` Clément Léger
2023-02-10 12:01 ` Krzysztof Kozlowski
2023-02-10 12:01 ` Krzysztof Kozlowski
2023-02-10 12:29 ` Clément Léger
2023-02-10 12:29 ` Clément Léger
2023-02-09 15:16 ` [PATCH net-next v3 5/6] net: stmmac: add support for RZ/N1 GMAC Clément Léger
2023-02-09 15:16 ` Clément Léger
2023-02-10 11:09 ` Russell King (Oracle) [this message]
2023-02-10 11:09 ` Russell King (Oracle)
2023-02-21 14:45 ` Geert Uytterhoeven
2023-02-21 14:45 ` Geert Uytterhoeven
2023-02-09 15:16 ` [PATCH net-next v3 6/6] ARM: dts: r9a06g032: describe GMAC1 Clément Léger
2023-02-09 15:16 ` Clément Léger
2023-02-14 13:17 ` Geert Uytterhoeven
2023-02-14 13:17 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+Yl9AvJN5ClU3ZD@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=herve.codina@bootlin.com \
--cc=jimmy.lalande@se.com \
--cc=joabreu@synopsys.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=magnus.damm@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=mohammad.athari.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=ruppala@nvidia.com \
--cc=s.shtylyov@omp.ru \
--cc=tee.min.tan@linux.intel.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=veekhee@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.