From: Andrew Lunn <andrew@lunn.ch>
To: Deepak R Varma <drv@mailo.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] soc: dove: release node before breaking child_of_node loop
Date: Sat, 11 Feb 2023 18:51:18 +0100 [thread overview]
Message-ID: <Y+fVlugBi3z9F97a@lunn.ch> (raw)
In-Reply-To: <Y+e+90hi6KwoB/xh@ubun2204.myguest.virtualbox.org>
On Sat, Feb 11, 2023 at 09:44:47PM +0530, Deepak R Varma wrote:
> The iterator for_each_available_child_of_node() increments the refcount
> of the child node it is processing. Release such a reference when the
> loop needs to break due to an error during its execution.
> Issue identified using for_each_child.cocci Coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
Looks reasonable.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Deepak R Varma <drv@mailo.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] soc: dove: release node before breaking child_of_node loop
Date: Sat, 11 Feb 2023 18:51:18 +0100 [thread overview]
Message-ID: <Y+fVlugBi3z9F97a@lunn.ch> (raw)
In-Reply-To: <Y+e+90hi6KwoB/xh@ubun2204.myguest.virtualbox.org>
On Sat, Feb 11, 2023 at 09:44:47PM +0530, Deepak R Varma wrote:
> The iterator for_each_available_child_of_node() increments the refcount
> of the child node it is processing. Release such a reference when the
> loop needs to break due to an error during its execution.
> Issue identified using for_each_child.cocci Coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
Looks reasonable.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2023-02-11 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 16:14 [PATCH] soc: dove: release node before breaking child_of_node loop Deepak R Varma
2023-02-11 16:14 ` Deepak R Varma
2023-02-11 17:51 ` Andrew Lunn [this message]
2023-02-11 17:51 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+fVlugBi3z9F97a@lunn.ch \
--to=andrew@lunn.ch \
--cc=drv@mailo.com \
--cc=gregory.clement@bootlin.com \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.