All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
	bpf@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	ast@kernel.org, andrii@kernel.org, horatiu.vultur@microchip.com,
	UNGLinuxDriver@microchip.com
Subject: Re: [PATCH bpf-next] net: lan966x: set xdp_features flag
Date: Mon, 13 Feb 2023 19:46:39 +0100	[thread overview]
Message-ID: <Y+qFj2YIE4OAWcld@lore-desk> (raw)
In-Reply-To: <cfcc4936-086c-62f6-142f-1db1c42fb9d3@iogearbox.net>

[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]

> On 2/12/23 10:07 AM, Lorenzo Bianconi wrote:
> > > Set xdp_features netdevice flag if lan966x nic supports xdp mode.
> > > 
> > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > > ---
> > >   drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 5 +++++
> > >   1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> > > index 580c91d24a52..b24e55e61dc5 100644
> > > --- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> > > +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> > > @@ -823,6 +823,11 @@ static int lan966x_probe_port(struct lan966x *lan966x, u32 p,
> > >   	port->phylink = phylink;
> > > +	if (lan966x->fdma)
> > > +		dev->xdp_features = NETDEV_XDP_ACT_BASIC |
> > > +				    NETDEV_XDP_ACT_REDIRECT |
> > > +				    NETDEV_XDP_ACT_NDO_XMIT;
> > > +
> > >   	err = register_netdev(dev);
> > >   	if (err) {
> > >   		dev_err(lan966x->dev, "register_netdev failed\n");
> > 
> > Since the xdp-features series is now merged in net-next, do you think it is
> > better to target this patch to net-next?
> 
> Yes, that would be better given it's a pure driver change. I moved delegate
> to netdev.

ack, thx, in this way I do not need to repost :)

Regards,
Lorenzo

> 
> Thanks,
> Daniel
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-02-13 18:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10 19:06 [PATCH bpf-next] net: lan966x: set xdp_features flag Lorenzo Bianconi
2023-02-12  9:07 ` Lorenzo Bianconi
2023-02-13 17:00   ` Daniel Borkmann
2023-02-13 18:46     ` Lorenzo Bianconi [this message]
2023-02-13 20:24 ` Horatiu Vultur
2023-02-14  1:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+qFj2YIE4OAWcld@lore-desk \
    --to=lorenzo.bianconi@redhat.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=kuba@kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.