[oe-core][PATCH] graphene: disable neon support on arm 32bits

[oe-core][PATCH] graphene: disable neon support on arm 32bits

[Markus Volk]

From: Pablo Saavedra <psaavedra@igalia.com>

This disables neon support on arm devices only because it crashes otherwise.

Upstream-status: Reported [https://github.com/ebassi/graphene/issues/215]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-graphics/graphene/graphene_1.10.8.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-graphics/graphene/graphene_1.10.8.bb b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
index 813ff74adf..1bbe7ecca1 100644
--- a/meta/recipes-graphics/graphene/graphene_1.10.8.bb
+++ b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
@@ -17,6 +17,9 @@ GTKDOC_MESON_OPTION = "gtk_doc"
 
 EXTRA_OEMESON = "-Dinstalled_tests=false"
 
+# Disable ARM NEON support
+EXTRA_OEMESON:append:arm = " -Darm_neon=false"
+
 FILES:${PN} += "${libdir}/graphene-1.0"
 
 BBCLASSEXTEND = "native nativesdk"
-- 
2.34.1

Re: [oe-core][PATCH] graphene: disable neon support on arm 32bits

[Richard Purdie]

On Sat, 2023-02-11 at 09:26 +0100, Markus Volk wrote:
> From: Pablo Saavedra <psaavedra@igalia.com>
> 
> This disables neon support on arm devices only because it crashes otherwise.
> 
> Upstream-status: Reported [https://github.com/ebassi/graphene/issues/215]
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-graphics/graphene/graphene_1.10.8.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-graphics/graphene/graphene_1.10.8.bb b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> index 813ff74adf..1bbe7ecca1 100644
> --- a/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> +++ b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> @@ -17,6 +17,9 @@ GTKDOC_MESON_OPTION = "gtk_doc"
>  
>  EXTRA_OEMESON = "-Dinstalled_tests=false"
>  
> +# Disable ARM NEON support
> +EXTRA_OEMESON:append:arm = " -Darm_neon=false"
> +
>  FILES:${PN} += "${libdir}/graphene-1.0"
>  
>  BBCLASSEXTEND = "native nativesdk"

Can we tweak the comment to say why? Saying what it does isn't that
useful, saying why it does it helps to understand when it may be
removed in future. An example of how to crash it would be even better.
Was this just some some subset of 32 bit arm or all 32 bit arm?

Cheers,

Richard

Re: [oe-core][PATCH] graphene: disable neon support on arm 32bits

[Markus Volk]

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

Am Sa, 11. Feb 2023 um 09:05:05 +0000 schrieb Richard Purdie 
<richard.purdie@linuxfoundation.org>:
> Can we tweak the comment to say why? Saying what it does isn't that
> useful, saying why it does it helps to understand when it may be
> removed in future. An example of how to crash it would be even better.
> Was this just some some subset of 32 bit arm or all 32 bit arm?
> 
> Cheers,
> 
> Richard

Hello Richard,

I'm not affected by this bug, none of my machines has it but probably  
the underlying problem is, that there are still issues with neon 
runtime detection and not all arm platforms are guaranteed to have NEON 
available. That said, maybe it would be better to add this as a 
PACKAGECONFIG, so people could at least manually enable neon support if 
they know it would be working for them?


[-- Attachment #2: Type: text/html, Size: 986 bytes --]

Re: [oe-core][PATCH] graphene: disable neon support on arm 32bits

[Alexandre Belloni]

On 13/02/2023 10:47:19+0100, Markus Volk wrote:
> Am Sa, 11. Feb 2023 um 09:05:05 +0000 schrieb Richard Purdie
> <richard.purdie@linuxfoundation.org>:
> > Can we tweak the comment to say why? Saying what it does isn't that
> > useful, saying why it does it helps to understand when it may be
> > removed in future. An example of how to crash it would be even better.
> > Was this just some some subset of 32 bit arm or all 32 bit arm?
> > 
> > Cheers,
> > 
> > Richard
> 
> Hello Richard,
> 
> I'm not affected by this bug, none of my machines has it but probably  the
> underlying problem is, that there are still issues with neon runtime
> detection and not all arm platforms are guaranteed to have NEON available.
> That said, maybe it would be better to add this as a PACKAGECONFIG, so
> people could at least manually enable neon support if they know it would be
> working for them?
> 

Can't we get that out of the tune?


> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#177087): https://lists.openembedded.org/g/openembedded-core/message/177087
> Mute This Topic: https://lists.openembedded.org/mt/96893757/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [oe-core][PATCH] graphene: disable neon support on arm 32bits

[Markus Volk]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

Am Mo, 13. Feb 2023 um 22:06:57 +0100 schrieb Alexandre Belloni via 
lists.openembedded.org 
<alexandre.belloni=bootlin.com@lists.openembedded.org>:
> 
> Can't we get that out of the tune?

The problem I see is that we would need to know for sure what works and 
what doesn't.


[-- Attachment #2: Type: text/html, Size: 441 bytes --]

Re: [oe-core][PATCH] graphene: disable neon support on arm 32bits

[Markus Volk]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

sent a patch for it

> maybe it would be better to add this as a PACKAGECONFIG, so people 
> could at least manually enable neon support if they know it would be 
> working for them?


[-- Attachment #2: Type: text/html, Size: 351 bytes --]

Re: [oe-core][PATCH] graphene: disable neon support on arm 32bits

[Markus Volk]

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

This fix was recently added to meta-oe. Move the patch to oe-core, 
because graphene is needed here to build gtk4.
I also sent a patch to remove graphene from meta-oe.

Am Sa, 11. Feb 2023 um 09:26:09 +0100 schrieb Markus Volk 
<f_l_k@t-online.de>:
> From: Pablo Saavedra <psaavedra@igalia.com 
> <mailto:psaavedra@igalia.com>>
> 
> This disables neon support on arm devices only because it crashes 
> otherwise.
> 
> Upstream-status: Reported 
> [<https://github.com/ebassi/graphene/issues/215>]
> Signed-off-by: Khem Raj <raj.khem@gmail.com 
> <mailto:raj.khem@gmail.com>>
> ---
>  meta/recipes-graphics/graphene/graphene_1.10.8.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-graphics/graphene/graphene_1.10.8.bb 
> b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> index 813ff74adf..1bbe7ecca1 100644
> --- a/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> +++ b/meta/recipes-graphics/graphene/graphene_1.10.8.bb
> @@ -17,6 +17,9 @@ GTKDOC_MESON_OPTION = "gtk_doc"
> 
>  EXTRA_OEMESON = "-Dinstalled_tests=false"
> 
> +# Disable ARM NEON support
> +EXTRA_OEMESON:append:arm = " -Darm_neon=false"
> +
>  FILES:${PN} += "${libdir}/graphene-1.0"
> 
>  BBCLASSEXTEND = "native nativesdk"
> --
> 2.34.1
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#177000): 
> <https://lists.openembedded.org/g/openembedded-core/message/177000>
> Mute This Topic: <https://lists.openembedded.org/mt/96893757/3618223>
> Group Owner: openembedded-core+owner@lists.openembedded.org 
> <mailto:openembedded-core+owner@lists.openembedded.org>
> Unsubscribe: 
> <https://lists.openembedded.org/g/openembedded-core/unsub> 
> [f_l_k@t-online.de <mailto:f_l_k@t-online.de>]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


[-- Attachment #2: Type: text/html, Size: 2281 bytes --]