From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-imx@nxp.com" <linux-imx@nxp.com>
Subject: Re: [REGRESSION] rtc: imx-sc: remove .read_alarm
Date: Tue, 14 Feb 2023 21:01:00 +0100 [thread overview]
Message-ID: <Y+vofPf0YVp5Ay65@mail.local> (raw)
In-Reply-To: <bbe470eaeeb17624444b37dbe35b0883193e475b.camel@toradex.com>
Hello,
On 08/02/2023 15:06:28+0000, Marcel Ziswiler wrote:
> Hi Alexandre
>
> Were you aware that this breaks the sysfs use case? E.g. before we were able to suspend and resume 10 seconds
> later as follows:
>
> echo +10 > /sys/class/rtc/rtc1/wakealarm; echo mem > /sys/power/state
>
> Since the removal of .read_alarm in commit 7942121b8ca0 ("rtc: imx-sc: remove .read_alarm") this no longer
> seems to work.
>
> This seems like a regression or is this not supposed to work?
This seems like a regression and I think it was reported a while ago and
then again just after you. I believe there is something to do that is
smarter than reverting the patch, I need to check.
Regards
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-imx@nxp.com" <linux-imx@nxp.com>
Subject: Re: [REGRESSION] rtc: imx-sc: remove .read_alarm
Date: Tue, 14 Feb 2023 21:01:00 +0100 [thread overview]
Message-ID: <Y+vofPf0YVp5Ay65@mail.local> (raw)
In-Reply-To: <bbe470eaeeb17624444b37dbe35b0883193e475b.camel@toradex.com>
Hello,
On 08/02/2023 15:06:28+0000, Marcel Ziswiler wrote:
> Hi Alexandre
>
> Were you aware that this breaks the sysfs use case? E.g. before we were able to suspend and resume 10 seconds
> later as follows:
>
> echo +10 > /sys/class/rtc/rtc1/wakealarm; echo mem > /sys/power/state
>
> Since the removal of .read_alarm in commit 7942121b8ca0 ("rtc: imx-sc: remove .read_alarm") this no longer
> seems to work.
>
> This seems like a regression or is this not supposed to work?
This seems like a regression and I think it was reported a while ago and
then again just after you. I believe there is something to do that is
smarter than reverting the patch, I need to check.
Regards
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-14 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 15:06 [REGRESSION] rtc: imx-sc: remove .read_alarm Marcel Ziswiler
2023-02-08 15:06 ` Marcel Ziswiler
2023-02-14 20:01 ` Alexandre Belloni [this message]
2023-02-14 20:01 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+vofPf0YVp5Ay65@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.