* [PATCH] perf tools: Fix man page build wrt perf-arm-coresight.txt
@ 2022-10-17 9:35 Adrian Hunter
2022-10-17 9:57 ` Leo Yan
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Hunter @ 2022-10-17 9:35 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: suzuki.poulose, linux-perf-users, mathieu.poirier, mike.leach,
leo.yan, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-kernel,
coresight, Sven Schnelle, James Clark, Christian Borntraeger,
Carsten Haitzler
perf build assumes documentation files starting with "perf-" are man
pages but perf-arm-coresight.txt is not a man page:
asciidoc: ERROR: perf-arm-coresight.txt: line 2: malformed manpage title
asciidoc: ERROR: perf-arm-coresight.txt: line 3: name section expected
asciidoc: FAILED: perf-arm-coresight.txt: line 3: section title expected
make[3]: *** [Makefile:266: perf-arm-coresight.xml] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile.perf:895: man] Error 2
Fix by renaming it.
Reported-by: Sven Schnelle <svens@linux.ibm.com>
Reported-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Fixes: dc2e0fb00bb2 ("perf test coresight: Add relevant documentation about ARM64 CoreSight testing")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
.../Documentation/{perf-arm-coresight.txt => arm-coresight.txt} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename tools/perf/Documentation/{perf-arm-coresight.txt => arm-coresight.txt} (100%)
diff --git a/tools/perf/Documentation/perf-arm-coresight.txt b/tools/perf/Documentation/arm-coresight.txt
similarity index 100%
rename from tools/perf/Documentation/perf-arm-coresight.txt
rename to tools/perf/Documentation/arm-coresight.txt
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf tools: Fix man page build wrt perf-arm-coresight.txt
2022-10-17 9:35 [PATCH] perf tools: Fix man page build wrt perf-arm-coresight.txt Adrian Hunter
@ 2022-10-17 9:57 ` Leo Yan
2022-10-17 12:19 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Leo Yan @ 2022-10-17 9:57 UTC (permalink / raw)
To: Adrian Hunter
Cc: Arnaldo Carvalho de Melo, suzuki.poulose, linux-perf-users,
mathieu.poirier, mike.leach, Peter Zijlstra, Ingo Molnar,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
linux-kernel, coresight, Sven Schnelle, James Clark,
Christian Borntraeger, Carsten Haitzler
On Mon, Oct 17, 2022 at 12:35:49PM +0300, Adrian Hunter wrote:
> perf build assumes documentation files starting with "perf-" are man
> pages but perf-arm-coresight.txt is not a man page:
>
> asciidoc: ERROR: perf-arm-coresight.txt: line 2: malformed manpage title
> asciidoc: ERROR: perf-arm-coresight.txt: line 3: name section expected
> asciidoc: FAILED: perf-arm-coresight.txt: line 3: section title expected
> make[3]: *** [Makefile:266: perf-arm-coresight.xml] Error 1
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [Makefile.perf:895: man] Error 2
>
> Fix by renaming it.
>
> Reported-by: Sven Schnelle <svens@linux.ibm.com>
> Reported-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> Fixes: dc2e0fb00bb2 ("perf test coresight: Add relevant documentation about ARM64 CoreSight testing")
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Thanks for fixing, Adrian. The change LGTM:
Reviewed-by: Leo Yan <leo.yan@linaro.org>
> ---
> .../Documentation/{perf-arm-coresight.txt => arm-coresight.txt} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename tools/perf/Documentation/{perf-arm-coresight.txt => arm-coresight.txt} (100%)
>
> diff --git a/tools/perf/Documentation/perf-arm-coresight.txt b/tools/perf/Documentation/arm-coresight.txt
> similarity index 100%
> rename from tools/perf/Documentation/perf-arm-coresight.txt
> rename to tools/perf/Documentation/arm-coresight.txt
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf tools: Fix man page build wrt perf-arm-coresight.txt
2022-10-17 9:57 ` Leo Yan
@ 2022-10-17 12:19 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-10-17 12:19 UTC (permalink / raw)
To: Leo Yan
Cc: Adrian Hunter, suzuki.poulose, linux-perf-users, mathieu.poirier,
mike.leach, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-kernel,
coresight, Sven Schnelle, James Clark, Christian Borntraeger,
Carsten Haitzler
Em Mon, Oct 17, 2022 at 05:57:43PM +0800, Leo Yan escreveu:
> On Mon, Oct 17, 2022 at 12:35:49PM +0300, Adrian Hunter wrote:
> > perf build assumes documentation files starting with "perf-" are man
> > pages but perf-arm-coresight.txt is not a man page:
> >
> > asciidoc: ERROR: perf-arm-coresight.txt: line 2: malformed manpage title
> > asciidoc: ERROR: perf-arm-coresight.txt: line 3: name section expected
> > asciidoc: FAILED: perf-arm-coresight.txt: line 3: section title expected
> > make[3]: *** [Makefile:266: perf-arm-coresight.xml] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> > make[2]: *** [Makefile.perf:895: man] Error 2
> >
> > Fix by renaming it.
> >
> > Reported-by: Sven Schnelle <svens@linux.ibm.com>
> > Reported-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> > Fixes: dc2e0fb00bb2 ("perf test coresight: Add relevant documentation about ARM64 CoreSight testing")
> > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Thanks for fixing, Adrian. The change LGTM:
>
> Reviewed-by: Leo Yan <leo.yan@linaro.org>
Thanks, applied.
- Arnaldo
> > ---
> > .../Documentation/{perf-arm-coresight.txt => arm-coresight.txt} | 0
> > 1 file changed, 0 insertions(+), 0 deletions(-)
> > rename tools/perf/Documentation/{perf-arm-coresight.txt => arm-coresight.txt} (100%)
> >
> > diff --git a/tools/perf/Documentation/perf-arm-coresight.txt b/tools/perf/Documentation/arm-coresight.txt
> > similarity index 100%
> > rename from tools/perf/Documentation/perf-arm-coresight.txt
> > rename to tools/perf/Documentation/arm-coresight.txt
> > --
> > 2.25.1
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-17 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-17 9:35 [PATCH] perf tools: Fix man page build wrt perf-arm-coresight.txt Adrian Hunter
2022-10-17 9:57 ` Leo Yan
2022-10-17 12:19 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.