* [PATCH] vfio: More vfio_file_is_group() use cases
@ 2022-10-07 18:57 Alex Williamson
2022-10-07 19:01 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Alex Williamson @ 2022-10-07 18:57 UTC (permalink / raw)
To: kvm; +Cc: alex.williamson, jgg
Replace further open coded tests with helper.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
Applies on https://lore.kernel.org/all/0-v2-15417f29324e+1c-vfio_group_disassociate_jgg@nvidia.com/
drivers/vfio/vfio_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c
index 04099a839a52..2d168793d4e1 100644
--- a/drivers/vfio/vfio_main.c
+++ b/drivers/vfio/vfio_main.c
@@ -1615,7 +1615,7 @@ bool vfio_file_enforced_coherent(struct file *file)
struct vfio_group *group = file->private_data;
bool ret;
- if (file->f_op != &vfio_group_fops)
+ if (!vfio_file_is_group(file))
return true;
mutex_lock(&group->group_lock);
@@ -1647,7 +1647,7 @@ void vfio_file_set_kvm(struct file *file, struct kvm *kvm)
{
struct vfio_group *group = file->private_data;
- if (file->f_op != &vfio_group_fops)
+ if (!vfio_file_is_group(file))
return;
mutex_lock(&group->group_lock);
@@ -1667,7 +1667,7 @@ bool vfio_file_has_dev(struct file *file, struct vfio_device *device)
{
struct vfio_group *group = file->private_data;
- if (file->f_op != &vfio_group_fops)
+ if (!vfio_file_is_group(file))
return false;
return group == device->group;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vfio: More vfio_file_is_group() use cases
2022-10-07 18:57 [PATCH] vfio: More vfio_file_is_group() use cases Alex Williamson
@ 2022-10-07 19:01 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2022-10-07 19:01 UTC (permalink / raw)
To: Alex Williamson; +Cc: kvm
On Fri, Oct 07, 2022 at 12:57:14PM -0600, Alex Williamson wrote:
> Replace further open coded tests with helper.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>
> Applies on https://lore.kernel.org/all/0-v2-15417f29324e+1c-vfio_group_disassociate_jgg@nvidia.com/
Yes, makes sense
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-07 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-07 18:57 [PATCH] vfio: More vfio_file_is_group() use cases Alex Williamson
2022-10-07 19:01 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.