From: Alison Schofield <alison.schofield@intel.com>
To: Hunter Chasens <hunter.chasens18@ncf.edu>
Cc: outreachy@lists.linux.dev
Subject: Re: [PATCH v2 0/2] Staging: greybus: Fixed whitespace/syntax style issues
Date: Mon, 10 Oct 2022 13:25:30 -0700 [thread overview]
Message-ID: <Y0R/uscIGcUENEWx@aschofie-mobl2> (raw)
In-Reply-To: <cover.1665430030.git.hunter.chasens18@ncf.edu>
On Mon, Oct 10, 2022 at 03:51:57PM -0400, Hunter Chasens wrote:
> These two patches address some Errors, Warnings, and Checks reported by `./scripts/checkpatch.pl`
>
> v1 -> v2
> Separates the patch into a small patchset with the delimitation of syntactical styling vs whitespace styling.
> (I plan on sending to the maintainers if Outreach thinks this is an appropriate patch.)
Hi Hunter,
Please see the directions in the First Patch Tutorial and also repeated
in the mailing list message:
>> You MUST send all patches to this mailing list AND to the appropriate
>> mailing lists and maintainers in get_maintainer.pl. The tutorial walks
>> you through how to use get_maintainer.pl.
We don't want to preview patches on the list. It saves you time and
reviewers time, as there on reviewers who will jump on your staging
patches that might not be on the Outreachy list. It's also the way
we develop - in the open.
So - in this case, you'll send out a v3 and in the changelog one of
the changed items needs to say - Expanded the 'CC list to include
maintainers.
Please do ask questions on the list - just do not post patches for
review that do not have the maintainers included.
Thanks!
Alison
>
> Hunter Chasens (2):
> Staging: greybus: Fixed whitespace style issues
> Staging: greybus: Removed redundent 'int'
>
> .../Documentation/firmware/authenticate.c | 4 +--
> .../greybus/Documentation/firmware/firmware.c | 34 +++++++++----------
> drivers/staging/greybus/arche-platform.c | 2 +-
> .../staging/greybus/greybus_authentication.h | 1 -
> drivers/staging/greybus/loopback.c | 3 +-
> drivers/staging/greybus/tools/loopback_test.c | 16 +--------
> 6 files changed, 22 insertions(+), 38 deletions(-)
>
> --
> 2.37.3
>
>
next prev parent reply other threads:[~2022-10-10 20:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 19:51 [PATCH v2 0/2] Staging: greybus: Fixed whitespace/syntax style issues Hunter Chasens
2022-10-10 19:51 ` [PATCH v2 1/2] Staging: greybus: Fixed whitespace " Hunter Chasens
2022-10-10 20:06 ` Julia Lawall
2022-10-10 20:31 ` Alison Schofield
2022-10-10 22:52 ` Hunter Chasens
2022-10-10 19:51 ` [PATCH v2 2/2] Staging: greybus: Removed redundent 'int' Hunter Chasens
2022-10-10 20:04 ` Julia Lawall
2022-10-10 20:25 ` Alison Schofield [this message]
2022-10-10 22:18 ` [PATCH v2 0/2] Staging: greybus: Fixed whitespace/syntax style issues Hunter Chasens
2022-10-10 23:53 ` Alison Schofield
2022-10-11 1:31 ` Alison Schofield
2022-10-11 1:56 ` Hunter Chasens
2022-10-11 5:07 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0R/uscIGcUENEWx@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=hunter.chasens18@ncf.edu \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.