From: Alison Schofield <alison.schofield@intel.com>
To: Hunter Chasens <hunter.chasens18@ncf.edu>
Cc: outreachy@lists.linux.dev
Subject: Re: [PATCH v2 1/2] Staging: greybus: Fixed whitespace style issues
Date: Mon, 10 Oct 2022 13:31:49 -0700 [thread overview]
Message-ID: <Y0SBNeoQDfWmJcZi@aschofie-mobl2> (raw)
In-Reply-To: <78af8ab0297e0af46835937d73dee23f187650a1.1665430031.git.hunter.chasens18@ncf.edu>
On Mon, Oct 10, 2022 at 03:51:58PM -0400, Hunter Chasens wrote:
> Fixed multiple whitespace and alignment code style issues.
>
> Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
Hi Hunter,
Checkpatch CHECK complained about this patch. It's not something you added,
but since you touched the line, it's going to show up when checkpatch
is run on your completed patch.
Correcting this would be another patch in your set, since it's a
different type of cleanup - removing useless parenthesis.
CHECK: Unnecessary parentheses around 'backend_fw_info.status != GB_FW_U_BACKEND_VERSION_STATUS_SUCCESS'
#92: FILE: drivers/staging/greybus/Documentation/firmware/firmware.c:122:
+ if ((backend_fw_info.status != GB_FW_U_BACKEND_VERSION_STATUS_SUCCESS) &&
+ (backend_fw_info.status != GB_FW_U_BACKEND_VERSION_STATUS_NOT_AVAILABLE)) {
CHECK: Unnecessary parentheses around 'backend_fw_info.status != GB_FW_U_BACKEND_VERSION_STATUS_NOT_AVAILABLE'
#92: FILE: drivers/staging/greybus/Documentation/firmware/firmware.c:122:
+ if ((backend_fw_info.status != GB_FW_U_BACKEND_VERSION_STATUS_SUCCESS) &&
+ (backend_fw_info.status != GB_FW_U_BACKEND_VERSION_STATUS_NOT_AVAILABLE)) {
--snip
Thanks,
Alison
next prev parent reply other threads:[~2022-10-10 20:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 19:51 [PATCH v2 0/2] Staging: greybus: Fixed whitespace/syntax style issues Hunter Chasens
2022-10-10 19:51 ` [PATCH v2 1/2] Staging: greybus: Fixed whitespace " Hunter Chasens
2022-10-10 20:06 ` Julia Lawall
2022-10-10 20:31 ` Alison Schofield [this message]
2022-10-10 22:52 ` Hunter Chasens
2022-10-10 19:51 ` [PATCH v2 2/2] Staging: greybus: Removed redundent 'int' Hunter Chasens
2022-10-10 20:04 ` Julia Lawall
2022-10-10 20:25 ` [PATCH v2 0/2] Staging: greybus: Fixed whitespace/syntax style issues Alison Schofield
2022-10-10 22:18 ` Hunter Chasens
2022-10-10 23:53 ` Alison Schofield
2022-10-11 1:31 ` Alison Schofield
2022-10-11 1:56 ` Hunter Chasens
2022-10-11 5:07 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0SBNeoQDfWmJcZi@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=hunter.chasens18@ncf.edu \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.