Re: [PATCH v1 1/1] pinctrl: st: Switch to use fwnode instead of of_node

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Patrice Chotard <patrice.chotard@foss.st.com>
Subject: Re: [PATCH v1 1/1] pinctrl: st: Switch to use fwnode instead of of_node
Date: Mon, 10 Oct 2022 10:59:25 -0700	[thread overview]
Message-ID: <Y0RdfcC5FVRX/XI9@google.com> (raw)
In-Reply-To: <20221010075615.43244-1-andriy.shevchenko@linux.intel.com>

On Mon, Oct 10, 2022 at 10:56:15AM +0300, Andy Shevchenko wrote:
> The OF node in the GPIO library is deprecated and soon
> will be removed.
> 
> GPIO library now accepts fwnode as a firmware node, so
> switch the driver to use it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

> ---
>  drivers/pinctrl/pinctrl-st.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index cf7f9cbe6044..987878c83349 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1175,7 +1175,7 @@ static int st_pctl_dt_calculate_pin(struct st_pinctrl *info,
>  
>  	for (i = 0; i < info->nbanks; i++) {
>  		chip = &info->banks[i].gpio_chip;
> -		if (chip->of_node == np) {
> +		if (chip->fwnode == of_fwnode_handle(np)) {
>  			if (offset < chip->ngpio)
>  				retval = chip->base + offset;
>  			break;
> @@ -1518,7 +1518,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
>  	bank->gpio_chip = st_gpio_template;
>  	bank->gpio_chip.base = bank_num * ST_GPIO_PINS_PER_BANK;
>  	bank->gpio_chip.ngpio = ST_GPIO_PINS_PER_BANK;
> -	bank->gpio_chip.of_node = np;
> +	bank->gpio_chip.fwnode = of_fwnode_handle(np);
>  	bank->gpio_chip.parent = dev;
>  	spin_lock_init(&bank->lock);
>  
> -- 
> 2.35.1
> 

Thanks.

-- 
Dmitry