From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Tadeusz Struk <tadeusz.struk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/2] libfdt: add fdt_get_property_by_offset_w helper
Date: Wed, 12 Oct 2022 10:50:35 +1100 [thread overview]
Message-ID: <Y0YBS2ZHi+0CkC74@yekko> (raw)
In-Reply-To: <20221011182611.116011-1-tadeusz.struk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]
On Tue, Oct 11, 2022 at 11:26:10AM -0700, Tadeusz Struk wrote:
> Add a new fdt_get_property_by_offset_w helper function.
> It is a wrapper on fdt_get_property_by_offset that returns
> a writable pointer to a property at a given offset.
>
> Signed-off-by: Tadeusz Struk <tadeusz.struk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Applied, thanks.
> ---
> v2: Remove const from the first param (fdt).
> ---
> libfdt/libfdt.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/libfdt/libfdt.h b/libfdt/libfdt.h
> index a7f432c..d0a2ed2 100644
> --- a/libfdt/libfdt.h
> +++ b/libfdt/libfdt.h
> @@ -660,6 +660,13 @@ int fdt_next_property_offset(const void *fdt, int offset);
> const struct fdt_property *fdt_get_property_by_offset(const void *fdt,
> int offset,
> int *lenp);
> +static inline struct fdt_property *fdt_get_property_by_offset_w(void *fdt,
> + int offset,
> + int *lenp)
> +{
> + return (struct fdt_property *)(uintptr_t)
> + fdt_get_property_by_offset(fdt, offset, lenp);
> +}
>
> /**
> * fdt_get_property_namelen - find a property based on substring
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: Tadeusz Struk <tadeusz.struk@linaro.org>
Cc: devicetree@vger.kernel.org, devicetree-compiler@vger.kernel.org
Subject: Re: [PATCH v2 1/2] libfdt: add fdt_get_property_by_offset_w helper
Date: Wed, 12 Oct 2022 10:50:35 +1100 [thread overview]
Message-ID: <Y0YBS2ZHi+0CkC74@yekko> (raw)
In-Reply-To: <20221011182611.116011-1-tadeusz.struk@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
On Tue, Oct 11, 2022 at 11:26:10AM -0700, Tadeusz Struk wrote:
> Add a new fdt_get_property_by_offset_w helper function.
> It is a wrapper on fdt_get_property_by_offset that returns
> a writable pointer to a property at a given offset.
>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org>
Applied, thanks.
> ---
> v2: Remove const from the first param (fdt).
> ---
> libfdt/libfdt.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/libfdt/libfdt.h b/libfdt/libfdt.h
> index a7f432c..d0a2ed2 100644
> --- a/libfdt/libfdt.h
> +++ b/libfdt/libfdt.h
> @@ -660,6 +660,13 @@ int fdt_next_property_offset(const void *fdt, int offset);
> const struct fdt_property *fdt_get_property_by_offset(const void *fdt,
> int offset,
> int *lenp);
> +static inline struct fdt_property *fdt_get_property_by_offset_w(void *fdt,
> + int offset,
> + int *lenp)
> +{
> + return (struct fdt_property *)(uintptr_t)
> + fdt_get_property_by_offset(fdt, offset, lenp);
> +}
>
> /**
> * fdt_get_property_namelen - find a property based on substring
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-11 23:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 18:26 [PATCH v2 1/2] libfdt: add fdt_get_property_by_offset_w helper Tadeusz Struk
2022-10-11 18:26 ` Tadeusz Struk
[not found] ` <20221011182611.116011-1-tadeusz.struk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2022-10-11 18:26 ` [PATCH v6 2/2] libfdt: tests: add get_next_tag_invalid_prop_len Tadeusz Struk
2022-10-11 18:26 ` Tadeusz Struk
[not found] ` <20221011182611.116011-2-tadeusz.struk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2022-10-11 23:51 ` David Gibson
2022-10-11 23:51 ` David Gibson
2022-10-11 23:50 ` David Gibson [this message]
2022-10-11 23:50 ` [PATCH v2 1/2] libfdt: add fdt_get_property_by_offset_w helper David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0YBS2ZHi+0CkC74@yekko \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-compiler-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tadeusz.struk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.