From: Dan Carpenter <dan.carpenter@oracle.com>
To: ehakim@nvidia.com
Cc: linux-rdma@vger.kernel.org
Subject: [bug report] net/mlx5e: Create advanced steering operation (ASO) object for MACsec
Date: Wed, 12 Oct 2022 18:01:06 +0300 [thread overview]
Message-ID: <Y0bWsiXzY6VtxBFG@kili> (raw)
Hello Emeel Hakim,
This is a semi-automatic email about new static checker warnings.
The patch 1f53da676439: "net/mlx5e: Create advanced steering
operation (ASO) object for MACsec" from Sep 21, 2022, leads to the
following Smatch complaint:
drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c:1851 mlx5e_macsec_cleanup()
warn: variable dereferenced before check 'macsec' (see line 1849)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c
1848 struct mlx5e_macsec *macsec = priv->macsec;
1849 struct mlx5_core_dev *mdev = macsec->mdev;
^^^^^^^^^^^^
The patch adds a dereference
1850
1851 if (!macsec)
^^^^^^
But the old code assumed "macsec" could be NULL
1852 return;
1853
regards,
dan carpenter
reply other threads:[~2022-10-12 15:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0bWsiXzY6VtxBFG@kili \
--to=dan.carpenter@oracle.com \
--cc=ehakim@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.