* [bug report] net/mlx5e: Create advanced steering operation (ASO) object for MACsec
@ 2022-10-12 15:01 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2022-10-12 15:01 UTC (permalink / raw)
To: ehakim; +Cc: linux-rdma
Hello Emeel Hakim,
This is a semi-automatic email about new static checker warnings.
The patch 1f53da676439: "net/mlx5e: Create advanced steering
operation (ASO) object for MACsec" from Sep 21, 2022, leads to the
following Smatch complaint:
drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c:1851 mlx5e_macsec_cleanup()
warn: variable dereferenced before check 'macsec' (see line 1849)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c
1848 struct mlx5e_macsec *macsec = priv->macsec;
1849 struct mlx5_core_dev *mdev = macsec->mdev;
^^^^^^^^^^^^
The patch adds a dereference
1850
1851 if (!macsec)
^^^^^^
But the old code assumed "macsec" could be NULL
1852 return;
1853
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-12 15:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-12 15:01 [bug report] net/mlx5e: Create advanced steering operation (ASO) object for MACsec Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.