All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	kernel test robot <lkp@intel.com>, Jens Axboe <axboe@kernel.dk>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	"Jason A. Donenfeld" <zx2c4@kernel.org>,
	linux-riscv@lists.infradead.org,
	Aurelien Jarno <aurelien@aurel32.net>,
	Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [linux-stable-rc:linux-4.19.y 3113/3976] drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus,s4'
Date: Thu, 13 Oct 2022 19:47:35 +0100	[thread overview]
Message-ID: <Y0hdR2Z44oOQ989w@spud> (raw)
In-Reply-To: <Y0gONdihAaosW9+U@kroah.com>

On Thu, Oct 13, 2022 at 03:10:13PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 10, 2022 at 01:05:39PM +0100, Conor Dooley wrote:
> > On Mon, Oct 10, 2022 at 07:51:59PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > head:   5644b22533b36dc1a95ab1db4ae83381514b2908
> > > commit: 1923d9a8a08684c063da049fa9d5d8139edbbcbb [3113/3976] random: convert to using fops->write_iter()
> > > config: riscv-randconfig-c024-20221009
> > > compiler: riscv64-linux-gcc (GCC) 12.1.0
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=1923d9a8a08684c063da049fa9d5d8139edbbcbb
> > >         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > >         git fetch --no-tags linux-stable-rc linux-4.19.y
> > >         git checkout 1923d9a8a08684c063da049fa9d5d8139edbbcbb
> > >         # save the config file
> > >         mkdir build_dir && cp config build_dir/.config
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/char/
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >    arch/riscv/include/asm/irqflags.h: Assembler messages:
> > >    arch/riscv/include/asm/irqflags.h:42: Error: unrecognized opcode `csrrc s6,sstatus,2'
> > >    arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,0'
> > >    arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,s6'
> > >    drivers/char/random.c:1316: Error: unrecognized opcode `csrs sstatus,a3'
> > >    drivers/char/random.c:1316: Error: unrecognized opcode `csrc sstatus,a3'
> > >    drivers/char/random.c:1322: Error: unrecognized opcode `csrs sstatus,a3'
> > >    drivers/char/random.c:1322: Error: unrecognized opcode `csrc sstatus,a3'
> > > >> drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus,s4'
> > > >> drivers/char/random.c:1336: Error: unrecognized opcode `csrc sstatus,s4'
> > 
> > All of these look like 4.19.y is missing a backport of:
> > Fixes: 6df2a016c0c8 ("riscv: fix build with binutils 2.38")
> > 
> > That commit is CC: stable, so I assume it did not apply or w/e and
> > nobody cared enough to do a backport?
> 
> It does not apply and no one sent in a fixed backport :(

Welp, I have a fixed backport for it and pushed it out for LKP [0].
Just quickly checked it w/ binutils 2.36 & 2.38 locally, which both
worked fine. I doubt anyone really cares though, 4.19 is pretty long in
the tooth RISC-V hw wise. Not the biggest fan of what I did, but I
didn't want to send backports for some other infra changes that
6df2a016c0c8 depends on.

I'll send it to you once LKP gives it the all clear.

Thanks,
Conor.

0 -https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/commit/?h=riscv-backport_238_fix&id=cf7c2ca06cd0e5f6c16fe70e751380c8673da9ed

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [linux-stable-rc:linux-4.19.y 3113/3976] drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus, s4'
Date: Thu, 13 Oct 2022 19:47:35 +0100	[thread overview]
Message-ID: <Y0hdR2Z44oOQ989w@spud> (raw)
In-Reply-To: <Y0gONdihAaosW9+U@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 3348 bytes --]

On Thu, Oct 13, 2022 at 03:10:13PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 10, 2022 at 01:05:39PM +0100, Conor Dooley wrote:
> > On Mon, Oct 10, 2022 at 07:51:59PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > head:   5644b22533b36dc1a95ab1db4ae83381514b2908
> > > commit: 1923d9a8a08684c063da049fa9d5d8139edbbcbb [3113/3976] random: convert to using fops->write_iter()
> > > config: riscv-randconfig-c024-20221009
> > > compiler: riscv64-linux-gcc (GCC) 12.1.0
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=1923d9a8a08684c063da049fa9d5d8139edbbcbb
> > >         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > >         git fetch --no-tags linux-stable-rc linux-4.19.y
> > >         git checkout 1923d9a8a08684c063da049fa9d5d8139edbbcbb
> > >         # save the config file
> > >         mkdir build_dir && cp config build_dir/.config
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/char/
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >    arch/riscv/include/asm/irqflags.h: Assembler messages:
> > >    arch/riscv/include/asm/irqflags.h:42: Error: unrecognized opcode `csrrc s6,sstatus,2'
> > >    arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,0'
> > >    arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,s6'
> > >    drivers/char/random.c:1316: Error: unrecognized opcode `csrs sstatus,a3'
> > >    drivers/char/random.c:1316: Error: unrecognized opcode `csrc sstatus,a3'
> > >    drivers/char/random.c:1322: Error: unrecognized opcode `csrs sstatus,a3'
> > >    drivers/char/random.c:1322: Error: unrecognized opcode `csrc sstatus,a3'
> > > >> drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus,s4'
> > > >> drivers/char/random.c:1336: Error: unrecognized opcode `csrc sstatus,s4'
> > 
> > All of these look like 4.19.y is missing a backport of:
> > Fixes: 6df2a016c0c8 ("riscv: fix build with binutils 2.38")
> > 
> > That commit is CC: stable, so I assume it did not apply or w/e and
> > nobody cared enough to do a backport?
> 
> It does not apply and no one sent in a fixed backport :(

Welp, I have a fixed backport for it and pushed it out for LKP [0].
Just quickly checked it w/ binutils 2.36 & 2.38 locally, which both
worked fine. I doubt anyone really cares though, 4.19 is pretty long in
the tooth RISC-V hw wise. Not the biggest fan of what I did, but I
didn't want to send backports for some other infra changes that
6df2a016c0c8 depends on.

I'll send it to you once LKP gives it the all clear.

Thanks,
Conor.

0 -https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/commit/?h=riscv-backport_238_fix&id=cf7c2ca06cd0e5f6c16fe70e751380c8673da9ed

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	kernel test robot <lkp@intel.com>, Jens Axboe <axboe@kernel.dk>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	"Jason A. Donenfeld" <zx2c4@kernel.org>,
	linux-riscv@lists.infradead.org,
	Aurelien Jarno <aurelien@aurel32.net>,
	Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: [linux-stable-rc:linux-4.19.y 3113/3976] drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus,s4'
Date: Thu, 13 Oct 2022 19:47:35 +0100	[thread overview]
Message-ID: <Y0hdR2Z44oOQ989w@spud> (raw)
In-Reply-To: <Y0gONdihAaosW9+U@kroah.com>

On Thu, Oct 13, 2022 at 03:10:13PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 10, 2022 at 01:05:39PM +0100, Conor Dooley wrote:
> > On Mon, Oct 10, 2022 at 07:51:59PM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> > > head:   5644b22533b36dc1a95ab1db4ae83381514b2908
> > > commit: 1923d9a8a08684c063da049fa9d5d8139edbbcbb [3113/3976] random: convert to using fops->write_iter()
> > > config: riscv-randconfig-c024-20221009
> > > compiler: riscv64-linux-gcc (GCC) 12.1.0
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=1923d9a8a08684c063da049fa9d5d8139edbbcbb
> > >         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > >         git fetch --no-tags linux-stable-rc linux-4.19.y
> > >         git checkout 1923d9a8a08684c063da049fa9d5d8139edbbcbb
> > >         # save the config file
> > >         mkdir build_dir && cp config build_dir/.config
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/char/
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >    arch/riscv/include/asm/irqflags.h: Assembler messages:
> > >    arch/riscv/include/asm/irqflags.h:42: Error: unrecognized opcode `csrrc s6,sstatus,2'
> > >    arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,0'
> > >    arch/riscv/include/asm/irqflags.h:60: Error: unrecognized opcode `csrs sstatus,s6'
> > >    drivers/char/random.c:1316: Error: unrecognized opcode `csrs sstatus,a3'
> > >    drivers/char/random.c:1316: Error: unrecognized opcode `csrc sstatus,a3'
> > >    drivers/char/random.c:1322: Error: unrecognized opcode `csrs sstatus,a3'
> > >    drivers/char/random.c:1322: Error: unrecognized opcode `csrc sstatus,a3'
> > > >> drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus,s4'
> > > >> drivers/char/random.c:1336: Error: unrecognized opcode `csrc sstatus,s4'
> > 
> > All of these look like 4.19.y is missing a backport of:
> > Fixes: 6df2a016c0c8 ("riscv: fix build with binutils 2.38")
> > 
> > That commit is CC: stable, so I assume it did not apply or w/e and
> > nobody cared enough to do a backport?
> 
> It does not apply and no one sent in a fixed backport :(

Welp, I have a fixed backport for it and pushed it out for LKP [0].
Just quickly checked it w/ binutils 2.36 & 2.38 locally, which both
worked fine. I doubt anyone really cares though, 4.19 is pretty long in
the tooth RISC-V hw wise. Not the biggest fan of what I did, but I
didn't want to send backports for some other infra changes that
6df2a016c0c8 depends on.

I'll send it to you once LKP gives it the all clear.

Thanks,
Conor.

0 -https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/commit/?h=riscv-backport_238_fix&id=cf7c2ca06cd0e5f6c16fe70e751380c8673da9ed

  reply	other threads:[~2022-10-13 18:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10 11:51 [linux-stable-rc:linux-4.19.y 3113/3976] drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus,s4' kernel test robot
2022-10-10 12:05 ` [linux-stable-rc:linux-4.19.y 3113/3976] drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus, s4' Conor Dooley
2022-10-10 12:05   ` [linux-stable-rc:linux-4.19.y 3113/3976] drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus,s4' Conor Dooley
2022-10-13 13:10   ` [linux-stable-rc:linux-4.19.y 3113/3976] drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus, s4' Greg Kroah-Hartman
2022-10-13 13:10     ` [linux-stable-rc:linux-4.19.y 3113/3976] drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus,s4' Greg Kroah-Hartman
2022-10-13 18:47     ` Conor Dooley [this message]
2022-10-13 18:47       ` Conor Dooley
2022-10-13 18:47       ` [linux-stable-rc:linux-4.19.y 3113/3976] drivers/char/random.c:1336: Error: unrecognized opcode `csrs sstatus, s4' Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0hdR2Z44oOQ989w@spud \
    --to=conor@kernel.org \
    --cc=aurelien@aurel32.net \
    --cc=axboe@kernel.dk \
    --cc=conor.dooley@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=palmer@rivosinc.com \
    --cc=zx2c4@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.