From: Conor Dooley <conor@kernel.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Xianting Tian <xianting.tian@linux.alibaba.com>,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, anup@brainfault.org, heiko@sntech.de,
guoren@kernel.org, mick@ics.forth.gr,
alexandre.ghiti@canonical.com, bhe@redhat.com, vgoyal@redhat.com,
dyoung@redhat.com, corbet@lwn.net, Conor.Dooley@microchip.com,
kexec@lists.infradead.org, linux-doc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
crash-utility@redhat.com, heinrich.schuchardt@canonical.com,
k-hagio-ab@nec.com, hschauhan@nulltrace.org, yixun.lan@gmail.com
Subject: Re: [PATCH 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64
Date: Fri, 14 Oct 2022 14:10:18 +0100 [thread overview]
Message-ID: <Y0lfuixXue4k4poY@spud> (raw)
In-Reply-To: <Y0ldrJ91ac0um3++@debian.me>
Hey Bagas,
On Fri, Oct 14, 2022 at 08:01:32PM +0700, Bagas Sanjaya wrote:
> On Fri, Oct 14, 2022 at 03:48:10PM +0800, Xianting Tian wrote:
> > The following interrelated definitions and ranges are needed by the kdump
> > crash tool, they are exported by "arch/riscv/kernel/crash_core.c":
> > VA_BITS,
> > PAGE_OFFSET,
> > phys_ram_base,
> > MODULES_VADDR ~ MODULES_END,
> > VMALLOC_START ~ VMALLOC_END,
> > VMEMMAP_START ~ VMEMMAP_END,
> > KASAN_SHADOW_START ~ KASAN_SHADOW_END,
> > KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END
> >
> > Document these RISCV64 exports above.
> >
>
> The patch description LGTM, thanks.
>
> > +----------------------------------------------------------------------------------------------------------------------------------------------------
> > +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
> > +----------------------------------------------------------------------------------------------------------------------------------------------------
>
> The overline above header text is unnecessary, so I have to strip it:
>
> ---- >8 ----
>
> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> index 6c7a1728de220e..8e2e164cf3db49 100644
> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst
> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> @@ -615,7 +615,6 @@ phys_ram_base
>
> Indicates the start physical RAM address.
>
> -----------------------------------------------------------------------------------------------------------------------------------------------------
> MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
> ----------------------------------------------------------------------------------------------------------------------------------------------------
Without whitespace highlighting, your change threw me for a sec.. But
yeah, having the overline is inconsistent with other headings in the
doc.
What I wanted to ask about was the linelength as I don't know anything
about rst. Is it possible to avoid having the ~150 character line or is
that a necessary evil?
Thanks,
Conor.
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Xianting Tian <xianting.tian@linux.alibaba.com>,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, anup@brainfault.org, heiko@sntech.de,
guoren@kernel.org, mick@ics.forth.gr,
alexandre.ghiti@canonical.com, bhe@redhat.com, vgoyal@redhat.com,
dyoung@redhat.com, corbet@lwn.net, Conor.Dooley@microchip.com,
kexec@lists.infradead.org, linux-doc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
crash-utility@redhat.com, heinrich.schuchardt@canonical.com,
k-hagio-ab@nec.com, hschauhan@nulltrace.org, yixun.lan@gmail.com
Subject: Re: [PATCH 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64
Date: Fri, 14 Oct 2022 14:10:18 +0100 [thread overview]
Message-ID: <Y0lfuixXue4k4poY@spud> (raw)
In-Reply-To: <Y0ldrJ91ac0um3++@debian.me>
Hey Bagas,
On Fri, Oct 14, 2022 at 08:01:32PM +0700, Bagas Sanjaya wrote:
> On Fri, Oct 14, 2022 at 03:48:10PM +0800, Xianting Tian wrote:
> > The following interrelated definitions and ranges are needed by the kdump
> > crash tool, they are exported by "arch/riscv/kernel/crash_core.c":
> > VA_BITS,
> > PAGE_OFFSET,
> > phys_ram_base,
> > MODULES_VADDR ~ MODULES_END,
> > VMALLOC_START ~ VMALLOC_END,
> > VMEMMAP_START ~ VMEMMAP_END,
> > KASAN_SHADOW_START ~ KASAN_SHADOW_END,
> > KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END
> >
> > Document these RISCV64 exports above.
> >
>
> The patch description LGTM, thanks.
>
> > +----------------------------------------------------------------------------------------------------------------------------------------------------
> > +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
> > +----------------------------------------------------------------------------------------------------------------------------------------------------
>
> The overline above header text is unnecessary, so I have to strip it:
>
> ---- >8 ----
>
> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> index 6c7a1728de220e..8e2e164cf3db49 100644
> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst
> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> @@ -615,7 +615,6 @@ phys_ram_base
>
> Indicates the start physical RAM address.
>
> -----------------------------------------------------------------------------------------------------------------------------------------------------
> MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
> ----------------------------------------------------------------------------------------------------------------------------------------------------
Without whitespace highlighting, your change threw me for a sec.. But
yeah, having the overline is inconsistent with other headings in the
doc.
What I wanted to ask about was the linelength as I don't know anything
about rst. Is it possible to avoid having the ~150 character line or is
that a necessary evil?
Thanks,
Conor.
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Xianting Tian <xianting.tian@linux.alibaba.com>,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, anup@brainfault.org, heiko@sntech.de,
guoren@kernel.org, mick@ics.forth.gr,
alexandre.ghiti@canonical.com, bhe@redhat.com, vgoyal@redhat.com,
dyoung@redhat.com, corbet@lwn.net, Conor.Dooley@microchip.com,
kexec@lists.infradead.org, linux-doc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
crash-utility@redhat.com, heinrich.schuchardt@canonical.com,
k-hagio-ab@nec.com, hschauhan@nulltrace.org, yixun.lan@gmail.com
Subject: Re: [PATCH 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64
Date: Fri, 14 Oct 2022 14:10:18 +0100 [thread overview]
Message-ID: <Y0lfuixXue4k4poY@spud> (raw)
In-Reply-To: <Y0ldrJ91ac0um3++@debian.me>
Hey Bagas,
On Fri, Oct 14, 2022 at 08:01:32PM +0700, Bagas Sanjaya wrote:
> On Fri, Oct 14, 2022 at 03:48:10PM +0800, Xianting Tian wrote:
> > The following interrelated definitions and ranges are needed by the kdump
> > crash tool, they are exported by "arch/riscv/kernel/crash_core.c":
> > VA_BITS,
> > PAGE_OFFSET,
> > phys_ram_base,
> > MODULES_VADDR ~ MODULES_END,
> > VMALLOC_START ~ VMALLOC_END,
> > VMEMMAP_START ~ VMEMMAP_END,
> > KASAN_SHADOW_START ~ KASAN_SHADOW_END,
> > KERNEL_LINK_ADDR ~ ADDRESS_SPACE_END
> >
> > Document these RISCV64 exports above.
> >
>
> The patch description LGTM, thanks.
>
> > +----------------------------------------------------------------------------------------------------------------------------------------------------
> > +MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
> > +----------------------------------------------------------------------------------------------------------------------------------------------------
>
> The overline above header text is unnecessary, so I have to strip it:
>
> ---- >8 ----
>
> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> index 6c7a1728de220e..8e2e164cf3db49 100644
> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst
> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> @@ -615,7 +615,6 @@ phys_ram_base
>
> Indicates the start physical RAM address.
>
> -----------------------------------------------------------------------------------------------------------------------------------------------------
> MODULES_VADDR|MODULES_END|VMALLOC_START|VMALLOC_END|VMEMMAP_START|VMEMMAP_END|KASAN_SHADOW_START|KASAN_SHADOW_END|KERNEL_LINK_ADDR|ADDRESS_SPACE_END
> ----------------------------------------------------------------------------------------------------------------------------------------------------
Without whitespace highlighting, your change threw me for a sec.. But
yeah, having the overline is inconsistent with other headings in the
doc.
What I wanted to ask about was the linelength as I don't know anything
about rst. Is it possible to avoid having the ~150 character line or is
that a necessary evil?
Thanks,
Conor.
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-10-14 13:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 7:48 [PATCH 0/2] Support VMCOREINFO export for RISCV64 Xianting Tian
2022-10-14 7:48 ` Xianting Tian
2022-10-14 7:48 ` Xianting Tian
2022-10-14 7:48 ` [PATCH 1/2] RISC-V: Add arch_crash_save_vmcoreinfo support Xianting Tian
2022-10-14 7:48 ` Xianting Tian
2022-10-14 7:48 ` Xianting Tian
2022-10-14 7:48 ` [PATCH 2/2] Documentation: kdump: describe VMCOREINFO export for RISCV64 Xianting Tian
2022-10-14 7:48 ` Xianting Tian
2022-10-14 7:48 ` Xianting Tian
2022-10-14 13:01 ` Bagas Sanjaya
2022-10-14 13:01 ` Bagas Sanjaya
2022-10-14 13:01 ` Bagas Sanjaya
2022-10-14 13:10 ` Conor Dooley [this message]
2022-10-14 13:10 ` Conor Dooley
2022-10-14 13:10 ` Conor Dooley
2022-10-14 13:23 ` Bagas Sanjaya
2022-10-14 13:23 ` Bagas Sanjaya
2022-10-14 13:23 ` Bagas Sanjaya
2022-10-14 13:44 ` Xianting Tian
2022-10-14 13:44 ` Xianting Tian
2022-10-14 13:44 ` Xianting Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0lfuixXue4k4poY@spud \
--to=conor@kernel.org \
--cc=Conor.Dooley@microchip.com \
--cc=alexandre.ghiti@canonical.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=bagasdotme@gmail.com \
--cc=bhe@redhat.com \
--cc=corbet@lwn.net \
--cc=crash-utility@redhat.com \
--cc=dyoung@redhat.com \
--cc=guoren@kernel.org \
--cc=heiko@sntech.de \
--cc=heinrich.schuchardt@canonical.com \
--cc=hschauhan@nulltrace.org \
--cc=k-hagio-ab@nec.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mick@ics.forth.gr \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=vgoyal@redhat.com \
--cc=xianting.tian@linux.alibaba.com \
--cc=yixun.lan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.