All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Koller <ricarkol@google.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, maz@kernel.org, bgardon@google.com,
	andrew.jones@linux.dev, kvmarm@lists.linux.dev,
	pbonzini@redhat.com, axelrasmussen@google.com,
	kvmarm@lists.cs.columbia.edu, dmatlack@google.com
Subject: Re: [PATCH v9 00/14] KVM: selftests: Add aarch64/page_fault_test
Date: Fri, 14 Oct 2022 14:37:34 -0700	[thread overview]
Message-ID: <Y0nWnr7GaPbBfLtf@google.com> (raw)
In-Reply-To: <Y0nU4vIIyjfQuQGV@google.com>

On Fri, Oct 14, 2022 at 09:30:10PM +0000, Sean Christopherson wrote:
> On Tue, Oct 11, 2022, Ricardo Koller wrote:
> > Ricardo Koller (14):
> >   KVM: selftests: Add a userfaultfd library
> >   KVM: selftests: aarch64: Add virt_get_pte_hva() library function
> >   KVM: selftests: Add missing close and munmap in
> >     __vm_mem_region_delete()
> >   KVM: selftests: aarch64: Construct DEFAULT_MAIR_EL1 using sysreg.h
> >     macros
> >   tools: Copy bitfield.h from the kernel sources
> >   KVM: selftests: Stash backing_src_type in struct userspace_mem_region
> >   KVM: selftests: Add vm->memslots[] and enum kvm_mem_region_type
> >   KVM: selftests: Fix alignment in virt_arch_pgd_alloc() and
> >     vm_vaddr_alloc()
> >   KVM: selftests: Use the right memslot for code, page-tables, and data
> >     allocations
> >   KVM: selftests: aarch64: Add aarch64/page_fault_test
> >   KVM: selftests: aarch64: Add userfaultfd tests into page_fault_test
> >   KVM: selftests: aarch64: Add dirty logging tests into page_fault_test
> >   KVM: selftests: aarch64: Add readonly memslot tests into
> >     page_fault_test
> >   KVM: selftests: aarch64: Add mix of tests into page_fault_test
> 
> A bunch of nits, mostly about alignment/indentation, but otherwise no more whining
> on my end.  A v10 would probably be nice to avoid churn?  But I'm also ok if y'all
> want to merge this asap and do the cleanup on top.

No prob, will send a v10 (most likely on Monday).

Thanks!
Ricardo
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Ricardo Koller <ricarkol@google.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev,
	kvmarm@lists.cs.columbia.edu, andrew.jones@linux.dev,
	pbonzini@redhat.com, maz@kernel.org, alexandru.elisei@arm.com,
	eric.auger@redhat.com, oupton@google.com, reijiw@google.com,
	rananta@google.com, bgardon@google.com, dmatlack@google.com,
	axelrasmussen@google.com
Subject: Re: [PATCH v9 00/14] KVM: selftests: Add aarch64/page_fault_test
Date: Fri, 14 Oct 2022 14:37:34 -0700	[thread overview]
Message-ID: <Y0nWnr7GaPbBfLtf@google.com> (raw)
Message-ID: <20221014213734.RNT-8LXDefwMRZ_U-K3jq9qqY2wb2CP7v1v1ydLJyhU@z> (raw)
In-Reply-To: <Y0nU4vIIyjfQuQGV@google.com>

On Fri, Oct 14, 2022 at 09:30:10PM +0000, Sean Christopherson wrote:
> On Tue, Oct 11, 2022, Ricardo Koller wrote:
> > Ricardo Koller (14):
> >   KVM: selftests: Add a userfaultfd library
> >   KVM: selftests: aarch64: Add virt_get_pte_hva() library function
> >   KVM: selftests: Add missing close and munmap in
> >     __vm_mem_region_delete()
> >   KVM: selftests: aarch64: Construct DEFAULT_MAIR_EL1 using sysreg.h
> >     macros
> >   tools: Copy bitfield.h from the kernel sources
> >   KVM: selftests: Stash backing_src_type in struct userspace_mem_region
> >   KVM: selftests: Add vm->memslots[] and enum kvm_mem_region_type
> >   KVM: selftests: Fix alignment in virt_arch_pgd_alloc() and
> >     vm_vaddr_alloc()
> >   KVM: selftests: Use the right memslot for code, page-tables, and data
> >     allocations
> >   KVM: selftests: aarch64: Add aarch64/page_fault_test
> >   KVM: selftests: aarch64: Add userfaultfd tests into page_fault_test
> >   KVM: selftests: aarch64: Add dirty logging tests into page_fault_test
> >   KVM: selftests: aarch64: Add readonly memslot tests into
> >     page_fault_test
> >   KVM: selftests: aarch64: Add mix of tests into page_fault_test
> 
> A bunch of nits, mostly about alignment/indentation, but otherwise no more whining
> on my end.  A v10 would probably be nice to avoid churn?  But I'm also ok if y'all
> want to merge this asap and do the cleanup on top.

No prob, will send a v10 (most likely on Monday).

Thanks!
Ricardo

  reply	other threads:[~2022-10-14 21:37 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  1:06 [PATCH v9 00/14] KVM: selftests: Add aarch64/page_fault_test Ricardo Koller
2022-10-11  1:06 ` Ricardo Koller
2022-10-11  1:06 ` [PATCH v9 01/14] KVM: selftests: Add a userfaultfd library Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-14 21:15   ` Sean Christopherson
2022-10-14 21:15     ` Sean Christopherson
2022-10-11  1:06 ` [PATCH v9 02/14] KVM: selftests: aarch64: Add virt_get_pte_hva() library function Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-11  1:06 ` [PATCH v9 03/14] KVM: selftests: Add missing close and munmap in __vm_mem_region_delete() Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-11  1:06 ` [PATCH v9 04/14] KVM: selftests: aarch64: Construct DEFAULT_MAIR_EL1 using sysreg.h macros Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-11  1:06 ` [PATCH v9 05/14] tools: Copy bitfield.h from the kernel sources Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-11  1:06 ` [PATCH v9 06/14] KVM: selftests: Stash backing_src_type in struct userspace_mem_region Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-11  1:06 ` [PATCH v9 07/14] KVM: selftests: Add vm->memslots[] and enum kvm_mem_region_type Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-11  1:06 ` [PATCH v9 08/14] KVM: selftests: Fix alignment in virt_arch_pgd_alloc() and vm_vaddr_alloc() Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-13 14:09   ` Andrew Jones
2022-10-13 14:09     ` Andrew Jones
2022-10-11  1:06 ` [PATCH v9 09/14] KVM: selftests: Use the right memslot for code, page-tables, and data allocations Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-13 14:14   ` Andrew Jones
2022-10-13 14:14     ` Andrew Jones
2022-10-11  1:06 ` [PATCH v9 10/14] KVM: selftests: aarch64: Add aarch64/page_fault_test Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-14 21:23   ` Sean Christopherson
2022-10-14 21:23     ` Sean Christopherson
2022-10-11  1:06 ` [PATCH v9 11/14] KVM: selftests: aarch64: Add userfaultfd tests into page_fault_test Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-14 21:27   ` Sean Christopherson
2022-10-14 21:27     ` Sean Christopherson
2022-10-11  1:06 ` [PATCH v9 12/14] KVM: selftests: aarch64: Add dirty logging " Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-14 21:28   ` Sean Christopherson
2022-10-14 21:28     ` Sean Christopherson
2022-10-11  1:06 ` [PATCH v9 13/14] KVM: selftests: aarch64: Add readonly memslot " Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-11  1:06 ` [PATCH v9 14/14] KVM: selftests: aarch64: Add mix of " Ricardo Koller
2022-10-11  1:06   ` Ricardo Koller
2022-10-14 21:30 ` [PATCH v9 00/14] KVM: selftests: Add aarch64/page_fault_test Sean Christopherson
2022-10-14 21:30   ` Sean Christopherson
2022-10-14 21:37   ` Ricardo Koller [this message]
2022-10-14 21:37     ` Ricardo Koller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0nWnr7GaPbBfLtf@google.com \
    --to=ricarkol@google.com \
    --cc=andrew.jones@linux.dev \
    --cc=axelrasmussen@google.com \
    --cc=bgardon@google.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=kvmarm@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.