From: William Breathitt Gray <william.gray@linaro.org>
To: kamel.bouhara@bootlin.com
Cc: linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org
Subject: Handling Signal1 in microchip-tcb-capture
Date: Sat, 15 Oct 2022 09:52:27 -0400 [thread overview]
Message-ID: <Y0q7Gzh95nFdqdYK@fedora> (raw)
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
Hello Kamel,
I was looking over the microchip-tcb-capture driver recently and noticed
that the code doesn't seem to account for Signal1. In particular, it
appears that mchp_tc_count_signal_read() and mchp_tc_count_action_read()
don't check the Signal id at all and just assume they are handling
Signal0. This creates a situation where the information returned for the
Signal1 sysfs attributes are just duplicated reports of Signal0.
What exactly is the relationship of Signal0 ("Channel A") and Signal1
("Channel B"); is SignalB only relevant when the counter device is
configured for quadrature mode?
Sincerely,
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: William Breathitt Gray <william.gray@linaro.org>
To: kamel.bouhara@bootlin.com
Cc: linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org
Subject: Handling Signal1 in microchip-tcb-capture
Date: Sat, 15 Oct 2022 09:52:27 -0400 [thread overview]
Message-ID: <Y0q7Gzh95nFdqdYK@fedora> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 640 bytes --]
Hello Kamel,
I was looking over the microchip-tcb-capture driver recently and noticed
that the code doesn't seem to account for Signal1. In particular, it
appears that mchp_tc_count_signal_read() and mchp_tc_count_action_read()
don't check the Signal id at all and just assume they are handling
Signal0. This creates a situation where the information returned for the
Signal1 sysfs attributes are just duplicated reports of Signal0.
What exactly is the relationship of Signal0 ("Channel A") and Signal1
("Channel B"); is SignalB only relevant when the counter device is
configured for quadrature mode?
Sincerely,
William Breathitt Gray
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-10-15 13:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 13:52 William Breathitt Gray [this message]
2022-10-15 13:52 ` Handling Signal1 in microchip-tcb-capture William Breathitt Gray
2022-10-17 9:59 ` Kamel Bouhara
2022-10-17 9:59 ` Kamel Bouhara
2022-10-17 12:53 ` William Breathitt Gray
2022-10-17 12:53 ` William Breathitt Gray
2022-10-17 17:06 ` Kamel Bouhara
2022-10-17 17:06 ` Kamel Bouhara
2022-10-17 21:57 ` William Breathitt Gray
2022-10-17 21:57 ` William Breathitt Gray
2022-10-18 8:01 ` Kamel Bouhara
2022-10-18 8:01 ` Kamel Bouhara
2022-10-18 11:47 ` William Breathitt Gray
2022-10-18 11:47 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0q7Gzh95nFdqdYK@fedora \
--to=william.gray@linaro.org \
--cc=kamel.bouhara@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.