drivers/platform/x86/amd/pmc.c compile error in 6.0.6

drivers/platform/x86/amd/pmc.c compile error in 6.0.6

[Jaak Ristioja]

Hello,

The following error popped up when compiling Linux kernel version 6.0.6:

drivers/platform/x86/amd/pmc.c: In function 'amd_pmc_verify_czn_rtc':
drivers/platform/x86/amd/pmc.c:640:22: error: implicit declaration of 
function 'amd_pmc_get_smu_version' [-Werror=implicit-function-declaration]
   640 |                 rc = amd_pmc_get_smu_version(pdev);
       |                      ^~~~~~~~~~~~~~~~~~~~~~~

This function call was introduced backported with commit e9847175b266 
with the subject line "platform/x86/amd: pmc: Read SMU version during 
suspend on Cezanne systems".

Please note that amd_pmc_get_smu_version() is defined in an #ifdef 
CONFIG_DEBUG_FS block, but the new function call is compiled regardless 
of CONFIG_DEBUG_FS, causing the aforementioned error when building 
without the Debug Filesystem.


Best regards,
Jaak Ristioja

Re: drivers/platform/x86/amd/pmc.c compile error in 6.0.6

[Greg Kroah-Hartman]

On Sun, Oct 30, 2022 at 01:51:59AM +0300, Jaak Ristioja wrote:
> Hello,
> 
> The following error popped up when compiling Linux kernel version 6.0.6:
> 
> drivers/platform/x86/amd/pmc.c: In function 'amd_pmc_verify_czn_rtc':
> drivers/platform/x86/amd/pmc.c:640:22: error: implicit declaration of
> function 'amd_pmc_get_smu_version' [-Werror=implicit-function-declaration]
>   640 |                 rc = amd_pmc_get_smu_version(pdev);
>       |                      ^~~~~~~~~~~~~~~~~~~~~~~
> 
> This function call was introduced backported with commit e9847175b266 with
> the subject line "platform/x86/amd: pmc: Read SMU version during suspend on
> Cezanne systems".
> 
> Please note that amd_pmc_get_smu_version() is defined in an #ifdef
> CONFIG_DEBUG_FS block, but the new function call is compiled regardless of
> CONFIG_DEBUG_FS, causing the aforementioned error when building without the
> Debug Filesystem.

Ah, good catch.  Is this issue also there in Linus's tree?  If not, any
hint on what commit fixed it?

thanks,

greg k-h

Re: drivers/platform/x86/amd/pmc.c compile error in 6.0.6

[Jaak Ristioja]

On 30.10.22 09:23, Greg Kroah-Hartman wrote:
> On Sun, Oct 30, 2022 at 01:51:59AM +0300, Jaak Ristioja wrote:
>> Hello,
>>
>> The following error popped up when compiling Linux kernel version 6.0.6:
>>
>> drivers/platform/x86/amd/pmc.c: In function 'amd_pmc_verify_czn_rtc':
>> drivers/platform/x86/amd/pmc.c:640:22: error: implicit declaration of
>> function 'amd_pmc_get_smu_version' [-Werror=implicit-function-declaration]
>>    640 |                 rc = amd_pmc_get_smu_version(pdev);
>>        |                      ^~~~~~~~~~~~~~~~~~~~~~~
>>
>> This function call was introduced backported with commit e9847175b266 with
>> the subject line "platform/x86/amd: pmc: Read SMU version during suspend on
>> Cezanne systems".
>>
>> Please note that amd_pmc_get_smu_version() is defined in an #ifdef
>> CONFIG_DEBUG_FS block, but the new function call is compiled regardless of
>> CONFIG_DEBUG_FS, causing the aforementioned error when building without the
>> Debug Filesystem.
> 
> Ah, good catch.  Is this issue also there in Linus's tree?  If not, any
> hint on what commit fixed it?

It looks like applying commit b37fe34c8309 titled "platform/x86/amd: 
pmc: remove CONFIG_DEBUG_FS checks" fixes the compile error. Hope it 
helps :)

Jaak Ristioja

Re: drivers/platform/x86/amd/pmc.c compile error in 6.0.6

[Greg Kroah-Hartman]

On Sun, Oct 30, 2022 at 03:44:55PM +0200, Jaak Ristioja wrote:
> On 30.10.22 09:23, Greg Kroah-Hartman wrote:
> > On Sun, Oct 30, 2022 at 01:51:59AM +0300, Jaak Ristioja wrote:
> > > Hello,
> > > 
> > > The following error popped up when compiling Linux kernel version 6.0.6:
> > > 
> > > drivers/platform/x86/amd/pmc.c: In function 'amd_pmc_verify_czn_rtc':
> > > drivers/platform/x86/amd/pmc.c:640:22: error: implicit declaration of
> > > function 'amd_pmc_get_smu_version' [-Werror=implicit-function-declaration]
> > >    640 |                 rc = amd_pmc_get_smu_version(pdev);
> > >        |                      ^~~~~~~~~~~~~~~~~~~~~~~
> > > 
> > > This function call was introduced backported with commit e9847175b266 with
> > > the subject line "platform/x86/amd: pmc: Read SMU version during suspend on
> > > Cezanne systems".
> > > 
> > > Please note that amd_pmc_get_smu_version() is defined in an #ifdef
> > > CONFIG_DEBUG_FS block, but the new function call is compiled regardless of
> > > CONFIG_DEBUG_FS, causing the aforementioned error when building without the
> > > Debug Filesystem.
> > 
> > Ah, good catch.  Is this issue also there in Linus's tree?  If not, any
> > hint on what commit fixed it?
> 
> It looks like applying commit b37fe34c8309 titled "platform/x86/amd: pmc:
> remove CONFIG_DEBUG_FS checks" fixes the compile error. Hope it helps :)

Thanks a lot, that does help.  Patch is now queued up.

greg k-h