All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	David Hildenbrand <david@redhat.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
	Naoya Horiguchi <naoya.horiguchi@linux.dev>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Muchun Song <songmuchun@bytedance.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4] hugetlb: simplify hugetlb handling in follow_page_mask
Date: Sun, 30 Oct 2022 22:54:04 +0000	[thread overview]
Message-ID: <Y18B9yYTAqrQ9Zvu@monkey> (raw)
In-Reply-To: <Y17UPk9CBjPumcz6@x1n>

On 10/30/22 15:45, Peter Xu wrote:
> On Fri, Oct 28, 2022 at 11:11:08AM -0700, Mike Kravetz wrote:
> > +	} else {
> > +		if (is_hugetlb_entry_migration(entry)) {
> > +			spin_unlock(ptl);
> > +			hugetlb_vma_unlock_read(vma);
> 
> Just noticed it when pulled the last mm-unstable: this line seems to be a
> left-over of v3, while not needed now?
> 
> > +			__migration_entry_wait_huge(pte, ptl);
> > +			goto retry;
> > +		}

Thanks Peter!

Sent v5 with the that line removed.

-- 
Mike Kravetz

WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Peter Xu <peterx@redhat.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>,
	linux-ia64@vger.kernel.org, David Hildenbrand <david@redhat.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
	Muchun Song <songmuchun@bytedance.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4] hugetlb: simplify hugetlb handling in follow_page_mask
Date: Sun, 30 Oct 2022 16:00:07 -0700	[thread overview]
Message-ID: <Y18B9yYTAqrQ9Zvu@monkey> (raw)
In-Reply-To: <Y17UPk9CBjPumcz6@x1n>

On 10/30/22 15:45, Peter Xu wrote:
> On Fri, Oct 28, 2022 at 11:11:08AM -0700, Mike Kravetz wrote:
> > +	} else {
> > +		if (is_hugetlb_entry_migration(entry)) {
> > +			spin_unlock(ptl);
> > +			hugetlb_vma_unlock_read(vma);
> 
> Just noticed it when pulled the last mm-unstable: this line seems to be a
> left-over of v3, while not needed now?
> 
> > +			__migration_entry_wait_huge(pte, ptl);
> > +			goto retry;
> > +		}

Thanks Peter!

Sent v5 with the that line removed.

-- 
Mike Kravetz

WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	David Hildenbrand <david@redhat.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
	Naoya Horiguchi <naoya.horiguchi@linux.dev>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Muchun Song <songmuchun@bytedance.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v4] hugetlb: simplify hugetlb handling in follow_page_mask
Date: Sun, 30 Oct 2022 16:00:07 -0700	[thread overview]
Message-ID: <Y18B9yYTAqrQ9Zvu@monkey> (raw)
In-Reply-To: <Y17UPk9CBjPumcz6@x1n>

On 10/30/22 15:45, Peter Xu wrote:
> On Fri, Oct 28, 2022 at 11:11:08AM -0700, Mike Kravetz wrote:
> > +	} else {
> > +		if (is_hugetlb_entry_migration(entry)) {
> > +			spin_unlock(ptl);
> > +			hugetlb_vma_unlock_read(vma);
> 
> Just noticed it when pulled the last mm-unstable: this line seems to be a
> left-over of v3, while not needed now?
> 
> > +			__migration_entry_wait_huge(pte, ptl);
> > +			goto retry;
> > +		}

Thanks Peter!

Sent v5 with the that line removed.

-- 
Mike Kravetz


  reply	other threads:[~2022-10-30 22:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-28 18:11 [PATCH v4] hugetlb: simplify hugetlb handling in follow_page_mask Mike Kravetz
2022-10-28 18:11 ` Mike Kravetz
2022-10-28 18:11 ` Mike Kravetz
2022-10-28 23:24 ` Peter Xu
2022-10-28 23:24   ` Peter Xu
2022-10-28 23:24   ` Peter Xu
2022-10-30 19:45 ` Peter Xu
2022-10-30 19:45   ` Peter Xu
2022-10-30 19:45   ` Peter Xu
2022-10-30 22:54   ` Mike Kravetz [this message]
2022-10-30 23:00     ` Mike Kravetz
2022-10-30 23:00     ` Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y18B9yYTAqrQ9Zvu@monkey \
    --to=mike.kravetz@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=david@redhat.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=naoya.horiguchi@linux.dev \
    --cc=peterx@redhat.com \
    --cc=songmuchun@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.