All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Ricardo Koller <ricarkol@google.com>
Cc: kvm@vger.kernel.org, maz@kernel.org, bgardon@google.com,
	andrew.jones@linux.dev, kvmarm@lists.linux.dev,
	pbonzini@redhat.com, axelrasmussen@google.com,
	kvmarm@lists.cs.columbia.edu, dmatlack@google.com
Subject: Re: [PATCH v10 01/14] KVM: selftests: Add a userfaultfd library
Date: Wed, 19 Oct 2022 23:39:45 +0000	[thread overview]
Message-ID: <Y1CKwZG3jBz7mOvj@google.com> (raw)
In-Reply-To: <20221017195834.2295901-2-ricarkol@google.com>

On Mon, Oct 17, 2022, Ricardo Koller wrote:
> diff --git a/tools/testing/selftests/kvm/demand_paging_test.c b/tools/testing/selftests/kvm/demand_paging_test.c
> index 779ae54f89c4..8e1fe4ffcccd 100644
> --- a/tools/testing/selftests/kvm/demand_paging_test.c
> +++ b/tools/testing/selftests/kvm/demand_paging_test.c
> @@ -22,23 +22,13 @@
>  #include "test_util.h"
>  #include "perf_test_util.h"
>  #include "guest_modes.h"
> +#include "userfaultfd_util.h"
>  
>  #ifdef __NR_userfaultfd
>  
> -#ifdef PRINT_PER_PAGE_UPDATES
> -#define PER_PAGE_DEBUG(...) printf(__VA_ARGS__)
> -#else
> -#define PER_PAGE_DEBUG(...) _no_printf(__VA_ARGS__)
> -#endif
> -
> -#ifdef PRINT_PER_VCPU_UPDATES
> -#define PER_VCPU_DEBUG(...) printf(__VA_ARGS__)
> -#else
> -#define PER_VCPU_DEBUG(...) _no_printf(__VA_ARGS__)
> -#endif
> -
>  static int nr_vcpus = 1;
>  static uint64_t guest_percpu_mem_size = DEFAULT_PER_VCPU_MEM_SIZE;
> +
>  static size_t demand_paging_size;
>  static char *guest_data_prototype;
>  
> @@ -67,9 +57,11 @@ static void vcpu_worker(struct perf_test_vcpu_args *vcpu_args)
>  		       ts_diff.tv_sec, ts_diff.tv_nsec);
>  }
>  
> -static int handle_uffd_page_request(int uffd_mode, int uffd, uint64_t addr)
> +static int handle_uffd_page_request(int uffd_mode, int uffd,
> +		struct uffd_msg *msg)

Heh, one last alignment goof.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Ricardo Koller <ricarkol@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev,
	kvmarm@lists.cs.columbia.edu, andrew.jones@linux.dev,
	pbonzini@redhat.com, maz@kernel.org, alexandru.elisei@arm.com,
	eric.auger@redhat.com, oupton@google.com, reijiw@google.com,
	rananta@google.com, bgardon@google.com, dmatlack@google.com,
	axelrasmussen@google.com, Oliver Upton <oliver.upton@linux.dev>
Subject: Re: [PATCH v10 01/14] KVM: selftests: Add a userfaultfd library
Date: Wed, 19 Oct 2022 23:39:45 +0000	[thread overview]
Message-ID: <Y1CKwZG3jBz7mOvj@google.com> (raw)
Message-ID: <20221019233945.9iXQMwnu8h863Vl7X2yfdkqkLQV7xjaHegloTr9M-pY@z> (raw)
In-Reply-To: <20221017195834.2295901-2-ricarkol@google.com>

On Mon, Oct 17, 2022, Ricardo Koller wrote:
> diff --git a/tools/testing/selftests/kvm/demand_paging_test.c b/tools/testing/selftests/kvm/demand_paging_test.c
> index 779ae54f89c4..8e1fe4ffcccd 100644
> --- a/tools/testing/selftests/kvm/demand_paging_test.c
> +++ b/tools/testing/selftests/kvm/demand_paging_test.c
> @@ -22,23 +22,13 @@
>  #include "test_util.h"
>  #include "perf_test_util.h"
>  #include "guest_modes.h"
> +#include "userfaultfd_util.h"
>  
>  #ifdef __NR_userfaultfd
>  
> -#ifdef PRINT_PER_PAGE_UPDATES
> -#define PER_PAGE_DEBUG(...) printf(__VA_ARGS__)
> -#else
> -#define PER_PAGE_DEBUG(...) _no_printf(__VA_ARGS__)
> -#endif
> -
> -#ifdef PRINT_PER_VCPU_UPDATES
> -#define PER_VCPU_DEBUG(...) printf(__VA_ARGS__)
> -#else
> -#define PER_VCPU_DEBUG(...) _no_printf(__VA_ARGS__)
> -#endif
> -
>  static int nr_vcpus = 1;
>  static uint64_t guest_percpu_mem_size = DEFAULT_PER_VCPU_MEM_SIZE;
> +
>  static size_t demand_paging_size;
>  static char *guest_data_prototype;
>  
> @@ -67,9 +57,11 @@ static void vcpu_worker(struct perf_test_vcpu_args *vcpu_args)
>  		       ts_diff.tv_sec, ts_diff.tv_nsec);
>  }
>  
> -static int handle_uffd_page_request(int uffd_mode, int uffd, uint64_t addr)
> +static int handle_uffd_page_request(int uffd_mode, int uffd,
> +		struct uffd_msg *msg)

Heh, one last alignment goof.

  reply	other threads:[~2022-10-19 23:39 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 19:58 [PATCH v10 00/14] KVM: selftests: Add aarch64/page_fault_test Ricardo Koller
2022-10-17 19:58 ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 01/14] KVM: selftests: Add a userfaultfd library Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-19 23:39   ` Sean Christopherson [this message]
2022-10-19 23:39     ` Sean Christopherson
2022-10-17 19:58 ` [PATCH v10 02/14] KVM: selftests: aarch64: Add virt_get_pte_hva() library function Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 03/14] KVM: selftests: Add missing close and munmap in __vm_mem_region_delete() Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 04/14] KVM: selftests: aarch64: Construct DEFAULT_MAIR_EL1 using sysreg.h macros Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 05/14] tools: Copy bitfield.h from the kernel sources Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 06/14] KVM: selftests: Stash backing_src_type in struct userspace_mem_region Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 07/14] KVM: selftests: Add vm->memslots[] and enum kvm_mem_region_type Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 08/14] KVM: selftests: Fix alignment in virt_arch_pgd_alloc() and vm_vaddr_alloc() Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 09/14] KVM: selftests: Use the right memslot for code, page-tables, and data allocations Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 10/14] KVM: selftests: aarch64: Add aarch64/page_fault_test Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 11/14] KVM: selftests: aarch64: Add userfaultfd tests into page_fault_test Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 12/14] KVM: selftests: aarch64: Add dirty logging " Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 13/14] KVM: selftests: aarch64: Add readonly memslot " Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-17 19:58 ` [PATCH v10 14/14] KVM: selftests: aarch64: Add mix of " Ricardo Koller
2022-10-17 19:58   ` Ricardo Koller
2022-10-19 23:47 ` [PATCH v10 00/14] KVM: selftests: Add aarch64/page_fault_test Sean Christopherson
2022-10-19 23:47   ` Sean Christopherson
2022-11-10 19:13 ` Marc Zyngier
2022-11-10 19:13   ` Marc Zyngier
2023-02-03 14:49 ` Mark Brown
2023-02-03 15:36   ` Ricardo Koller
2023-02-03 17:27     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1CKwZG3jBz7mOvj@google.com \
    --to=seanjc@google.com \
    --cc=andrew.jones@linux.dev \
    --cc=axelrasmussen@google.com \
    --cc=bgardon@google.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=kvmarm@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=ricarkol@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.