From: Eric Biggers <ebiggers@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: amd-gfx@lists.freedesktop.org, guchun.chen@amd.com,
airlied@linux.ie, contact@emersion.fr,
dri-devel@lists.freedesktop.org, Xinhui.Pan@amd.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
aurabindo.pillai@amd.com, seanpaul@chromium.org,
Hamza Mahfooz <hamza.mahfooz@amd.com>,
daniel@ffwll.ch, Alex Deucher <alexander.deucher@amd.com>,
evan.quan@amd.com, christian.koenig@amd.com, greenfoo@u92.eu
Subject: Re: [PATCH AUTOSEL 5.19 07/16] drm/amdgpu: use dirty framebuffer helper
Date: Wed, 19 Oct 2022 21:48:22 -0700 [thread overview]
Message-ID: <Y1DTFiP12ws04eOM@sol.localdomain> (raw)
In-Reply-To: <20220921155332.234913-7-sashal@kernel.org>
On Wed, Sep 21, 2022 at 11:53:23AM -0400, Sasha Levin wrote:
> From: Hamza Mahfooz <hamza.mahfooz@amd.com>
>
> [ Upstream commit 66f99628eb24409cb8feb5061f78283c8b65f820 ]
>
> Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use
> drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs
> struct.
>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
I just spent a long time bisecting a hard-to-reproduce regression to this
commit, only to find that a revert was just queued this week.
Why was this commit backported to stable in the first place? It didn't have Cc
stable, and it didn't claim to be fixing anything.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Hamza Mahfooz <hamza.mahfooz@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
daniel@ffwll.ch, guchun.chen@amd.com, aurabindo.pillai@amd.com,
evan.quan@amd.com, seanpaul@chromium.org, contact@emersion.fr,
greenfoo@u92.eu, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH AUTOSEL 5.19 07/16] drm/amdgpu: use dirty framebuffer helper
Date: Wed, 19 Oct 2022 21:48:22 -0700 [thread overview]
Message-ID: <Y1DTFiP12ws04eOM@sol.localdomain> (raw)
In-Reply-To: <20220921155332.234913-7-sashal@kernel.org>
On Wed, Sep 21, 2022 at 11:53:23AM -0400, Sasha Levin wrote:
> From: Hamza Mahfooz <hamza.mahfooz@amd.com>
>
> [ Upstream commit 66f99628eb24409cb8feb5061f78283c8b65f820 ]
>
> Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use
> drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs
> struct.
>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
I just spent a long time bisecting a hard-to-reproduce regression to this
commit, only to find that a revert was just queued this week.
Why was this commit backported to stable in the first place? It didn't have Cc
stable, and it didn't claim to be fixing anything.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: amd-gfx@lists.freedesktop.org, guchun.chen@amd.com,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, aurabindo.pillai@amd.com,
seanpaul@chromium.org, Hamza Mahfooz <hamza.mahfooz@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
evan.quan@amd.com, christian.koenig@amd.com, greenfoo@u92.eu
Subject: Re: [PATCH AUTOSEL 5.19 07/16] drm/amdgpu: use dirty framebuffer helper
Date: Wed, 19 Oct 2022 21:48:22 -0700 [thread overview]
Message-ID: <Y1DTFiP12ws04eOM@sol.localdomain> (raw)
In-Reply-To: <20220921155332.234913-7-sashal@kernel.org>
On Wed, Sep 21, 2022 at 11:53:23AM -0400, Sasha Levin wrote:
> From: Hamza Mahfooz <hamza.mahfooz@amd.com>
>
> [ Upstream commit 66f99628eb24409cb8feb5061f78283c8b65f820 ]
>
> Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use
> drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs
> struct.
>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
I just spent a long time bisecting a hard-to-reproduce regression to this
commit, only to find that a revert was just queued this week.
Why was this commit backported to stable in the first place? It didn't have Cc
stable, and it didn't claim to be fixing anything.
- Eric
next prev parent reply other threads:[~2022-10-20 4:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 15:53 [PATCH AUTOSEL 5.19 01/16] Drivers: hv: Never allocate anything besides framebuffer from framebuffer memory region Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 02/16] drm/gma500: Fix BUG: sleeping function called from invalid context errors Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 03/16] drm/gma500: Fix WARN_ON(lock->magic != lock) error Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 04/16] drm/gma500: Fix (vblank) IRQs not working after suspend/resume Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 05/16] gpio: ixp4xx: Make irqchip immutable Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 06/16] drm/amd/pm: disable BACO entry/exit completely on several sienna cichlid cards Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 07/16] drm/amdgpu: use dirty framebuffer helper Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-10-20 4:48 ` Eric Biggers [this message]
2022-10-20 4:48 ` Eric Biggers
2022-10-20 4:48 ` Eric Biggers
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 08/16] drm/amdgpu: change the alignment size of TMR BO to 1M Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 09/16] drm/amdgpu: add HDP remap functionality to nbio 7.7 Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 10/16] drm/amdgpu: Skip reset error status for psp v13_0_0 Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 11/16] drm/amd/display: Limit user regamma to a valid value Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 12/16] drm/amd/display: Reduce number of arguments of dml31's CalculateWatermarksAndDRAMSpeedChangeSupport() Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 13/16] drm/amd/display: Reduce number of arguments of dml31's CalculateFlipSchedule() Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 14/16] drm/amd/display: Mark dml30's UseMinimumDCFCLK() as noinline for stack usage Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 15/16] drm/rockchip: Fix return type of cdn_dp_connector_mode_valid Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 15:53 ` [PATCH AUTOSEL 5.19 16/16] gpio: mt7621: Make the irqchip immutable Sasha Levin
2022-09-21 15:53 ` Sasha Levin
2022-09-21 16:17 ` [PATCH AUTOSEL 5.19 01/16] Drivers: hv: Never allocate anything besides framebuffer from framebuffer memory region Vitaly Kuznetsov
2022-09-25 3:18 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1DTFiP12ws04eOM@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=greenfoo@u92.eu \
--cc=guchun.chen@amd.com \
--cc=hamza.mahfooz@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=seanpaul@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.