From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-block@vger.kernel.org,
Shaomin Deng <dengshaomin@cdjrlc.com>,
Nikos Tsironis <ntsironis@arrikto.com>,
Mike Snitzer <snitzer@kernel.org>,
Nathan Huckleberry <nhuck@google.com>,
Christoph Hellwig <hch@infradead.org>,
dm-devel@redhat.com, Mikulas Patocka <mpatocka@redhat.com>,
Genjian Zhang <zhanggenjian@kylinos.cn>,
Jilin Yuan <yuanjilin@cdjrlc.com>,
Milan Broz <gmazyland@gmail.com>,
Alasdair G Kergon <agk@redhat.com>,
Jiangshan Yi <yijiangshan@kylinos.cn>
Subject: Re: [dm-devel] [git pull] device mapper changes for 6.1
Date: Thu, 20 Oct 2022 01:17:43 -0700 [thread overview]
Message-ID: <Y1EEJ6BEN2uOh8uj@infradead.org> (raw)
In-Reply-To: <CAHk-=wg3cpPyoO8u+8Fu1uk86bgTUYanfKhmxMsZzvY_mV=Cxw@mail.gmail.com>
On Tue, Oct 18, 2022 at 11:54:49AM -0700, Linus Torvalds wrote:
> I wouldn't worry about maintainer sign-offs just for exporting a
> helper function, but I agree with the whole concept being a complete
> disaster and not a good idea at all.
It's not just a a "helper", it is internal magic for KASAN and low-level
code patching. No driver has any business checking if something is a
module text/data address, and I'm fairly sure how they are using it is
actually wrong if DM is built in.
FYI, I also agree that the concept is a disaster as well.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jilin Yuan <yuanjilin@cdjrlc.com>,
Nikos Tsironis <ntsironis@arrikto.com>,
Shaomin Deng <dengshaomin@cdjrlc.com>,
Mike Snitzer <snitzer@kernel.org>,
Nathan Huckleberry <nhuck@google.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Mikulas Patocka <mpatocka@redhat.com>,
Genjian Zhang <zhanggenjian@kylinos.cn>,
Milan Broz <gmazyland@gmail.com>,
Alasdair G Kergon <agk@redhat.com>,
Jiangshan Yi <yijiangshan@kylinos.cn>
Subject: Re: [dm-devel] [git pull] device mapper changes for 6.1
Date: Thu, 20 Oct 2022 01:17:43 -0700 [thread overview]
Message-ID: <Y1EEJ6BEN2uOh8uj@infradead.org> (raw)
In-Reply-To: <CAHk-=wg3cpPyoO8u+8Fu1uk86bgTUYanfKhmxMsZzvY_mV=Cxw@mail.gmail.com>
On Tue, Oct 18, 2022 at 11:54:49AM -0700, Linus Torvalds wrote:
> I wouldn't worry about maintainer sign-offs just for exporting a
> helper function, but I agree with the whole concept being a complete
> disaster and not a good idea at all.
It's not just a a "helper", it is internal magic for KASAN and low-level
code patching. No driver has any business checking if something is a
module text/data address, and I'm fairly sure how they are using it is
actually wrong if DM is built in.
FYI, I also agree that the concept is a disaster as well.
next prev parent reply other threads:[~2022-10-20 8:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 16:20 [dm-devel] [git pull] device mapper changes for 6.1 Mike Snitzer
2022-10-18 16:20 ` Mike Snitzer
2022-10-18 18:17 ` [dm-devel] " Christoph Hellwig
2022-10-18 18:17 ` Christoph Hellwig
2022-10-18 18:48 ` [dm-devel] " Mike Snitzer
2022-10-18 18:48 ` Mike Snitzer
2022-10-20 8:16 ` [dm-devel] " Christoph Hellwig
2022-10-20 8:16 ` Christoph Hellwig
2022-10-20 11:44 ` Mikulas Patocka
2022-10-20 11:44 ` Mikulas Patocka
2022-10-18 18:54 ` Linus Torvalds
2022-10-18 18:54 ` Linus Torvalds
2022-10-18 19:19 ` [dm-devel] " Linus Torvalds
2022-10-18 19:19 ` Linus Torvalds
2022-10-18 21:13 ` [dm-devel] " Mike Snitzer
2022-10-18 21:13 ` Mike Snitzer
2022-10-18 22:11 ` [dm-devel] " Milan Broz
2022-10-18 22:11 ` Milan Broz
2022-10-18 22:18 ` [dm-devel] " Linus Torvalds
2022-10-18 22:18 ` Linus Torvalds
2022-10-18 20:28 ` [dm-devel] " Mikulas Patocka
2022-10-18 20:28 ` Mikulas Patocka
2022-10-18 22:17 ` [dm-devel] " Linus Torvalds
2022-10-18 22:17 ` Linus Torvalds
2022-10-19 6:18 ` [dm-devel] " Jason A. Donenfeld
2022-10-19 6:18 ` Jason A. Donenfeld
2022-10-20 8:17 ` Christoph Hellwig [this message]
2022-10-20 8:17 ` [dm-devel] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1EEJ6BEN2uOh8uj@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=dengshaomin@cdjrlc.com \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=nhuck@google.com \
--cc=ntsironis@arrikto.com \
--cc=snitzer@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yijiangshan@kylinos.cn \
--cc=yuanjilin@cdjrlc.com \
--cc=zhanggenjian@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.