* [PATCH 2/4] staging: rtl8192e: Update the TODO file for this driver
2022-10-16 11:07 [PATCH 1/4] staging: rtl8192u: Provide a TODO file for this driver Peter Robinson
@ 2022-10-16 11:07 ` Peter Robinson
2022-10-16 11:07 ` [PATCH 3/4] staging: ks7010: " Peter Robinson
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Peter Robinson @ 2022-10-16 11:07 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging; +Cc: Peter Robinson
The driver directory where it was proposed to move to has changed,
while add it add some more pieces this driver to update.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/staging/rtl8192e/TODO | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/TODO b/drivers/staging/rtl8192e/TODO
index d51f159d1adf..7221ae65d63e 100644
--- a/drivers/staging/rtl8192e/TODO
+++ b/drivers/staging/rtl8192e/TODO
@@ -1,2 +1,18 @@
-* merge into drivers/net/wireless/rtllib/rtl8192e
+To-do list:
+
+* merge into drivers/net/wireless/realtek/rtlwifi/rtl8192*
* clean up function naming
+* Correct the coding style according to Linux guidelines; please read the document
+ at https://www.kernel.org/doc/html/latest/process/coding-style.html.
+* Remove unnecessary debugging/printing macros; for those that are still needed
+ use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).
+* Remove dead code such as unusued functions, variables, fields, etc..
+* Use in-kernel API and remove unnecessary wrappers where possible.
+* Fix bugs due to code that sleeps in atomic context.
+* Remove the HAL layer and migrate its functionality into the relevant parts of
+ the driver.
+* Switch to use LIB80211.
+* Switch to use MAC80211.
+* Switch to use CFG80211.
+* Improve the error handling of various functions, particularly those that use
+ existing kernel APIs.
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] staging: ks7010: Update the TODO file for this driver
2022-10-16 11:07 [PATCH 1/4] staging: rtl8192u: Provide a TODO file for this driver Peter Robinson
2022-10-16 11:07 ` [PATCH 2/4] staging: rtl8192e: Update the " Peter Robinson
@ 2022-10-16 11:07 ` Peter Robinson
2022-10-16 11:07 ` [PATCH 4/4] staging: wlan-ng: Provide a " Peter Robinson
2022-10-20 15:49 ` [PATCH 1/4] staging: rtl8192u: " Greg Kroah-Hartman
3 siblings, 0 replies; 6+ messages in thread
From: Peter Robinson @ 2022-10-16 11:07 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging; +Cc: Peter Robinson
Add move to mac80211 from wext to the todo for this driver.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/staging/ks7010/TODO | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/ks7010/TODO b/drivers/staging/ks7010/TODO
index ab6f39175d99..80c97543b977 100644
--- a/drivers/staging/ks7010/TODO
+++ b/drivers/staging/ks7010/TODO
@@ -27,6 +27,9 @@ Now the TODOs:
- fix the 'card removal' event when card is inserted when booting
- check what other upstream wireless mechanisms can be used instead of the
custom ones here
+- Switch to use LIB80211.
+- Switch to use MAC80211.
+- Switch to use CFG80211.
Please send any patches to:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] staging: wlan-ng: Provide a TODO file for this driver
2022-10-16 11:07 [PATCH 1/4] staging: rtl8192u: Provide a TODO file for this driver Peter Robinson
2022-10-16 11:07 ` [PATCH 2/4] staging: rtl8192e: Update the " Peter Robinson
2022-10-16 11:07 ` [PATCH 3/4] staging: ks7010: " Peter Robinson
@ 2022-10-16 11:07 ` Peter Robinson
2022-10-20 15:49 ` [PATCH 1/4] staging: rtl8192u: " Greg Kroah-Hartman
3 siblings, 0 replies; 6+ messages in thread
From: Peter Robinson @ 2022-10-16 11:07 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging; +Cc: Peter Robinson
Provide a TODO file that lists the tasks that should be carried out in
order to move this driver off drivers/staging. It's missing from original
addition of this driver.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/staging/wlan-ng/TODO | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 drivers/staging/wlan-ng/TODO
diff --git a/drivers/staging/wlan-ng/TODO b/drivers/staging/wlan-ng/TODO
new file mode 100644
index 000000000000..ab9d5d145b3b
--- /dev/null
+++ b/drivers/staging/wlan-ng/TODO
@@ -0,0 +1,16 @@
+To-do list:
+
+* Correct the coding style according to Linux guidelines; please read the document
+ at https://www.kernel.org/doc/html/latest/process/coding-style.html.
+* Remove unnecessary debugging/printing macros; for those that are still needed
+ use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).
+* Remove dead code such as unusued functions, variables, fields, etc..
+* Use in-kernel API and remove unnecessary wrappers where possible.
+* Fix bugs due to code that sleeps in atomic context.
+* Remove the HAL layer and migrate its functionality into the relevant parts of
+ the driver.
+* Switch to use LIB80211.
+* Switch to use MAC80211.
+* Switch to use CFG80211.
+* Improve the error handling of various functions, particularly those that use
+ existing kernel APIs.
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/4] staging: rtl8192u: Provide a TODO file for this driver
2022-10-16 11:07 [PATCH 1/4] staging: rtl8192u: Provide a TODO file for this driver Peter Robinson
` (2 preceding siblings ...)
2022-10-16 11:07 ` [PATCH 4/4] staging: wlan-ng: Provide a " Peter Robinson
@ 2022-10-20 15:49 ` Greg Kroah-Hartman
2022-10-20 15:57 ` Peter Robinson
3 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-10-20 15:49 UTC (permalink / raw)
To: Peter Robinson; +Cc: linux-staging
On Sun, Oct 16, 2022 at 12:07:40PM +0100, Peter Robinson wrote:
> Provide a TODO file that lists the tasks that should be carried out in
> order to move this driver off drivers/staging. It's missing from original
> addition of this driver.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
> drivers/staging/rtl8192u/TODO | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 drivers/staging/rtl8192u/TODO
>
> diff --git a/drivers/staging/rtl8192u/TODO b/drivers/staging/rtl8192u/TODO
> new file mode 100644
> index 000000000000..ab9d5d145b3b
> --- /dev/null
> +++ b/drivers/staging/rtl8192u/TODO
> @@ -0,0 +1,16 @@
> +To-do list:
> +
> +* Correct the coding style according to Linux guidelines; please read the document
> + at https://www.kernel.org/doc/html/latest/process/coding-style.html.
> +* Remove unnecessary debugging/printing macros; for those that are still needed
> + use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).
> +* Remove dead code such as unusued functions, variables, fields, etc..
> +* Use in-kernel API and remove unnecessary wrappers where possible.
> +* Fix bugs due to code that sleeps in atomic context.
> +* Remove the HAL layer and migrate its functionality into the relevant parts of
> + the driver.
> +* Switch to use LIB80211.
> +* Switch to use MAC80211.
> +* Switch to use CFG80211.
> +* Improve the error handling of various functions, particularly those that use
> + existing kernel APIs.
Where did this list come from?
How do you know they are all needed?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/4] staging: rtl8192u: Provide a TODO file for this driver
2022-10-20 15:49 ` [PATCH 1/4] staging: rtl8192u: " Greg Kroah-Hartman
@ 2022-10-20 15:57 ` Peter Robinson
0 siblings, 0 replies; 6+ messages in thread
From: Peter Robinson @ 2022-10-20 15:57 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging
On Thu, Oct 20, 2022 at 4:49 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Sun, Oct 16, 2022 at 12:07:40PM +0100, Peter Robinson wrote:
> > Provide a TODO file that lists the tasks that should be carried out in
> > order to move this driver off drivers/staging. It's missing from original
> > addition of this driver.
> >
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > ---
> > drivers/staging/rtl8192u/TODO | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> > create mode 100644 drivers/staging/rtl8192u/TODO
> >
> > diff --git a/drivers/staging/rtl8192u/TODO b/drivers/staging/rtl8192u/TODO
> > new file mode 100644
> > index 000000000000..ab9d5d145b3b
> > --- /dev/null
> > +++ b/drivers/staging/rtl8192u/TODO
> > @@ -0,0 +1,16 @@
> > +To-do list:
> > +
> > +* Correct the coding style according to Linux guidelines; please read the document
> > + at https://www.kernel.org/doc/html/latest/process/coding-style.html.
> > +* Remove unnecessary debugging/printing macros; for those that are still needed
> > + use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()).
> > +* Remove dead code such as unusued functions, variables, fields, etc..
> > +* Use in-kernel API and remove unnecessary wrappers where possible.
> > +* Fix bugs due to code that sleeps in atomic context.
> > +* Remove the HAL layer and migrate its functionality into the relevant parts of
> > + the driver.
> > +* Switch to use LIB80211.
> > +* Switch to use MAC80211.
> > +* Switch to use CFG80211.
> > +* Improve the error handling of various functions, particularly those that use
> > + existing kernel APIs.
>
> Where did this list come from?
>
> How do you know they are all needed?
It was based on the other real tek drivers that has a todo and some grep.
^ permalink raw reply [flat|nested] 6+ messages in thread