All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Bin Meng <bin.meng@windriver.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v6 1/2] block: Ignore close() failure in get_tmp_filename()
Date: Fri, 21 Oct 2022 11:25:31 +0200	[thread overview]
Message-ID: <Y1Jli6J5de4wpSGK@redhat.com> (raw)
In-Reply-To: <20221010040432.3380478-1-bin.meng@windriver.com>

Am 10.10.2022 um 06:04 hat Bin Meng geschrieben:
> The temporary file has been created and is ready for use. Checking
> return value of close() does not seem useful. The file descriptor
> is almost certainly closed; see close(2) under "Dealing with error
> returns from close()".
> 
> Let's simply ignore close() failure here.
> 
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Thanks, series applied to the block branch.

Kevin



      parent reply	other threads:[~2022-10-21  9:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  4:04 [PATCH v6 1/2] block: Ignore close() failure in get_tmp_filename() Bin Meng
2022-10-10  4:04 ` [PATCH v6 2/2] block: Refactor get_tmp_filename() Bin Meng
2022-10-16 13:22   ` Bin Meng
2022-10-21  9:16   ` Kevin Wolf
2022-10-21  9:25 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1Jli6J5de4wpSGK@redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bin.meng@windriver.com \
    --cc=hreitz@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.