From: Mark Brown <broonie@kernel.org>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v1 1/2] ASoC: simple-card: Support custom DAI system clock IDs
Date: Mon, 24 Oct 2022 12:49:55 +0100 [thread overview]
Message-ID: <Y1Z74/vKHbnaCLrX@sirena.org.uk> (raw)
In-Reply-To: <20221022162742.21671-1-aidanmacdonald.0x0@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On Sat, Oct 22, 2022 at 05:27:41PM +0100, Aidan MacDonald wrote:
> Some DAIs have multiple system clock sources, which can be chosen
> using the "clk_id" argument to snd_soc_dai_set_sysclk(). Currently
> this is hardcoded to 0 when using simple cards, but that choice is
> not always suitable.
We already have clock bindings, if we need to configure clocks we should
be using those to configure there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
kuninori.morimoto.gx@renesas.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] ASoC: simple-card: Support custom DAI system clock IDs
Date: Mon, 24 Oct 2022 12:49:55 +0100 [thread overview]
Message-ID: <Y1Z74/vKHbnaCLrX@sirena.org.uk> (raw)
In-Reply-To: <20221022162742.21671-1-aidanmacdonald.0x0@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On Sat, Oct 22, 2022 at 05:27:41PM +0100, Aidan MacDonald wrote:
> Some DAIs have multiple system clock sources, which can be chosen
> using the "clk_id" argument to snd_soc_dai_set_sysclk(). Currently
> this is hardcoded to 0 when using simple cards, but that choice is
> not always suitable.
We already have clock bindings, if we need to configure clocks we should
be using those to configure there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-24 11:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 16:27 [PATCH v1 1/2] ASoC: simple-card: Support custom DAI system clock IDs Aidan MacDonald
2022-10-22 16:27 ` Aidan MacDonald
2022-10-22 16:27 ` [PATCH v1 2/2] dt-bindings: ASoC: simple-card: Add system-clock-id property Aidan MacDonald
2022-10-22 16:27 ` Aidan MacDonald
2022-10-23 13:08 ` Krzysztof Kozlowski
2022-10-23 13:08 ` Krzysztof Kozlowski
2022-10-23 13:47 ` Aidan MacDonald
2022-10-23 13:47 ` Aidan MacDonald
2022-10-24 20:46 ` Krzysztof Kozlowski
2022-10-24 20:46 ` Krzysztof Kozlowski
2022-10-24 23:38 ` Aidan MacDonald
2022-10-24 23:38 ` Aidan MacDonald
2022-10-25 0:00 ` Krzysztof Kozlowski
2022-10-25 0:00 ` Krzysztof Kozlowski
2022-10-25 9:14 ` Aidan MacDonald
2022-10-25 9:14 ` Aidan MacDonald
2022-10-25 12:19 ` Krzysztof Kozlowski
2022-10-25 12:19 ` Krzysztof Kozlowski
2022-10-26 14:48 ` Aidan MacDonald
2022-10-26 14:48 ` Aidan MacDonald
2022-10-26 15:03 ` Krzysztof Kozlowski
2022-10-26 15:03 ` Krzysztof Kozlowski
2022-10-26 19:27 ` Aidan MacDonald
2022-10-26 19:27 ` Aidan MacDonald
2022-10-26 15:05 ` Krzysztof Kozlowski
2022-10-26 15:05 ` Krzysztof Kozlowski
2022-10-23 23:54 ` [PATCH v1 1/2] ASoC: simple-card: Support custom DAI system clock IDs Kuninori Morimoto
2022-10-23 23:54 ` Kuninori Morimoto
2022-10-24 9:18 ` Aidan MacDonald
2022-10-24 9:18 ` Aidan MacDonald
2022-10-24 11:49 ` Mark Brown [this message]
2022-10-24 11:49 ` Mark Brown
2022-10-24 23:17 ` Aidan MacDonald
2022-10-24 23:17 ` Aidan MacDonald
2022-10-25 11:03 ` Mark Brown
2022-10-25 11:03 ` Mark Brown
2022-10-26 14:42 ` Aidan MacDonald
2022-10-26 14:42 ` Aidan MacDonald
2022-10-26 15:11 ` Mark Brown
2022-10-26 15:11 ` Mark Brown
2022-10-26 19:22 ` Aidan MacDonald
2022-10-26 19:22 ` Aidan MacDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1Z74/vKHbnaCLrX@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.