All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Sergiu.Moga@microchip.com
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
	Claudiu.Beznea@microchip.com, radu_nicolae.pirea@upb.ro,
	richard.genoud@gmail.com, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, Kavyasree.Kotagiri@microchip.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-serial@vger.kernel.org, krzysztof.kozlowski@linaro.org
Subject: Re: [PATCH v5 1/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding
Date: Mon, 24 Oct 2022 13:25:55 +0100	[thread overview]
Message-ID: <Y1aEU+k1lMOdSSR5@google.com> (raw)
In-Reply-To: <1d61596b-876b-2eca-f72d-ed38cc36f1a8@microchip.com>

On Wed, 28 Sep 2022, Sergiu.Moga@microchip.com wrote:

> On 28.09.2022 18:23, Lee Jones wrote:
> > On Wed, 28 Sep 2022, Sergiu.Moga@microchip.com wrote:
> > 
> >> On 28.09.2022 18:03, Lee Jones wrote:
> >>> On Thu, 22 Sep 2022, Sergiu Moga wrote:
> >>>
> >>>> Another functionality of FLEXCOM is that of SPI. In order for
> >>>> the proper validation of the SPI children nodes through the binding
> >>>> to occur, the proper binding for SPI must be referenced.
> >>>>
> >>>> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>>> ---
> >>>>
> >>>>
> >>>> v1 -> v2:
> >>>> - use full schema paths
> >>>>
> >>>>
> >>>> v2 -> v3:
> >>>> - Added Reviewed-by tag, previously this was [PATCH 3]
> >>>>
> >>>>
> >>>> v3 -> v4:
> >>>> - Nothing, previously this was [PATCH 5]
> >>>>
> >>>>
> >>>> v4 -> v5:
> >>>> - Nothing
> >>>>
> >>>>
> >>>>
> >>>>    .../devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml       | 5 ++---
> >>>>    1 file changed, 2 insertions(+), 3 deletions(-)
> >>>
> >>> Not sure how these can be handled.
> >>>
> >>> I guess I cannot take these until the other patches are applied.
> >>>
> >>> NB: The patch doesn't apply cleanly anyway, so will need to be rebased.
> >>>
> >>
> >>
> >> Hello,
> >>
> >> The sama5d2-flexcom binding related patches are dependent on:
> >> https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@microchip.com/
> > 
> > I would be very cautious about relying on comments made in the
> > cover-letter.  Better to make this a hard requirement and place them
> > in the same patch-set.
> > 
> 
> 
> 
> Understood, my apologies, I will keep this in mind the next time this 
> happens :).
> 
> Otherwise, by applying the patch series linked above, my sama5d2-flexcom 
> patches should apply cleanly afterwards.

Please re-send this once the other set has been applied.

-- 
Lee Jones [李琼斯]

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Sergiu.Moga@microchip.com
Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com,
	Kavyasree.Kotagiri@microchip.com, richard.genoud@gmail.com,
	gregkh@linuxfoundation.org, radu_nicolae.pirea@upb.ro,
	linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-serial@vger.kernel.org, linux-spi@vger.kernel.org,
	jirislaby@kernel.org, Claudiu.Beznea@microchip.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding
Date: Mon, 24 Oct 2022 13:25:55 +0100	[thread overview]
Message-ID: <Y1aEU+k1lMOdSSR5@google.com> (raw)
In-Reply-To: <1d61596b-876b-2eca-f72d-ed38cc36f1a8@microchip.com>

On Wed, 28 Sep 2022, Sergiu.Moga@microchip.com wrote:

> On 28.09.2022 18:23, Lee Jones wrote:
> > On Wed, 28 Sep 2022, Sergiu.Moga@microchip.com wrote:
> > 
> >> On 28.09.2022 18:03, Lee Jones wrote:
> >>> On Thu, 22 Sep 2022, Sergiu Moga wrote:
> >>>
> >>>> Another functionality of FLEXCOM is that of SPI. In order for
> >>>> the proper validation of the SPI children nodes through the binding
> >>>> to occur, the proper binding for SPI must be referenced.
> >>>>
> >>>> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>>> ---
> >>>>
> >>>>
> >>>> v1 -> v2:
> >>>> - use full schema paths
> >>>>
> >>>>
> >>>> v2 -> v3:
> >>>> - Added Reviewed-by tag, previously this was [PATCH 3]
> >>>>
> >>>>
> >>>> v3 -> v4:
> >>>> - Nothing, previously this was [PATCH 5]
> >>>>
> >>>>
> >>>> v4 -> v5:
> >>>> - Nothing
> >>>>
> >>>>
> >>>>
> >>>>    .../devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml       | 5 ++---
> >>>>    1 file changed, 2 insertions(+), 3 deletions(-)
> >>>
> >>> Not sure how these can be handled.
> >>>
> >>> I guess I cannot take these until the other patches are applied.
> >>>
> >>> NB: The patch doesn't apply cleanly anyway, so will need to be rebased.
> >>>
> >>
> >>
> >> Hello,
> >>
> >> The sama5d2-flexcom binding related patches are dependent on:
> >> https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@microchip.com/
> > 
> > I would be very cautious about relying on comments made in the
> > cover-letter.  Better to make this a hard requirement and place them
> > in the same patch-set.
> > 
> 
> 
> 
> Understood, my apologies, I will keep this in mind the next time this 
> happens :).
> 
> Otherwise, by applying the patch series linked above, my sama5d2-flexcom 
> patches should apply cleanly afterwards.

Please re-send this once the other set has been applied.

-- 
Lee Jones [李琼斯]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-24 13:17 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 11:33 [PATCH v5 0/9] Make atmel serial driver aware of GCLK Sergiu Moga
2022-09-22 11:33 ` Sergiu Moga
2022-09-22 11:33 ` [PATCH v5 1/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding Sergiu Moga
2022-09-22 11:33   ` Sergiu Moga
2022-09-28 15:03   ` Lee Jones
2022-09-28 15:03     ` Lee Jones
2022-09-28 15:07     ` Sergiu.Moga
2022-09-28 15:07       ` Sergiu.Moga
2022-09-28 15:23       ` Lee Jones
2022-09-28 15:23         ` Lee Jones
2022-09-28 15:35         ` Sergiu.Moga
2022-09-28 15:35           ` Sergiu.Moga
2022-10-24 12:25           ` Lee Jones [this message]
2022-10-24 12:25             ` Lee Jones
2022-09-22 11:33 ` [PATCH v5 2/9] dt-bindings: serial: atmel,at91-usart: convert to json-schema Sergiu Moga
2022-09-22 11:33   ` Sergiu Moga
2022-09-22 11:33 ` [PATCH v5 3/9] dt-bindings: serial: atmel,at91-usart: Add SAM9260 compatibles to SAM9X60 Sergiu Moga
2022-09-22 11:33   ` Sergiu Moga
2022-09-22 11:33 ` [PATCH v5 4/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add USART child node ref binding Sergiu Moga
2022-09-22 11:33   ` Sergiu Moga
2022-09-22 11:33 ` [PATCH v5 5/9] dt-bindings: serial: atmel,at91-usart: Add gclk as a possible USART clock Sergiu Moga
2022-09-22 11:33   ` Sergiu Moga
2022-09-22 11:33 ` [PATCH v5 6/9] tty: serial: atmel: Separate mode clearing between UART and USART Sergiu Moga
2022-09-22 11:33   ` Sergiu Moga
2022-09-30  7:22   ` Claudiu.Beznea
2022-09-30  7:22     ` Claudiu.Beznea
2022-09-22 11:33 ` [PATCH v5 7/9] tty: serial: atmel: Only divide Clock Divisor if the IP is USART Sergiu Moga
2022-09-22 11:33   ` Sergiu Moga
2022-09-30  7:22   ` Claudiu.Beznea
2022-09-30  7:22     ` Claudiu.Beznea
2022-09-22 11:33 ` [PATCH v5 8/9] tty: serial: atmel: Make the driver aware of the existence of GCLK Sergiu Moga
2022-09-22 11:33   ` Sergiu Moga
2022-09-30  7:23   ` Claudiu.Beznea
2022-09-30  7:23     ` Claudiu.Beznea
2022-09-22 11:33 ` [PATCH v5 9/9] tty: serial: atmel: Use FIELD_PREP/FIELD_GET Sergiu Moga
2022-09-22 11:33   ` Sergiu Moga
2022-09-22 12:12   ` Ilpo Järvinen
2022-09-22 12:12     ` Ilpo Järvinen
2022-09-30  7:23   ` Claudiu.Beznea
2022-09-30  7:23     ` Claudiu.Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1aEU+k1lMOdSSR5@google.com \
    --to=lee@kernel.org \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Kavyasree.Kotagiri@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=Sergiu.Moga@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=radu_nicolae.pirea@upb.ro \
    --cc=richard.genoud@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.