From: Lee Jones <lee@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linus.walleij@linaro.org, daniel.thompson@linaro.org
Subject: Re: [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper
Date: Mon, 24 Oct 2022 13:33:15 +0100 [thread overview]
Message-ID: <Y1aGC36X50XvlNwm@google.com> (raw)
In-Reply-To: <20220926142059.2294282-1-yangyingliang@huawei.com>
On Mon, 26 Sep 2022, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> Resend for adding Sob.
> ---
> drivers/video/backlight/ktd253-backlight.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-fbdev@vger.kernel.org, daniel.thompson@linaro.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper
Date: Mon, 24 Oct 2022 13:33:15 +0100 [thread overview]
Message-ID: <Y1aGC36X50XvlNwm@google.com> (raw)
In-Reply-To: <20220926142059.2294282-1-yangyingliang@huawei.com>
On Mon, 26 Sep 2022, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> Resend for adding Sob.
> ---
> drivers/video/backlight/ktd253-backlight.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-10-24 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 14:20 [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-26 14:20 ` Yang Yingliang
2022-10-03 13:56 ` Linus Walleij
2022-10-03 13:56 ` Linus Walleij
2022-10-24 12:33 ` Lee Jones [this message]
2022-10-24 12:33 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1aGC36X50XvlNwm@google.com \
--to=lee@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.