From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: stable@vger.kernel.org, James Morse <james.morse@arm.com>,
Ard Biesheuvel <ardb@kernel.org>, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Zenghui Yu <yuzenghui@huawei.com>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Shreyas K K <quic_shrekk@quicinc.com>,
Marc Zyngier <maz@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Reiji Watanabe <reijiw@google.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@lists.infradead.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH stable 4.19] arm64: errata: Remove AES hwcap for COMPAT tasks
Date: Wed, 26 Oct 2022 19:02:55 +0200 [thread overview]
Message-ID: <Y1loP4wJEgBdZvL3@kroah.com> (raw)
In-Reply-To: <4f0ae178-f075-1f24-43b7-7ba8e494db76@gmail.com>
On Wed, Oct 26, 2022 at 09:51:20AM -0700, Florian Fainelli wrote:
>
>
> On 10/26/2022 9:49 AM, Greg Kroah-Hartman wrote:
> > On Thu, Oct 20, 2022 at 04:01:07PM -0700, Florian Fainelli wrote:
> > > From: James Morse <james.morse@arm.com>
> > >
> > > commit 44b3834b2eed595af07021b1c64e6f9bc396398b upstream
> > >
> > > Cortex-A57 and Cortex-A72 have an erratum where an interrupt that
> > > occurs between a pair of AES instructions in aarch32 mode may corrupt
> > > the ELR. The task will subsequently produce the wrong AES result.
> > >
> > > The AES instructions are part of the cryptographic extensions, which are
> > > optional. User-space software will detect the support for these
> > > instructions from the hwcaps. If the platform doesn't support these
> > > instructions a software implementation should be used.
> > >
> > > Remove the hwcap bits on affected parts to indicate user-space should
> > > not use the AES instructions.
> > >
> > > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> > > Signed-off-by: James Morse <james.morse@arm.com>
> > > Link: https://lore.kernel.org/r/20220714161523.279570-3-james.morse@arm.com
> > > Signed-off-by: Will Deacon <will@kernel.org>
> > > [florian: resolved conflicts in arch/arm64/tools/cpucaps and cpu_errata.c]
> > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > > Change-Id: I651a0db2e9d2f304d210ae979ae586e7dcc9744d
> >
> > No need for Change-Id: in upstream patches :)
>
> Meh, the perils of working with Gerrit in the same tree.. do you need me to
> resubmit or can you strip those when you apply the patches?
I stripped them all, no worries.
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: stable@vger.kernel.org, James Morse <james.morse@arm.com>,
Ard Biesheuvel <ardb@kernel.org>, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Zenghui Yu <yuzenghui@huawei.com>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Shreyas K K <quic_shrekk@quicinc.com>,
Marc Zyngier <maz@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Reiji Watanabe <reijiw@google.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@lists.infradead.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH stable 4.19] arm64: errata: Remove AES hwcap for COMPAT tasks
Date: Wed, 26 Oct 2022 19:02:55 +0200 [thread overview]
Message-ID: <Y1loP4wJEgBdZvL3@kroah.com> (raw)
In-Reply-To: <4f0ae178-f075-1f24-43b7-7ba8e494db76@gmail.com>
On Wed, Oct 26, 2022 at 09:51:20AM -0700, Florian Fainelli wrote:
>
>
> On 10/26/2022 9:49 AM, Greg Kroah-Hartman wrote:
> > On Thu, Oct 20, 2022 at 04:01:07PM -0700, Florian Fainelli wrote:
> > > From: James Morse <james.morse@arm.com>
> > >
> > > commit 44b3834b2eed595af07021b1c64e6f9bc396398b upstream
> > >
> > > Cortex-A57 and Cortex-A72 have an erratum where an interrupt that
> > > occurs between a pair of AES instructions in aarch32 mode may corrupt
> > > the ELR. The task will subsequently produce the wrong AES result.
> > >
> > > The AES instructions are part of the cryptographic extensions, which are
> > > optional. User-space software will detect the support for these
> > > instructions from the hwcaps. If the platform doesn't support these
> > > instructions a software implementation should be used.
> > >
> > > Remove the hwcap bits on affected parts to indicate user-space should
> > > not use the AES instructions.
> > >
> > > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> > > Signed-off-by: James Morse <james.morse@arm.com>
> > > Link: https://lore.kernel.org/r/20220714161523.279570-3-james.morse@arm.com
> > > Signed-off-by: Will Deacon <will@kernel.org>
> > > [florian: resolved conflicts in arch/arm64/tools/cpucaps and cpu_errata.c]
> > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > > Change-Id: I651a0db2e9d2f304d210ae979ae586e7dcc9744d
> >
> > No need for Change-Id: in upstream patches :)
>
> Meh, the perils of working with Gerrit in the same tree.. do you need me to
> resubmit or can you strip those when you apply the patches?
I stripped them all, no worries.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-26 17:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 23:01 [PATCH stable 4.9] arm64: errata: Remove AES hwcap for COMPAT tasks Florian Fainelli
2022-10-20 23:01 ` Florian Fainelli
2022-10-20 23:01 ` [PATCH stable 4.14] " Florian Fainelli
2022-10-20 23:01 ` Florian Fainelli
2022-10-20 23:01 ` [PATCH stable 4.19] " Florian Fainelli
2022-10-20 23:01 ` Florian Fainelli
2022-10-26 16:49 ` Greg Kroah-Hartman
2022-10-26 16:49 ` Greg Kroah-Hartman
2022-10-26 16:51 ` Florian Fainelli
2022-10-26 16:51 ` Florian Fainelli
2022-10-26 17:02 ` Greg Kroah-Hartman [this message]
2022-10-26 17:02 ` Greg Kroah-Hartman
2022-10-20 23:01 ` [PATCH stable 5.4] " Florian Fainelli
2022-10-20 23:01 ` Florian Fainelli
2022-10-20 23:01 ` [PATCH stable 5.10] " Florian Fainelli
2022-10-20 23:01 ` Florian Fainelli
2022-10-20 23:01 ` [PATCH stable 5.15] " Florian Fainelli
2022-10-20 23:01 ` Florian Fainelli
2022-10-26 16:50 ` [PATCH stable 4.9] " Greg Kroah-Hartman
2022-10-26 16:50 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1loP4wJEgBdZvL3@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexandru.elisei@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=f.fainelli@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=james.morse@arm.com \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=quic_shrekk@quicinc.com \
--cc=reijiw@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.