[Outreachy] Coccicheck in drivers/staging/

[Outreachy] Coccicheck in drivers/staging/

[Alison Schofield]

I took a peek at drivers/staging to see what you all may discover
when running Coccicheck.

I simply used the Fedora pkg mgr.
$ sudo dnf install coccinelle
(That got me coccinelle 1.1.1-5.fc36)

$ sudo dnf builddep coccinelle

From root of my kernel tree:
$  make coccicheck M=drivers/staging/ | grep -i warning

That showed many places to drill down further and cleanup.

Re: [Outreachy] Coccicheck in drivers/staging/

[Emily Peri]

On Wed, Oct 26, 2022 at 11:39:23AM -0700, Alison Schofield wrote:
> I took a peek at drivers/staging to see what you all may discover
> when running Coccicheck.
> 
> I simply used the Fedora pkg mgr.
> $ sudo dnf install coccinelle
> (That got me coccinelle 1.1.1-5.fc36)
> 
> $ sudo dnf builddep coccinelle
> 
> From root of my kernel tree:
> $  make coccicheck M=drivers/staging/ | grep -i warning
> 
> That showed many places to drill down further and cleanup.
> 

Thank you for explaining this! 

Since we are getting close to the Outreachy application deadline and
several of us have completed the First Patch Tutorial, is there any more
description of what an internship with this project will look like? Have
interns worked on coccinelle in the past, and what kind of impact did
they have?

Two areas that I think could use updates are the website and
documentation. If this is a project that will take on future Outreachy
applicants, I think it would be very useful to create coccinelle
instructions/tutorial for Outreachy. Are these ideas within the scope of
the internship?

Thanks so much for making this internship possible in the first, I
understand its a lot effort on top of everything else that you do!

Emily

> 
> 
> 
> 

Re: [Outreachy] Coccicheck in drivers/staging/

[Alison Schofield]

On Wed, Oct 26, 2022 at 12:36:40PM -0700, Emily Peri wrote:
> On Wed, Oct 26, 2022 at 11:39:23AM -0700, Alison Schofield wrote:
> > I took a peek at drivers/staging to see what you all may discover
> > when running Coccicheck.
> > 
> > I simply used the Fedora pkg mgr.
> > $ sudo dnf install coccinelle
> > (That got me coccinelle 1.1.1-5.fc36)
> > 
> > $ sudo dnf builddep coccinelle
> > 
> > From root of my kernel tree:
> > $  make coccicheck M=drivers/staging/ | grep -i warning
> > 
> > That showed many places to drill down further and cleanup.
> > 
> 
> Thank you for explaining this! 
> 
> Since we are getting close to the Outreachy application deadline and
> several of us have completed the First Patch Tutorial, is there any more
> description of what an internship with this project will look like? Have
> interns worked on coccinelle in the past, and what kind of impact did
> they have?

Coccinelle, and improving Coccinelle itself, has been the topic
of many past internships. Julia Lawall, who has been commenting
on you patches is the creator of Coccinelle has mentored interns
in developing new support in the Coccinelle tool - for the
Linux Kernel.

The project this round is labelled as 'Coccinelle cleanups in
the Linux Kernel' Of course, the selected intern(s) may take
it further than that and improve Coccinelle itself. Ones you
get into it, you follow the work!

I'll let this round Coccinelle mentors, Saurabh and Praveen,
fill in more about there plans

> 
> Two areas that I think could use updates are the website and
> documentation. If this is a project that will take on future Outreachy
> applicants, I think it would be very useful to create coccinelle
> instructions/tutorial for Outreachy. Are these ideas within the scope of
> the internship?

Improving the documentation along the way is always welcome. 

> Thanks so much for making this internship possible in the first, I
> understand its a lot effort on top of everything else that you do!
> 
> Emily
> 
> > 
> > 
> > 
> > 

Re: [Outreachy] Coccicheck in drivers/staging/

[Emily Peri]

On Wed, Oct 26, 2022 at 01:36:08PM -0700, Alison Schofield wrote:
> On Wed, Oct 26, 2022 at 12:36:40PM -0700, Emily Peri wrote:
> > On Wed, Oct 26, 2022 at 11:39:23AM -0700, Alison Schofield wrote:
> > > I took a peek at drivers/staging to see what you all may discover
> > > when running Coccicheck.
> > > 
> > > I simply used the Fedora pkg mgr.
> > > $ sudo dnf install coccinelle
> > > (That got me coccinelle 1.1.1-5.fc36)
> > > 
> > > $ sudo dnf builddep coccinelle
> > > 
> > > From root of my kernel tree:
> > > $  make coccicheck M=drivers/staging/ | grep -i warning
> > > 
> > > That showed many places to drill down further and cleanup.
> > > 
> > 
> > Thank you for explaining this! 
> > 
> > Since we are getting close to the Outreachy application deadline and
> > several of us have completed the First Patch Tutorial, is there any more
> > description of what an internship with this project will look like? Have
> > interns worked on coccinelle in the past, and what kind of impact did
> > they have?
> 
> Coccinelle, and improving Coccinelle itself, has been the topic
> of many past internships. Julia Lawall, who has been commenting
> on you patches is the creator of Coccinelle has mentored interns
> in developing new support in the Coccinelle tool - for the
> Linux Kernel.
> 
> The project this round is labelled as 'Coccinelle cleanups in
> the Linux Kernel' Of course, the selected intern(s) may take
> it further than that and improve Coccinelle itself. Ones you
> get into it, you follow the work!

Sounds good! Speaking for myself, I want to do what is most useful, but
I'm also hoping to learn some new skills in the process.

> I'll let this round Coccinelle mentors, Saurabh and Praveen,
> fill in more about there plans
> 
> > 
> > Two areas that I think could use updates are the website and
> > documentation. If this is a project that will take on future Outreachy
> > applicants, I think it would be very useful to create coccinelle
> > instructions/tutorial for Outreachy. Are these ideas within the scope of
> > the internship?
> 
> Improving the documentation along the way is always welcome. 
> 
> > Thanks so much for making this internship possible in the first, I
> > understand its a lot effort on top of everything else that you do!
> > 
> > Emily
> > 
> > > 
> > > 
> > > 
> > >