* [igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit"
@ 2022-10-07 13:40 Ville Syrjala
2022-10-07 13:40 ` [igt-dev] [PATCH i-g-t 2/3] Revert "tests/kms_invalid_mode: Avoid usage of same pipe on multiple outputs" Ville Syrjala
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: Ville Syrjala @ 2022-10-07 13:40 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
This reverts commit 544fe3ab351e26b39c2db4a8bc9ac2b5032566c4.
Collateral damage.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_invalid_mode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
index f1c38669860d..0ae98a31fcc2 100644
--- a/tests/kms_invalid_mode.c
+++ b/tests/kms_invalid_mode.c
@@ -306,6 +306,5 @@ igt_main
igt_fixture {
igt_display_fini(&data.display);
igt_reset_connectors();
- close(data.drm_fd);
}
}
--
2.35.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [igt-dev] [PATCH i-g-t 2/3] Revert "tests/kms_invalid_mode: Avoid usage of same pipe on multiple outputs"
2022-10-07 13:40 [igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit" Ville Syrjala
@ 2022-10-07 13:40 ` Ville Syrjala
2022-10-07 13:40 ` [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup" Ville Syrjala
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Ville Syrjala @ 2022-10-07 13:40 UTC (permalink / raw)
To: igt-dev
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
This reverts commit 52c06782816c1dfaf721308d70d9dca83f7eff16.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_invalid_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
index 0ae98a31fcc2..21ee91abf54b 100644
--- a/tests/kms_invalid_mode.c
+++ b/tests/kms_invalid_mode.c
@@ -185,7 +185,6 @@ test_output(data_t *data)
int ret;
drmModeModeInfo *mode;
- igt_display_reset(&data->display);
igt_output_set_pipe(output, data->pipe);
igt_create_fb(data->drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
@@ -203,6 +202,7 @@ test_output(data_t *data)
igt_remove_fb(data->drm_fd, &fb);
igt_output_override_mode(output, NULL);
/*unset_all_crtcs*/
+ igt_display_reset(&data->display);
igt_display_commit(&data->display);
}
--
2.35.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup"
2022-10-07 13:40 [igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit" Ville Syrjala
2022-10-07 13:40 ` [igt-dev] [PATCH i-g-t 2/3] Revert "tests/kms_invalid_mode: Avoid usage of same pipe on multiple outputs" Ville Syrjala
@ 2022-10-07 13:40 ` Ville Syrjala
2022-10-07 15:49 ` Modem, Bhanuprakash
2022-10-27 20:18 ` Ville Syrjälä
2022-10-07 14:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit" Patchwork
` (3 subsequent siblings)
5 siblings, 2 replies; 13+ messages in thread
From: Ville Syrjala @ 2022-10-07 13:40 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
This reverts commit 6725767a84109e934ca138d94df0482386c44532.
This was no cleanup. It does fifteen different things and
in the process flat out breaks the test at least on all
non-atomic drivers/platforms.
Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_invalid_mode.c | 39 ++++++++++++++++++++++++---------------
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
index 21ee91abf54b..0287ee02c1c4 100644
--- a/tests/kms_invalid_mode.c
+++ b/tests/kms_invalid_mode.c
@@ -35,6 +35,7 @@ struct _data {
enum pipe pipe;
igt_display_t display;
igt_output_t *output;
+ drmModeResPtr res;
int max_dotclock;
bool (*adjust_mode)(data_t *data, drmModeModeInfoPtr mode);
};
@@ -181,29 +182,35 @@ static void
test_output(data_t *data)
{
igt_output_t *output = data->output;
+ drmModeModeInfo mode;
struct igt_fb fb;
int ret;
- drmModeModeInfo *mode;
+ uint32_t crtc_id;
- igt_output_set_pipe(output, data->pipe);
+ /*
+ * FIXME test every mode we have to be more
+ * sure everything is really getting rejected?
+ */
+ mode = *igt_output_get_mode(output);
+ igt_require(data->adjust_mode(data, &mode));
- igt_create_fb(data->drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
+ igt_create_fb(data->drm_fd,
+ max_t(uint16_t, mode.hdisplay, 64),
+ max_t(uint16_t, mode.vdisplay, 64),
+ DRM_FORMAT_XRGB8888,
DRM_FORMAT_MOD_LINEAR,
&fb);
- for_each_connector_mode(output) {
- mode = &output->config.connector->modes[j__];
- igt_require(data->adjust_mode(data, mode));
- igt_output_override_mode(output, mode);
- ret = igt_display_try_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
- igt_assert(ret == -EINVAL);
- }
+ kmstest_unset_all_crtcs(data->drm_fd, data->res);
+
+ crtc_id = data->display.pipes[data->pipe].crtc_id;
+
+ ret = drmModeSetCrtc(data->drm_fd, crtc_id,
+ fb.fb_id, 0, 0,
+ &output->id, 1, &mode);
+ igt_assert_lt(ret, 0);
igt_remove_fb(data->drm_fd, &fb);
- igt_output_override_mode(output, NULL);
- /*unset_all_crtcs*/
- igt_display_reset(&data->display);
- igt_display_commit(&data->display);
}
static int i915_max_dotclock(data_t *data)
@@ -283,10 +290,11 @@ igt_main
kmstest_set_vt_graphics_mode();
igt_display_require(&data.display, data.drm_fd);
+ data.res = drmModeGetResources(data.drm_fd);
+ igt_assert(data.res);
data.max_dotclock = i915_max_dotclock(&data);
igt_info("Max dotclock: %d kHz\n", data.max_dotclock);
- igt_display_require_output(&data.display);
}
igt_describe("Make sure all modesets are rejected when the requested mode is invalid");
@@ -306,5 +314,6 @@ igt_main
igt_fixture {
igt_display_fini(&data.display);
igt_reset_connectors();
+ drmModeFreeResources(data.res);
}
}
--
2.35.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit"
2022-10-07 13:40 [igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit" Ville Syrjala
2022-10-07 13:40 ` [igt-dev] [PATCH i-g-t 2/3] Revert "tests/kms_invalid_mode: Avoid usage of same pipe on multiple outputs" Ville Syrjala
2022-10-07 13:40 ` [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup" Ville Syrjala
@ 2022-10-07 14:37 ` Patchwork
2022-10-07 15:32 ` [igt-dev] [PATCH i-g-t 1/3] " Kamil Konieczny
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2022-10-07 14:37 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 5818 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit"
URL : https://patchwork.freedesktop.org/series/109481/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12225 -> IGTPW_7922
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/index.html
Participating hosts (46 -> 44)
------------------------------
Additional (1): fi-tgl-dsi
Missing (3): fi-ctg-p8600 fi-hsw-4200u bat-jsl-3
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7922:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@basic-rte:
- {bat-rplp-1}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/bat-rplp-1/igt@i915_pm_rpm@basic-rte.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/bat-rplp-1/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@gt_lrc:
- {fi-tgl-dsi}: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/fi-tgl-dsi/igt@i915_selftest@live@gt_lrc.html
Known issues
------------
Here are the changes found in IGTPW_7922 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@common-hpd-after-suspend:
- bat-dg1-5: NOTRUN -> [SKIP][4] ([fdo#111827])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/bat-dg1-5/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-bdw-5557u: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/fi-bdw-5557u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#4078])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: [INCOMPLETE][7] ([i915#4418]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-bxt-dsi: [DMESG-FAIL][9] ([i915#5334]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@slpc:
- {bat-adln-1}: [DMESG-FAIL][11] ([i915#6997]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/bat-adln-1/igt@i915_selftest@live@slpc.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/bat-adln-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [INCOMPLETE][13] ([i915#146] / [i915#6712]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#6712]: https://gitlab.freedesktop.org/drm/intel/issues/6712
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7029]: https://gitlab.freedesktop.org/drm/intel/issues/7029
[i915#7031]: https://gitlab.freedesktop.org/drm/intel/issues/7031
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7003 -> IGTPW_7922
CI-20190529: 20190529
CI_DRM_12225: 31426dd8e9677d64141dcf5546927c6c23e994bd @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7922: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/index.html
IGT_7003: 1ea9ec5e7295fbc1cb784be4692971fd342bea53 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/index.html
[-- Attachment #2: Type: text/html, Size: 5643 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit"
2022-10-07 13:40 [igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit" Ville Syrjala
` (2 preceding siblings ...)
2022-10-07 14:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit" Patchwork
@ 2022-10-07 15:32 ` Kamil Konieczny
2022-10-07 15:45 ` Ville Syrjälä
2022-10-07 18:27 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] " Patchwork
2022-10-28 6:47 ` [igt-dev] ✗ Fi.CI.BUILD: failure for series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit" (rev2) Patchwork
5 siblings, 1 reply; 13+ messages in thread
From: Kamil Konieczny @ 2022-10-07 15:32 UTC (permalink / raw)
To: igt-dev
Hi Ville,
On 2022-10-07 at 16:40:27 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This reverts commit 544fe3ab351e26b39c2db4a8bc9ac2b5032566c4.
>
> Collateral damage.
You made also two other reverts to this test, maybe this close()
is ok ? This change was part of big series and waited here for
over a week, so please try to send patch series with cover letter
and put there any logs, debug, dumps or links to our CI to see
what happened. Note also that there are other kms tests with
similar change.
If I may suggest please send series with two other reverts to see
if this close() could stay.
Regards,
Kamil
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_invalid_mode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> index f1c38669860d..0ae98a31fcc2 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -306,6 +306,5 @@ igt_main
> igt_fixture {
> igt_display_fini(&data.display);
> igt_reset_connectors();
> - close(data.drm_fd);
> }
> }
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit"
2022-10-07 15:32 ` [igt-dev] [PATCH i-g-t 1/3] " Kamil Konieczny
@ 2022-10-07 15:45 ` Ville Syrjälä
0 siblings, 0 replies; 13+ messages in thread
From: Ville Syrjälä @ 2022-10-07 15:45 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev
On Fri, Oct 07, 2022 at 05:32:54PM +0200, Kamil Konieczny wrote:
> Hi Ville,
>
> On 2022-10-07 at 16:40:27 +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > This reverts commit 544fe3ab351e26b39c2db4a8bc9ac2b5032566c4.
> >
> > Collateral damage.
>
> You made also two other reverts to this test, maybe this close()
> is ok ? This change was part of big series and waited here for
> over a week, so please try to send patch series with cover letter
> and put there any logs, debug, dumps or links to our CI to see
> what happened. Note also that there are other kms tests with
> similar change.
>
> If I may suggest please send series with two other reverts to see
> if this close() could stay.
I was too lazy to start resolving the conflicts. I'll leave
that to those who broke the test.
>
> Regards,
> Kamil
>
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > tests/kms_invalid_mode.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> > index f1c38669860d..0ae98a31fcc2 100644
> > --- a/tests/kms_invalid_mode.c
> > +++ b/tests/kms_invalid_mode.c
> > @@ -306,6 +306,5 @@ igt_main
> > igt_fixture {
> > igt_display_fini(&data.display);
> > igt_reset_connectors();
> > - close(data.drm_fd);
> > }
> > }
> > --
> > 2.35.1
> >
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup"
2022-10-07 13:40 ` [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup" Ville Syrjala
@ 2022-10-07 15:49 ` Modem, Bhanuprakash
2022-10-07 16:04 ` Ville Syrjälä
2022-10-27 20:18 ` Ville Syrjälä
1 sibling, 1 reply; 13+ messages in thread
From: Modem, Bhanuprakash @ 2022-10-07 15:49 UTC (permalink / raw)
To: Ville Syrjala, igt-dev; +Cc: Nidhi Gupta
On Fri-07-10-2022 07:10 pm, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This reverts commit 6725767a84109e934ca138d94df0482386c44532.
>
> This was no cleanup. It does fifteen different things and
> in the process flat out breaks the test at least on all
> non-atomic drivers/platforms.
will it be useful [1]?
[1]: https://patchwork.freedesktop.org/series/109484/
- Bhanu
>
> Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_invalid_mode.c | 39 ++++++++++++++++++++++++---------------
> 1 file changed, 24 insertions(+), 15 deletions(-)
>
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> index 21ee91abf54b..0287ee02c1c4 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -35,6 +35,7 @@ struct _data {
> enum pipe pipe;
> igt_display_t display;
> igt_output_t *output;
> + drmModeResPtr res;
> int max_dotclock;
> bool (*adjust_mode)(data_t *data, drmModeModeInfoPtr mode);
> };
> @@ -181,29 +182,35 @@ static void
> test_output(data_t *data)
> {
> igt_output_t *output = data->output;
> + drmModeModeInfo mode;
> struct igt_fb fb;
> int ret;
> - drmModeModeInfo *mode;
> + uint32_t crtc_id;
>
> - igt_output_set_pipe(output, data->pipe);
> + /*
> + * FIXME test every mode we have to be more
> + * sure everything is really getting rejected?
> + */
> + mode = *igt_output_get_mode(output);
> + igt_require(data->adjust_mode(data, &mode));
>
> - igt_create_fb(data->drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
> + igt_create_fb(data->drm_fd,
> + max_t(uint16_t, mode.hdisplay, 64),
> + max_t(uint16_t, mode.vdisplay, 64),
> + DRM_FORMAT_XRGB8888,
> DRM_FORMAT_MOD_LINEAR,
> &fb);
>
> - for_each_connector_mode(output) {
> - mode = &output->config.connector->modes[j__];
> - igt_require(data->adjust_mode(data, mode));
> - igt_output_override_mode(output, mode);
> - ret = igt_display_try_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
> - igt_assert(ret == -EINVAL);
> - }
> + kmstest_unset_all_crtcs(data->drm_fd, data->res);
> +
> + crtc_id = data->display.pipes[data->pipe].crtc_id;
> +
> + ret = drmModeSetCrtc(data->drm_fd, crtc_id,
> + fb.fb_id, 0, 0,
> + &output->id, 1, &mode);
> + igt_assert_lt(ret, 0);
>
> igt_remove_fb(data->drm_fd, &fb);
> - igt_output_override_mode(output, NULL);
> - /*unset_all_crtcs*/
> - igt_display_reset(&data->display);
> - igt_display_commit(&data->display);
> }
>
> static int i915_max_dotclock(data_t *data)
> @@ -283,10 +290,11 @@ igt_main
> kmstest_set_vt_graphics_mode();
>
> igt_display_require(&data.display, data.drm_fd);
> + data.res = drmModeGetResources(data.drm_fd);
> + igt_assert(data.res);
>
> data.max_dotclock = i915_max_dotclock(&data);
> igt_info("Max dotclock: %d kHz\n", data.max_dotclock);
> - igt_display_require_output(&data.display);
> }
>
> igt_describe("Make sure all modesets are rejected when the requested mode is invalid");
> @@ -306,5 +314,6 @@ igt_main
> igt_fixture {
> igt_display_fini(&data.display);
> igt_reset_connectors();
> + drmModeFreeResources(data.res);
> }
> }
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup"
2022-10-07 15:49 ` Modem, Bhanuprakash
@ 2022-10-07 16:04 ` Ville Syrjälä
0 siblings, 0 replies; 13+ messages in thread
From: Ville Syrjälä @ 2022-10-07 16:04 UTC (permalink / raw)
To: Modem, Bhanuprakash; +Cc: igt-dev, Nidhi Gupta
On Fri, Oct 07, 2022 at 09:19:58PM +0530, Modem, Bhanuprakash wrote:
> On Fri-07-10-2022 07:10 pm, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > This reverts commit 6725767a84109e934ca138d94df0482386c44532.
> >
> > This was no cleanup. It does fifteen different things and
> > in the process flat out breaks the test at least on all
> > non-atomic drivers/platforms.
>
> will it be useful [1]?
>
> [1]: https://patchwork.freedesktop.org/series/109484/
Useful to specify a framebuffer? Sure. Will if fix the
thing? No.
>
> - Bhanu
>
> >
> > Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
> > Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > tests/kms_invalid_mode.c | 39 ++++++++++++++++++++++++---------------
> > 1 file changed, 24 insertions(+), 15 deletions(-)
> >
> > diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> > index 21ee91abf54b..0287ee02c1c4 100644
> > --- a/tests/kms_invalid_mode.c
> > +++ b/tests/kms_invalid_mode.c
> > @@ -35,6 +35,7 @@ struct _data {
> > enum pipe pipe;
> > igt_display_t display;
> > igt_output_t *output;
> > + drmModeResPtr res;
> > int max_dotclock;
> > bool (*adjust_mode)(data_t *data, drmModeModeInfoPtr mode);
> > };
> > @@ -181,29 +182,35 @@ static void
> > test_output(data_t *data)
> > {
> > igt_output_t *output = data->output;
> > + drmModeModeInfo mode;
> > struct igt_fb fb;
> > int ret;
> > - drmModeModeInfo *mode;
> > + uint32_t crtc_id;
> >
> > - igt_output_set_pipe(output, data->pipe);
> > + /*
> > + * FIXME test every mode we have to be more
> > + * sure everything is really getting rejected?
> > + */
> > + mode = *igt_output_get_mode(output);
> > + igt_require(data->adjust_mode(data, &mode));
> >
> > - igt_create_fb(data->drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
> > + igt_create_fb(data->drm_fd,
> > + max_t(uint16_t, mode.hdisplay, 64),
> > + max_t(uint16_t, mode.vdisplay, 64),
> > + DRM_FORMAT_XRGB8888,
> > DRM_FORMAT_MOD_LINEAR,
> > &fb);
> >
> > - for_each_connector_mode(output) {
> > - mode = &output->config.connector->modes[j__];
> > - igt_require(data->adjust_mode(data, mode));
> > - igt_output_override_mode(output, mode);
> > - ret = igt_display_try_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
> > - igt_assert(ret == -EINVAL);
> > - }
> > + kmstest_unset_all_crtcs(data->drm_fd, data->res);
> > +
> > + crtc_id = data->display.pipes[data->pipe].crtc_id;
> > +
> > + ret = drmModeSetCrtc(data->drm_fd, crtc_id,
> > + fb.fb_id, 0, 0,
> > + &output->id, 1, &mode);
> > + igt_assert_lt(ret, 0);
> >
> > igt_remove_fb(data->drm_fd, &fb);
> > - igt_output_override_mode(output, NULL);
> > - /*unset_all_crtcs*/
> > - igt_display_reset(&data->display);
> > - igt_display_commit(&data->display);
> > }
> >
> > static int i915_max_dotclock(data_t *data)
> > @@ -283,10 +290,11 @@ igt_main
> > kmstest_set_vt_graphics_mode();
> >
> > igt_display_require(&data.display, data.drm_fd);
> > + data.res = drmModeGetResources(data.drm_fd);
> > + igt_assert(data.res);
> >
> > data.max_dotclock = i915_max_dotclock(&data);
> > igt_info("Max dotclock: %d kHz\n", data.max_dotclock);
> > - igt_display_require_output(&data.display);
> > }
> >
> > igt_describe("Make sure all modesets are rejected when the requested mode is invalid");
> > @@ -306,5 +314,6 @@ igt_main
> > igt_fixture {
> > igt_display_fini(&data.display);
> > igt_reset_connectors();
> > + drmModeFreeResources(data.res);
> > }
> > }
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit"
2022-10-07 13:40 [igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit" Ville Syrjala
` (3 preceding siblings ...)
2022-10-07 15:32 ` [igt-dev] [PATCH i-g-t 1/3] " Kamil Konieczny
@ 2022-10-07 18:27 ` Patchwork
2022-10-28 6:47 ` [igt-dev] ✗ Fi.CI.BUILD: failure for series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit" (rev2) Patchwork
5 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2022-10-07 18:27 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 41412 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit"
URL : https://patchwork.freedesktop.org/series/109481/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12225_full -> IGTPW_7922_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_7922_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_7922_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/index.html
Participating hosts (12 -> 9)
------------------------------
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_7922_full:
### IGT changes ###
#### Warnings ####
* igt@kms_invalid_mode@clock-too-high@edp-1-pipe-c:
- shard-iclb: [SKIP][1] ([i915#6403]) -> [SKIP][2] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-iclb7/igt@kms_invalid_mode@clock-too-high@edp-1-pipe-c.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb1/igt@kms_invalid_mode@clock-too-high@edp-1-pipe-c.html
* igt@kms_invalid_mode@clock-too-high@edp-1-pipe-d:
- shard-tglb: [SKIP][3] ([i915#6403]) -> [SKIP][4] +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-tglb7/igt@kms_invalid_mode@clock-too-high@edp-1-pipe-d.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb8/igt@kms_invalid_mode@clock-too-high@edp-1-pipe-d.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_eio@suspend:
- {shard-rkl}: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-1/igt@gem_eio@suspend.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-4/igt@gem_eio@suspend.html
* igt@kms_invalid_mode@bad-vtotal:
- {shard-rkl}: NOTRUN -> [SKIP][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-2/igt@kms_invalid_mode@bad-vtotal.html
* igt@kms_invalid_mode@clock-too-high@edp-1-pipe-a:
- {shard-rkl}: [SKIP][8] ([i915#6403]) -> [SKIP][9] +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-6/igt@kms_invalid_mode@clock-too-high@edp-1-pipe-a.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-6/igt@kms_invalid_mode@clock-too-high@edp-1-pipe-a.html
* igt@kms_invalid_mode@zero-clock:
- {shard-rkl}: [SKIP][10] ([i915#1845] / [i915#4098]) -> [SKIP][11] +4 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-1/igt@kms_invalid_mode@zero-clock.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-4/igt@kms_invalid_mode@zero-clock.html
Known issues
------------
Here are the changes found in IGTPW_7922_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ccs@block-copy-inplace:
- shard-tglb: NOTRUN -> [SKIP][12] ([i915#3555] / [i915#5325])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb3/igt@gem_ccs@block-copy-inplace.html
- shard-iclb: NOTRUN -> [SKIP][13] ([i915#5327])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb2/igt@gem_ccs@block-copy-inplace.html
* igt@gem_ctx_persistence@engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#1099]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-snb6/igt@gem_ctx_persistence@engines-cleanup.html
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [PASS][15] -> [SKIP][16] ([i915#4525]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-iclb1/igt@gem_exec_balancer@parallel-contexts.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb7/igt@gem_exec_balancer@parallel-contexts.html
* igt@gem_exec_endless@dispatch@bcs0:
- shard-tglb: [PASS][17] -> [INCOMPLETE][18] ([i915#3778])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-tglb2/igt@gem_exec_endless@dispatch@bcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb8/igt@gem_exec_endless@dispatch@bcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#2842]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fence@syncobj-backward-timeline-chain-engines:
- shard-snb: NOTRUN -> [SKIP][21] ([fdo#109271]) +48 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-snb6/igt@gem_exec_fence@syncobj-backward-timeline-chain-engines.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> [SKIP][22] ([fdo#109313])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb3/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
- shard-tglb: NOTRUN -> [SKIP][23] ([fdo#109313])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb2/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#2190])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl3/igt@gem_huc_copy@huc-copy.html
- shard-tglb: NOTRUN -> [SKIP][25] ([i915#2190])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb7/igt@gem_huc_copy@huc-copy.html
- shard-glk: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#2190])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk5/igt@gem_huc_copy@huc-copy.html
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#2190])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb5/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#4613]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl1/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_pxp@create-regular-buffer:
- shard-glk: NOTRUN -> [SKIP][29] ([fdo#109271]) +61 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk6/igt@gem_pxp@create-regular-buffer.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#3323])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gen7_exec_parse@basic-offset:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109289])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb7/igt@gen7_exec_parse@basic-offset.html
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109289])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb5/igt@gen7_exec_parse@basic-offset.html
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][33] -> [DMESG-WARN][34] ([i915#5566] / [i915#716]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-glk6/igt@gen9_exec_parse@allowed-all.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk5/igt@gen9_exec_parse@allowed-all.html
* igt@gen9_exec_parse@unaligned-access:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#2527] / [i915#2856])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb2/igt@gen9_exec_parse@unaligned-access.html
- shard-iclb: NOTRUN -> [SKIP][36] ([i915#2856])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb2/igt@gen9_exec_parse@unaligned-access.html
* igt@i915_query@query-topology-known-pci-ids:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#109303])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb1/igt@i915_query@query-topology-known-pci-ids.html
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109303])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb6/igt@i915_query@query-topology-known-pci-ids.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-dp-1:
- shard-apl: [PASS][39] -> [FAIL][40] ([i915#2521])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl8/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-dp-1.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl7/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-dp-1.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271]) +117 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl8/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111614])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb3/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#110725] / [fdo#111614])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb2/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#111615])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb1/igt@kms_big_fb@yf-tiled-32bpp-rotate-270.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +8 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl8/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3886]) +5 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk9/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#6095]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb1/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278] / [i915#3886]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb6/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#3689] / [i915#3886])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb1/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][50] ([fdo#111615] / [i915#3689])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb5/igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_chamelium@dp-audio:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109284] / [fdo#111827]) +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb5/igt@kms_chamelium@dp-audio.html
* igt@kms_chamelium@dp-hpd-fast:
- shard-tglb: NOTRUN -> [SKIP][52] ([fdo#109284] / [fdo#111827]) +4 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb3/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- shard-glk: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +7 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk7/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +9 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl1/igt@kms_chamelium@hdmi-hpd-storm.html
* igt@kms_color_chamelium@ctm-red-to-blue:
- shard-snb: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +3 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-snb6/igt@kms_color_chamelium@ctm-red-to-blue.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-iclb: [PASS][56] -> [FAIL][57] ([i915#2346])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-iclb6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109274])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb5/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html
- shard-tglb: NOTRUN -> [SKIP][59] ([fdo#109274] / [fdo#111825] / [i915#3637])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb7/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][60] ([i915#2672]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][61] ([i915#2587] / [i915#2672]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#6497]) +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109280]) +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-fullscreen:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109280] / [fdo#111825]) +4 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb8/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-fullscreen.html
* igt@kms_hdr@static-swap:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#3555]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb5/igt@kms_hdr@static-swap.html
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#3555])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb7/igt@kms_hdr@static-swap.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-apl: [PASS][67] -> [DMESG-WARN][68] ([i915#180])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl8/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][69] -> [SKIP][70] ([i915#5235]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-iclb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#658]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk8/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [PASS][72] -> [SKIP][73] ([fdo#109642] / [fdo#111068] / [i915#658])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-iclb2/igt@kms_psr2_su@frontbuffer-xrgb8888.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb6/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-tglb: NOTRUN -> [FAIL][74] ([i915#132] / [i915#3467])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb2/igt@kms_psr@psr2_cursor_plane_onoff.html
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109441])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb3/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][76] -> [SKIP][77] ([fdo#109441]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_selftest@all:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#6433])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb2/igt@kms_selftest@all.html
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#6433])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb2/igt@kms_selftest@all.html
* igt@kms_vblank@pipe-d-wait-forked:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109278]) +3 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb2/igt@kms_vblank@pipe-d-wait-forked.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#533])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl8/igt@kms_vblank@pipe-d-wait-idle.html
- shard-glk: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#533])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk8/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-check-output:
- shard-glk: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2437])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk1/igt@kms_writeback@writeback-check-output.html
* igt@perf@polling-parameterized:
- shard-iclb: [PASS][84] -> [FAIL][85] ([i915#5639])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-iclb8/igt@perf@polling-parameterized.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb6/igt@perf@polling-parameterized.html
* igt@perf_pmu@module-unload:
- shard-snb: [PASS][86] -> [DMESG-WARN][87] ([i915#4528])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-snb5/igt@perf_pmu@module-unload.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-snb2/igt@perf_pmu@module-unload.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2994])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl1/igt@sysfs_clients@fair-1.html
#### Possible fixes ####
* igt@fbdev@pan:
- {shard-rkl}: [SKIP][89] ([i915#2582]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-1/igt@fbdev@pan.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-6/igt@fbdev@pan.html
* igt@feature_discovery@psr2:
- {shard-rkl}: [SKIP][91] ([i915#658]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-5/igt@feature_discovery@psr2.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-6/igt@feature_discovery@psr2.html
* igt@gem_eio@reset-stress:
- shard-tglb: [FAIL][93] ([i915#5784]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-tglb5/igt@gem_eio@reset-stress.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb8/igt@gem_eio@reset-stress.html
* igt@gem_eio@unwedge-stress:
- {shard-tglu}: [TIMEOUT][95] ([i915#3063]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-tglu-3/igt@gem_eio@unwedge-stress.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglu-5/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][97] ([i915#4525]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-iclb7/igt@gem_exec_balancer@parallel-keep-submit-fence.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb1/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_fair@basic-deadline:
- {shard-rkl}: [FAIL][99] ([i915#2846]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-4/igt@gem_exec_fair@basic-deadline.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-5/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][101] ([i915#2842]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-tglb8/igt@gem_exec_fair@basic-flow@rcs0.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fence@basic-busy@bcs0:
- {shard-rkl}: [SKIP][103] ([i915#6251]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-5/igt@gem_exec_fence@basic-busy@bcs0.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-1/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_reloc@basic-cpu-noreloc:
- {shard-rkl}: [SKIP][105] ([i915#3281]) -> [PASS][106] +3 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-1/igt@gem_exec_reloc@basic-cpu-noreloc.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-5/igt@gem_exec_reloc@basic-cpu-noreloc.html
* igt@gem_pread@uncached:
- {shard-rkl}: [SKIP][107] ([i915#3282]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-4/igt@gem_pread@uncached.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-5/igt@gem_pread@uncached.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [DMESG-WARN][109] ([i915#5566] / [i915#716]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl3/igt@gen9_exec_parse@allowed-single.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl1/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-start-cmd:
- {shard-rkl}: [SKIP][111] ([i915#2527]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-4/igt@gen9_exec_parse@bb-start-cmd.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-5/igt@gen9_exec_parse@bb-start-cmd.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-tglu}: [FAIL][113] ([i915#3825]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-tglu-2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglu-1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rpm@fences:
- {shard-rkl}: [SKIP][115] ([i915#1849]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-5/igt@i915_pm_rpm@fences.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-6/igt@i915_pm_rpm@fences.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][117] ([i915#6537]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl8/igt@i915_pm_rps@engine-order.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl8/igt@i915_pm_rps@engine-order.html
* igt@kms_addfb_basic@legacy-format:
- shard-tglb: [INCOMPLETE][119] ([i915#6987]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-tglb8/igt@kms_addfb_basic@legacy-format.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-tglb3/igt@kms_addfb_basic@legacy-format.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][121] ([i915#1845] / [i915#4098]) -> [PASS][122] +14 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-5/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-6/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][123] ([i915#2346]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][125] ([i915#2122]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-glk5/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-glk6/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [DMESG-WARN][127] ([i915#180]) -> [PASS][128] +1 similar issue
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl3/igt@kms_flip@flip-vs-suspend@c-dp1.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_frontbuffer_tracking@psr-modesetfrombusy:
- {shard-rkl}: [SKIP][129] ([i915#1849] / [i915#4098]) -> [PASS][130] +13 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-2/igt@kms_frontbuffer_tracking@psr-modesetfrombusy.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-modesetfrombusy.html
* igt@kms_plane@plane-panning-bottom-right@pipe-a-planes:
- {shard-rkl}: [SKIP][131] ([i915#3558]) -> [PASS][132] +1 similar issue
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-1/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-6/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
* igt@kms_psr@primary_mmap_gtt:
- {shard-rkl}: [SKIP][133] ([i915#1072]) -> [PASS][134] +3 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-4/igt@kms_psr@primary_mmap_gtt.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-6/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][135] ([fdo#109441]) -> [PASS][136] +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf@gen12-oa-tlb-invalidate:
- {shard-rkl}: [SKIP][137] ([fdo#109289]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-rkl-5/igt@perf@gen12-oa-tlb-invalidate.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-rkl-1/igt@perf@gen12-oa-tlb-invalidate.html
#### Warnings ####
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][139] ([fdo#111068] / [i915#658]) -> [SKIP][140] ([i915#2920])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-iclb6/igt@kms_psr2_sf@cursor-plane-update-sf.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][147], [FAIL][148], [FAIL][149]) ([i915#3002] / [i915#4312])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl2/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl3/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl3/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl8/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl7/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12225/shard-apl6/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl3/igt@runner@aborted.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl3/igt@runner@aborted.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/shard-apl3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6403]: https://gitlab.freedesktop.org/drm/intel/issues/6403
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6987]: https://gitlab.freedesktop.org/drm/intel/issues/6987
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7003 -> IGTPW_7922
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12225: 31426dd8e9677d64141dcf5546927c6c23e994bd @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7922: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/index.html
IGT_7003: 1ea9ec5e7295fbc1cb784be4692971fd342bea53 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7922/index.html
[-- Attachment #2: Type: text/html, Size: 44160 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup"
2022-10-07 13:40 ` [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup" Ville Syrjala
2022-10-07 15:49 ` Modem, Bhanuprakash
@ 2022-10-27 20:18 ` Ville Syrjälä
2022-10-27 22:03 ` Modem, Bhanuprakash
1 sibling, 1 reply; 13+ messages in thread
From: Ville Syrjälä @ 2022-10-27 20:18 UTC (permalink / raw)
To: igt-dev; +Cc: Nidhi Gupta
On Fri, Oct 07, 2022 at 04:40:29PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This reverts commit 6725767a84109e934ca138d94df0482386c44532.
>
> This was no cleanup. It does fifteen different things and
> in the process flat out breaks the test at least on all
> non-atomic drivers/platforms.
>
> Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Is anyone going to do anything about this or do I just push the
reverts?
> ---
> tests/kms_invalid_mode.c | 39 ++++++++++++++++++++++++---------------
> 1 file changed, 24 insertions(+), 15 deletions(-)
>
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> index 21ee91abf54b..0287ee02c1c4 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -35,6 +35,7 @@ struct _data {
> enum pipe pipe;
> igt_display_t display;
> igt_output_t *output;
> + drmModeResPtr res;
> int max_dotclock;
> bool (*adjust_mode)(data_t *data, drmModeModeInfoPtr mode);
> };
> @@ -181,29 +182,35 @@ static void
> test_output(data_t *data)
> {
> igt_output_t *output = data->output;
> + drmModeModeInfo mode;
> struct igt_fb fb;
> int ret;
> - drmModeModeInfo *mode;
> + uint32_t crtc_id;
>
> - igt_output_set_pipe(output, data->pipe);
> + /*
> + * FIXME test every mode we have to be more
> + * sure everything is really getting rejected?
> + */
> + mode = *igt_output_get_mode(output);
> + igt_require(data->adjust_mode(data, &mode));
>
> - igt_create_fb(data->drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
> + igt_create_fb(data->drm_fd,
> + max_t(uint16_t, mode.hdisplay, 64),
> + max_t(uint16_t, mode.vdisplay, 64),
> + DRM_FORMAT_XRGB8888,
> DRM_FORMAT_MOD_LINEAR,
> &fb);
>
> - for_each_connector_mode(output) {
> - mode = &output->config.connector->modes[j__];
> - igt_require(data->adjust_mode(data, mode));
> - igt_output_override_mode(output, mode);
> - ret = igt_display_try_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
> - igt_assert(ret == -EINVAL);
> - }
> + kmstest_unset_all_crtcs(data->drm_fd, data->res);
> +
> + crtc_id = data->display.pipes[data->pipe].crtc_id;
> +
> + ret = drmModeSetCrtc(data->drm_fd, crtc_id,
> + fb.fb_id, 0, 0,
> + &output->id, 1, &mode);
> + igt_assert_lt(ret, 0);
>
> igt_remove_fb(data->drm_fd, &fb);
> - igt_output_override_mode(output, NULL);
> - /*unset_all_crtcs*/
> - igt_display_reset(&data->display);
> - igt_display_commit(&data->display);
> }
>
> static int i915_max_dotclock(data_t *data)
> @@ -283,10 +290,11 @@ igt_main
> kmstest_set_vt_graphics_mode();
>
> igt_display_require(&data.display, data.drm_fd);
> + data.res = drmModeGetResources(data.drm_fd);
> + igt_assert(data.res);
>
> data.max_dotclock = i915_max_dotclock(&data);
> igt_info("Max dotclock: %d kHz\n", data.max_dotclock);
> - igt_display_require_output(&data.display);
> }
>
> igt_describe("Make sure all modesets are rejected when the requested mode is invalid");
> @@ -306,5 +314,6 @@ igt_main
> igt_fixture {
> igt_display_fini(&data.display);
> igt_reset_connectors();
> + drmModeFreeResources(data.res);
> }
> }
> --
> 2.35.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup"
2022-10-27 20:18 ` Ville Syrjälä
@ 2022-10-27 22:03 ` Modem, Bhanuprakash
2022-10-28 6:34 ` Gupta, Nidhi1
0 siblings, 1 reply; 13+ messages in thread
From: Modem, Bhanuprakash @ 2022-10-27 22:03 UTC (permalink / raw)
To: Ville Syrjälä, igt-dev@lists.freedesktop.org; +Cc: Gupta, Nidhi1
[-- Attachment #1: Type: text/plain, Size: 4361 bytes --]
Nidhi is working on it.
Thanks
Bhanu
________________________________
పంపినవారు: Ville Syrjälä <ville.syrjala@linux.intel.com>
పంపినవి: Friday, October 28, 2022 1:48:03 AM
గ్రహీత: igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>
Cc: Gupta, Nidhi1 <nidhi1.gupta@intel.com>; Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
విషయం: Re: [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup"
On Fri, Oct 07, 2022 at 04:40:29PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This reverts commit 6725767a84109e934ca138d94df0482386c44532.
>
> This was no cleanup. It does fifteen different things and
> in the process flat out breaks the test at least on all
> non-atomic drivers/platforms.
>
> Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Is anyone going to do anything about this or do I just push the
reverts?
> ---
> tests/kms_invalid_mode.c | 39 ++++++++++++++++++++++++---------------
> 1 file changed, 24 insertions(+), 15 deletions(-)
>
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> index 21ee91abf54b..0287ee02c1c4 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -35,6 +35,7 @@ struct _data {
> enum pipe pipe;
> igt_display_t display;
> igt_output_t *output;
> + drmModeResPtr res;
> int max_dotclock;
> bool (*adjust_mode)(data_t *data, drmModeModeInfoPtr mode);
> };
> @@ -181,29 +182,35 @@ static void
> test_output(data_t *data)
> {
> igt_output_t *output = data->output;
> + drmModeModeInfo mode;
> struct igt_fb fb;
> int ret;
> - drmModeModeInfo *mode;
> + uint32_t crtc_id;
>
> - igt_output_set_pipe(output, data->pipe);
> + /*
> + * FIXME test every mode we have to be more
> + * sure everything is really getting rejected?
> + */
> + mode = *igt_output_get_mode(output);
> + igt_require(data->adjust_mode(data, &mode));
>
> - igt_create_fb(data->drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
> + igt_create_fb(data->drm_fd,
> + max_t(uint16_t, mode.hdisplay, 64),
> + max_t(uint16_t, mode.vdisplay, 64),
> + DRM_FORMAT_XRGB8888,
> DRM_FORMAT_MOD_LINEAR,
> &fb);
>
> - for_each_connector_mode(output) {
> - mode = &output->config.connector->modes[j__];
> - igt_require(data->adjust_mode(data, mode));
> - igt_output_override_mode(output, mode);
> - ret = igt_display_try_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
> - igt_assert(ret == -EINVAL);
> - }
> + kmstest_unset_all_crtcs(data->drm_fd, data->res);
> +
> + crtc_id = data->display.pipes[data->pipe].crtc_id;
> +
> + ret = drmModeSetCrtc(data->drm_fd, crtc_id,
> + fb.fb_id, 0, 0,
> + &output->id, 1, &mode);
> + igt_assert_lt(ret, 0);
>
> igt_remove_fb(data->drm_fd, &fb);
> - igt_output_override_mode(output, NULL);
> - /*unset_all_crtcs*/
> - igt_display_reset(&data->display);
> - igt_display_commit(&data->display);
> }
>
> static int i915_max_dotclock(data_t *data)
> @@ -283,10 +290,11 @@ igt_main
> kmstest_set_vt_graphics_mode();
>
> igt_display_require(&data.display, data.drm_fd);
> + data.res = drmModeGetResources(data.drm_fd);
> + igt_assert(data.res);
>
> data.max_dotclock = i915_max_dotclock(&data);
> igt_info("Max dotclock: %d kHz\n", data.max_dotclock);
> - igt_display_require_output(&data.display);
> }
>
> igt_describe("Make sure all modesets are rejected when the requested mode is invalid");
> @@ -306,5 +314,6 @@ igt_main
> igt_fixture {
> igt_display_fini(&data.display);
> igt_reset_connectors();
> + drmModeFreeResources(data.res);
> }
> }
> --
> 2.35.1
--
Ville Syrjälä
Intel
[-- Attachment #2: Type: text/html, Size: 8693 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup"
2022-10-27 22:03 ` Modem, Bhanuprakash
@ 2022-10-28 6:34 ` Gupta, Nidhi1
0 siblings, 0 replies; 13+ messages in thread
From: Gupta, Nidhi1 @ 2022-10-28 6:34 UTC (permalink / raw)
To: Modem, Bhanuprakash, Ville Syrjälä,
igt-dev@lists.freedesktop.org
Cc: Syrjala, Ville
[-- Attachment #1: Type: text/plain, Size: 5708 bytes --]
Sorry for the delay, I am working on it to fix it.
I am trying to debug by replacing the atomic commit with legacy commit:
diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
index f1c38669..08c1d001 100644
--- a/tests/kms_invalid_mode.c
+++ b/tests/kms_invalid_mode.c
@@ -197,6 +197,7 @@ test_output(data_t *data)
igt_require(data->adjust_mode(data, mode));
igt_output_override_mode(output, mode);
- ret = igt_display_try_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
+ ret = igt_display_try_commit2(display, COMMIT_LEGACY);
igt_assert(ret == -EINVAL);
}
Nidhi
From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
Sent: Friday, October 28, 2022 3:33 AM
To: Ville Syrjälä <ville.syrjala@linux.intel.com>; igt-dev@lists.freedesktop.org
Cc: Gupta, Nidhi1 <nidhi1.gupta@intel.com>
Subject: Re: [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup"
Nidhi is working on it.
Thanks
Bhanu
________________________________
పంపినవారు: Ville Syrjälä <ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com>>
పంపినవి: Friday, October 28, 2022 1:48:03 AM
గ్రహీత: igt-dev@lists.freedesktop.org<mailto:igt-dev@lists.freedesktop.org> <igt-dev@lists.freedesktop.org<mailto:igt-dev@lists.freedesktop.org>>
Cc: Gupta, Nidhi1 <nidhi1.gupta@intel.com<mailto:nidhi1.gupta@intel.com>>; Modem, Bhanuprakash <bhanuprakash.modem@intel.com<mailto:bhanuprakash.modem@intel.com>>
విషయం: Re: [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup"
On Fri, Oct 07, 2022 at 04:40:29PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com>>
>
> This reverts commit 6725767a84109e934ca138d94df0482386c44532.
>
> This was no cleanup. It does fifteen different things and
> in the process flat out breaks the test at least on all
> non-atomic drivers/platforms.
>
> Cc: Nidhi Gupta <nidhi1.gupta@intel.com<mailto:nidhi1.gupta@intel.com>>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com<mailto:bhanuprakash.modem@intel.com>>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com<mailto:ville.syrjala@linux.intel.com>>
Is anyone going to do anything about this or do I just push the
reverts?
> ---
> tests/kms_invalid_mode.c | 39 ++++++++++++++++++++++++---------------
> 1 file changed, 24 insertions(+), 15 deletions(-)
>
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> index 21ee91abf54b..0287ee02c1c4 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -35,6 +35,7 @@ struct _data {
> enum pipe pipe;
> igt_display_t display;
> igt_output_t *output;
> + drmModeResPtr res;
> int max_dotclock;
> bool (*adjust_mode)(data_t *data, drmModeModeInfoPtr mode);
> };
> @@ -181,29 +182,35 @@ static void
> test_output(data_t *data)
> {
> igt_output_t *output = data->output;
> + drmModeModeInfo mode;
> struct igt_fb fb;
> int ret;
> - drmModeModeInfo *mode;
> + uint32_t crtc_id;
>
> - igt_output_set_pipe(output, data->pipe);
> + /*
> + * FIXME test every mode we have to be more
> + * sure everything is really getting rejected?
> + */
> + mode = *igt_output_get_mode(output);
> + igt_require(data->adjust_mode(data, &mode));
>
> - igt_create_fb(data->drm_fd, 512, 512, DRM_FORMAT_XRGB8888,
> + igt_create_fb(data->drm_fd,
> + max_t(uint16_t, mode.hdisplay, 64),
> + max_t(uint16_t, mode.vdisplay, 64),
> + DRM_FORMAT_XRGB8888,
> DRM_FORMAT_MOD_LINEAR,
> &fb);
>
> - for_each_connector_mode(output) {
> - mode = &output->config.connector->modes[j__];
> - igt_require(data->adjust_mode(data, mode));
> - igt_output_override_mode(output, mode);
> - ret = igt_display_try_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
> - igt_assert(ret == -EINVAL);
> - }
> + kmstest_unset_all_crtcs(data->drm_fd, data->res);
> +
> + crtc_id = data->display.pipes[data->pipe].crtc_id;
> +
> + ret = drmModeSetCrtc(data->drm_fd, crtc_id,
> + fb.fb_id, 0, 0,
> + &output->id, 1, &mode);
> + igt_assert_lt(ret, 0);
>
> igt_remove_fb(data->drm_fd, &fb);
> - igt_output_override_mode(output, NULL);
> - /*unset_all_crtcs*/
> - igt_display_reset(&data->display);
> - igt_display_commit(&data->display);
> }
>
> static int i915_max_dotclock(data_t *data)
> @@ -283,10 +290,11 @@ igt_main
> kmstest_set_vt_graphics_mode();
>
> igt_display_require(&data.display, data.drm_fd);
> + data.res = drmModeGetResources(data.drm_fd);
> + igt_assert(data.res);
>
> data.max_dotclock = i915_max_dotclock(&data);
> igt_info("Max dotclock: %d kHz\n", data.max_dotclock);
> - igt_display_require_output(&data.display);
> }
>
> igt_describe("Make sure all modesets are rejected when the requested mode is invalid");
> @@ -306,5 +314,6 @@ igt_main
> igt_fixture {
> igt_display_fini(&data.display);
> igt_reset_connectors();
> + drmModeFreeResources(data.res);
> }
> }
> --
> 2.35.1
--
Ville Syrjälä
Intel
[-- Attachment #2: Type: text/html, Size: 13889 bytes --]
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit" (rev2)
2022-10-07 13:40 [igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit" Ville Syrjala
` (4 preceding siblings ...)
2022-10-07 18:27 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] " Patchwork
@ 2022-10-28 6:47 ` Patchwork
5 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2022-10-28 6:47 UTC (permalink / raw)
To: Gupta, Nidhi1; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit" (rev2)
URL : https://patchwork.freedesktop.org/series/109481/
State : failure
== Summary ==
Applying: Revert "kms_invalid_mode: Close device before exit"
Applying: Revert "tests/kms_invalid_mode: Avoid usage of same pipe on multiple outputs"
Applying: Revert "tests/kms_invalid_mode: Test Cleanup"
Patch failed at 0003 Revert "tests/kms_invalid_mode: Test Cleanup"
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-10-28 6:47 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-07 13:40 [igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit" Ville Syrjala
2022-10-07 13:40 ` [igt-dev] [PATCH i-g-t 2/3] Revert "tests/kms_invalid_mode: Avoid usage of same pipe on multiple outputs" Ville Syrjala
2022-10-07 13:40 ` [igt-dev] [PATCH i-g-t 3/3] Revert "tests/kms_invalid_mode: Test Cleanup" Ville Syrjala
2022-10-07 15:49 ` Modem, Bhanuprakash
2022-10-07 16:04 ` Ville Syrjälä
2022-10-27 20:18 ` Ville Syrjälä
2022-10-27 22:03 ` Modem, Bhanuprakash
2022-10-28 6:34 ` Gupta, Nidhi1
2022-10-07 14:37 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit" Patchwork
2022-10-07 15:32 ` [igt-dev] [PATCH i-g-t 1/3] " Kamil Konieczny
2022-10-07 15:45 ` Ville Syrjälä
2022-10-07 18:27 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/3] " Patchwork
2022-10-28 6:47 ` [igt-dev] ✗ Fi.CI.BUILD: failure for series starting with [i-g-t,1/3] Revert "kms_invalid_mode: Close device before exit" (rev2) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.