From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yangtao Li <frank.li@vivo.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove gc_urgent_high_remaining node
Date: Thu, 10 Nov 2022 13:07:48 -0800 [thread overview]
Message-ID: <Y21oJCFmHjXhncTd@google.com> (raw)
In-Reply-To: <20221110081948.31673-1-frank.li@vivo.com>
On 11/10, Yangtao Li wrote:
> Hi Jaegeuk,
>
> > Hi,
>
> > I modified and integrated some patches as below. Could you please take a look?
>
> > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=d34f1e7212c1965a409d4581a32a92a1c91495fc
>
> I've looked at the relevant changes on the branch, looks good to me.
>
> One small question, does the name need to be changed to gc_remaining_count?
> There are already controls based on the number of gcs, maybe we can add a
> gc_remaining_ms later? Control the gc mode based on the expected time. When
> the count is reduced to 0 or the gc ends and the expected value is reached,
> switch back to the normal mode.
Please check the latest patch which replaced it with gc_remaining_trials.
I think the time-based control can be managed by user side instead of kernel.
>
> Thx,
> Yangtao
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yangtao Li <frank.li@vivo.com>
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: remove gc_urgent_high_remaining node
Date: Thu, 10 Nov 2022 13:07:48 -0800 [thread overview]
Message-ID: <Y21oJCFmHjXhncTd@google.com> (raw)
In-Reply-To: <20221110081948.31673-1-frank.li@vivo.com>
On 11/10, Yangtao Li wrote:
> Hi Jaegeuk,
>
> > Hi,
>
> > I modified and integrated some patches as below. Could you please take a look?
>
> > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=d34f1e7212c1965a409d4581a32a92a1c91495fc
>
> I've looked at the relevant changes on the branch, looks good to me.
>
> One small question, does the name need to be changed to gc_remaining_count?
> There are already controls based on the number of gcs, maybe we can add a
> gc_remaining_ms later? Control the gc mode based on the expected time. When
> the count is reduced to 0 or the gc ends and the expected value is reached,
> switch back to the normal mode.
Please check the latest patch which replaced it with gc_remaining_trials.
I think the time-based control can be managed by user side instead of kernel.
>
> Thx,
> Yangtao
next prev parent reply other threads:[~2022-11-10 21:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 13:07 [f2fs-dev] [PATCH] f2fs: remove gc_urgent_high_remaining node Yangtao Li via Linux-f2fs-devel
2022-10-28 13:07 ` Yangtao Li
2022-10-28 17:25 ` [f2fs-dev] " Jaegeuk Kim
2022-10-28 17:25 ` Jaegeuk Kim
2022-11-10 8:19 ` [f2fs-dev] " Yangtao Li via Linux-f2fs-devel
2022-11-10 8:19 ` Yangtao Li
2022-11-10 21:07 ` Jaegeuk Kim [this message]
2022-11-10 21:07 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y21oJCFmHjXhncTd@google.com \
--to=jaegeuk@kernel.org \
--cc=frank.li@vivo.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.