All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Golle <daniel@makrotopia.org>
To: Richard Weinberger <richard@nod.at>
Cc: Jens Axboe <axboe@kernel.dk>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Matthew Wilcox <willy@infradead.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Ming Lei <ming.lei@redhat.com>,
	linux-block <linux-block@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v4 4/5] mtd_blkdevs: add option to enable scanning for partitions
Date: Fri, 11 Nov 2022 00:39:15 +0000	[thread overview]
Message-ID: <Y22Zs7Jg0FNFHeHD@makrotopia.org> (raw)
In-Reply-To: <871124728.219224.1668111155161.JavaMail.zimbra@nod.at>

On Thu, Nov 10, 2022 at 09:12:35PM +0100, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
> > On Thu, Nov 10, 2022 at 08:44:53PM +0100, Richard Weinberger wrote:
> >> ----- Ursprüngliche Mail -----
> >> > Von: "Daniel Golle" <daniel@makrotopia.org>
> >> > +
> >> > +		if (!IS_ENABLED(CONFIG_MTD_BLOCK_PARTITIONS) || mtd_type_is_nand(new->mtd))
> >> > +			gd->flags |= GENHD_FL_NO_PART;
> >> 
> >> I know that NAND should not get used with mtdblock because lack of wearleveling
> >> and
> >> in general too many writes. But what exactly is the rationale to deny part
> >> scanning for NAND?
> > 
> > As UBI should be used on NAND, partition scanning should be enabled for
> > ubiblock devices to have uImage.FIT filesystem subimages mapped by the
> > partition parser.
> > 
> > If not skipping partition scanning on NAND-backed mtdblock devices the
> > scanning itself will already trigger multiple warnings which now happen
> > every time when a NAND-backed mtdblock device is being opened since
> > commit 96a3295c ("mtdblock: warn if opened on NAND").
> 
> I see, you want to promote UBI. Makes sense.
> In case you do a v5 series, please add a comment to the code.

Will do, I'm planning to send v5 early next week.

If we are going to have only CONFIG_MTD_BLOCK_PARTITIONS and no other
config symbol for ubiblock devices I'd also merge the two patches for
mtdblock and ubiblock partition scanning into a single one.

Thank you for reviewing!


Daniel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Richard Weinberger <richard@nod.at>
Cc: Jens Axboe <axboe@kernel.dk>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Matthew Wilcox <willy@infradead.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Ming Lei <ming.lei@redhat.com>,
	linux-block <linux-block@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v4 4/5] mtd_blkdevs: add option to enable scanning for partitions
Date: Fri, 11 Nov 2022 00:39:15 +0000	[thread overview]
Message-ID: <Y22Zs7Jg0FNFHeHD@makrotopia.org> (raw)
In-Reply-To: <871124728.219224.1668111155161.JavaMail.zimbra@nod.at>

On Thu, Nov 10, 2022 at 09:12:35PM +0100, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
> > On Thu, Nov 10, 2022 at 08:44:53PM +0100, Richard Weinberger wrote:
> >> ----- Ursprüngliche Mail -----
> >> > Von: "Daniel Golle" <daniel@makrotopia.org>
> >> > +
> >> > +		if (!IS_ENABLED(CONFIG_MTD_BLOCK_PARTITIONS) || mtd_type_is_nand(new->mtd))
> >> > +			gd->flags |= GENHD_FL_NO_PART;
> >> 
> >> I know that NAND should not get used with mtdblock because lack of wearleveling
> >> and
> >> in general too many writes. But what exactly is the rationale to deny part
> >> scanning for NAND?
> > 
> > As UBI should be used on NAND, partition scanning should be enabled for
> > ubiblock devices to have uImage.FIT filesystem subimages mapped by the
> > partition parser.
> > 
> > If not skipping partition scanning on NAND-backed mtdblock devices the
> > scanning itself will already trigger multiple warnings which now happen
> > every time when a NAND-backed mtdblock device is being opened since
> > commit 96a3295c ("mtdblock: warn if opened on NAND").
> 
> I see, you want to promote UBI. Makes sense.
> In case you do a v5 series, please add a comment to the code.

Will do, I'm planning to send v5 early next week.

If we are going to have only CONFIG_MTD_BLOCK_PARTITIONS and no other
config symbol for ubiblock devices I'd also merge the two patches for
mtdblock and ubiblock partition scanning into a single one.

Thank you for reviewing!


Daniel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2022-11-11  0:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 23:04 [PATCH v4 4/5] mtd_blkdevs: add option to enable scanning for partitions Daniel Golle
2022-11-08 23:04 ` Daniel Golle
2022-11-09 12:45 ` Miquel Raynal
2022-11-09 12:45   ` Miquel Raynal
2022-11-09 13:10   ` Daniel Golle
2022-11-09 13:10     ` Daniel Golle
2022-11-10 19:44 ` Richard Weinberger
2022-11-10 19:44   ` Richard Weinberger
2022-11-10 20:04   ` Daniel Golle
2022-11-10 20:04     ` Daniel Golle
2022-11-10 20:12     ` Richard Weinberger
2022-11-10 20:12       ` Richard Weinberger
2022-11-11  0:39       ` Daniel Golle [this message]
2022-11-11  0:39         ` Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y22Zs7Jg0FNFHeHD@makrotopia.org \
    --to=daniel@makrotopia.org \
    --cc=axboe@kernel.dk \
    --cc=dave@stgolabs.net \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.