All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linus.walleij@linaro.org, robh+dt@kernel.org,
	shawnguo@kernel.org, rydberg@bitmath.org, alistair23@gmail.com,
	s.hauer@pengutronix.de, andreas@kemnade.info,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	"Mylène Josserand" <mylene.josserand@bootlin.com>,
	"Peter Geis" <pgwipeout@gmail.com>
Subject: Re: [PATCH v10 1/4] Input: Add driver for Cypress Generation 5 touchscreen
Date: Mon, 31 Oct 2022 16:52:13 -0700	[thread overview]
Message-ID: <Y2BfrUx9gzaNhb4I@google.com> (raw)
In-Reply-To: <20221026114908.191472-2-alistair@alistair23.me>

On Wed, Oct 26, 2022 at 09:49:05PM +1000, Alistair Francis wrote:
> This is the basic driver for the Cypress TrueTouch Gen5 touchscreen
> controllers. This driver supports only the I2C bus but it uses regmap
> so SPI support could be added later.
> The touchscreen can retrieve some defined zone that are handled as
> buttons (according to the hardware). That is why it handles
> button and multitouch events.
> 
> Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
> Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> Tested-by: Andreas Kemnade <andreas@kemnade.info> # Kobo Clara HD
> Tested-by: Peter Geis <pgwipeout@gmail.com>

While I wish we did not have to parse what is essentially HID data
ourselves and basically repeated what i2c-hid does, I understand that
the firmware is not exactly i2c-hid compatible...

Applied, thank you.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linus.walleij@linaro.org, robh+dt@kernel.org,
	shawnguo@kernel.org, rydberg@bitmath.org, alistair23@gmail.com,
	s.hauer@pengutronix.de, andreas@kemnade.info,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	"Mylène Josserand" <mylene.josserand@bootlin.com>,
	"Peter Geis" <pgwipeout@gmail.com>
Subject: Re: [PATCH v10 1/4] Input: Add driver for Cypress Generation 5 touchscreen
Date: Mon, 31 Oct 2022 16:52:13 -0700	[thread overview]
Message-ID: <Y2BfrUx9gzaNhb4I@google.com> (raw)
In-Reply-To: <20221026114908.191472-2-alistair@alistair23.me>

On Wed, Oct 26, 2022 at 09:49:05PM +1000, Alistair Francis wrote:
> This is the basic driver for the Cypress TrueTouch Gen5 touchscreen
> controllers. This driver supports only the I2C bus but it uses regmap
> so SPI support could be added later.
> The touchscreen can retrieve some defined zone that are handled as
> buttons (according to the hardware). That is why it handles
> button and multitouch events.
> 
> Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
> Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> Tested-by: Andreas Kemnade <andreas@kemnade.info> # Kobo Clara HD
> Tested-by: Peter Geis <pgwipeout@gmail.com>

While I wish we did not have to parse what is essentially HID data
ourselves and basically repeated what i2c-hid does, I understand that
the firmware is not exactly i2c-hid compatible...

Applied, thank you.

-- 
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-31 23:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 11:49 [PATCH v10 0/4] Add support for the Cypress cyttsp5 Alistair Francis
2022-10-26 11:49 ` Alistair Francis
2022-10-26 11:49 ` [PATCH v10 1/4] Input: Add driver for Cypress Generation 5 touchscreen Alistair Francis
2022-10-26 11:49   ` Alistair Francis
2022-10-31 23:52   ` Dmitry Torokhov [this message]
2022-10-31 23:52     ` Dmitry Torokhov
2023-09-25 11:05   ` James Hilliard
2023-09-25 11:05     ` James Hilliard
2022-10-26 11:49 ` [PATCH v10 2/4] dt-bindings: input: Add Cypress TT21000 touchscreen controller Alistair Francis
2022-10-26 11:49   ` Alistair Francis
2022-10-31 23:49   ` Dmitry Torokhov
2022-10-31 23:49     ` Dmitry Torokhov
2022-11-01 11:50     ` Rob Herring
2022-11-01 11:50       ` Rob Herring
2022-11-01 15:00       ` Dmitry Torokhov
2022-11-01 15:00         ` Dmitry Torokhov
2022-10-26 11:49 ` [PATCH v10 3/4] ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen Alistair Francis
2022-10-26 11:49   ` Alistair Francis
2022-11-10  7:18   ` Shawn Guo
2022-11-10  7:18     ` Shawn Guo
2022-10-26 11:49 ` [PATCH v10 4/4] ARM: dts: imx7d-remarkable2: Enable the cyttsp5 Alistair Francis
2022-10-26 11:49   ` Alistair Francis
2022-11-11  2:29   ` Shawn Guo
2022-11-11  2:29     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2BfrUx9gzaNhb4I@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=mylene.josserand@bootlin.com \
    --cc=pgwipeout@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.