All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org>
To: Kemeng Shi <shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 2/3] block: Correct comment for scale_cookie_change
Date: Wed, 2 Nov 2022 10:11:48 -0400	[thread overview]
Message-ID: <Y2J6pPj4/aVdoGPp@localhost.localdomain> (raw)
In-Reply-To: <20221018111240.22612-3-shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

On Tue, Oct 18, 2022 at 07:12:39PM +0800, Kemeng Shi wrote:
> Default queue depth of iolatency_grp is unlimited, so we scale down
> quickly(once by half) in scale_cookie_change. Remove the "subtract
> 1/16th" part which is not the truth and add the actual way we
> scale down.
> 
> Signed-off-by: Kemeng Shi <shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

This is perfect, thanks Kemeng

Reviewed-by: Josef Bacik <josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org>

Thanks,

Josef

WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <josef@toxicpanda.com>
To: Kemeng Shi <shikemeng@huawei.com>
Cc: tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] block: Correct comment for scale_cookie_change
Date: Wed, 2 Nov 2022 10:11:48 -0400	[thread overview]
Message-ID: <Y2J6pPj4/aVdoGPp@localhost.localdomain> (raw)
In-Reply-To: <20221018111240.22612-3-shikemeng@huawei.com>

On Tue, Oct 18, 2022 at 07:12:39PM +0800, Kemeng Shi wrote:
> Default queue depth of iolatency_grp is unlimited, so we scale down
> quickly(once by half) in scale_cookie_change. Remove the "subtract
> 1/16th" part which is not the truth and add the actual way we
> scale down.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huawei.com>

This is perfect, thanks Kemeng

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

  parent reply	other threads:[~2022-11-02 14:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 11:12 [PATCH v2 0/3] A few cleanup patches for blk-iolatency.c Kemeng Shi
2022-10-18 11:12 ` Kemeng Shi
     [not found] ` <20221018111240.22612-1-shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-10-18 11:12   ` [PATCH v2 1/3] block: Remove redundant parent blkcg_gp check in check_scale_change Kemeng Shi
2022-10-18 11:12     ` Kemeng Shi
2022-10-18 11:12   ` [PATCH v2 2/3] block: Correct comment for scale_cookie_change Kemeng Shi
2022-10-18 11:12     ` Kemeng Shi
     [not found]     ` <20221018111240.22612-3-shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-11-01  9:38       ` Kemeng Shi
2022-11-01  9:38         ` Kemeng Shi
2022-11-02 14:11       ` Josef Bacik [this message]
2022-11-02 14:11         ` Josef Bacik
2022-10-18 11:12   ` [PATCH v2 3/3] block: Replace struct rq_depth with unsigned int in struct iolatency_grp Kemeng Shi
2022-10-18 11:12     ` Kemeng Shi
2022-11-01 14:17 ` [PATCH v2 0/3] A few cleanup patches for blk-iolatency.c Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2J6pPj4/aVdoGPp@localhost.localdomain \
    --to=josef-digfwca+lfgyejad7bwfqa@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shikemeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.