From: Lee Jones <lee@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Dmitry Osipenko <digetx@gmail.com>,
Chris Zhong <zyw@rock-chips.com>,
Zhang Qing <zhangqing@rock-chips.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery
Date: Wed, 2 Nov 2022 11:37:41 +0000 [thread overview]
Message-ID: <Y2JWhTcEvNxIwSB6@google.com> (raw)
In-Reply-To: <CAL_JsqJUx2FtpYWSkx3cOFcywSux7P2sPpvbVmaryMdo1+xA_Q@mail.gmail.com>
On Tue, 01 Nov 2022, Rob Herring wrote:
> On Tue, Nov 1, 2022 at 5:25 AM Lee Jones <lee@kernel.org> wrote:
> >
> > On Mon, 31 Oct 2022, Rob Herring wrote:
> >
> > > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote:
> > > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote:
> > > >
> > > > > Core schema does not define type of monitored-battery, so the schemas
> > > > > are expected to reference proper type.
> > > > >
> > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > > ---
> > > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++-
> > > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
> > > > > 2 files changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > Applied, thanks.
> > >
> > > NAK. Please drop or revert.
> >
> > Dropping is not a problem.
> >
> > Would you mind providing some context?
>
> I did elsewhere in the series, but simply we don't want to define a
> type for a property multiple times. It should be defined once
> somewhere common.
ACK, thanks.
Dropped.
--
Lee Jones [李琼斯]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Dmitry Osipenko <digetx@gmail.com>,
Chris Zhong <zyw@rock-chips.com>,
Zhang Qing <zhangqing@rock-chips.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery
Date: Wed, 2 Nov 2022 11:37:41 +0000 [thread overview]
Message-ID: <Y2JWhTcEvNxIwSB6@google.com> (raw)
In-Reply-To: <CAL_JsqJUx2FtpYWSkx3cOFcywSux7P2sPpvbVmaryMdo1+xA_Q@mail.gmail.com>
On Tue, 01 Nov 2022, Rob Herring wrote:
> On Tue, Nov 1, 2022 at 5:25 AM Lee Jones <lee@kernel.org> wrote:
> >
> > On Mon, 31 Oct 2022, Rob Herring wrote:
> >
> > > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote:
> > > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote:
> > > >
> > > > > Core schema does not define type of monitored-battery, so the schemas
> > > > > are expected to reference proper type.
> > > > >
> > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > > ---
> > > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++-
> > > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
> > > > > 2 files changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > Applied, thanks.
> > >
> > > NAK. Please drop or revert.
> >
> > Dropping is not a problem.
> >
> > Would you mind providing some context?
>
> I did elsewhere in the series, but simply we don't want to define a
> type for a property multiple times. It should be defined once
> somewhere common.
ACK, thanks.
Dropped.
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Dmitry Osipenko <digetx@gmail.com>,
Chris Zhong <zyw@rock-chips.com>,
Zhang Qing <zhangqing@rock-chips.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery
Date: Wed, 2 Nov 2022 11:37:41 +0000 [thread overview]
Message-ID: <Y2JWhTcEvNxIwSB6@google.com> (raw)
In-Reply-To: <CAL_JsqJUx2FtpYWSkx3cOFcywSux7P2sPpvbVmaryMdo1+xA_Q@mail.gmail.com>
On Tue, 01 Nov 2022, Rob Herring wrote:
> On Tue, Nov 1, 2022 at 5:25 AM Lee Jones <lee@kernel.org> wrote:
> >
> > On Mon, 31 Oct 2022, Rob Herring wrote:
> >
> > > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote:
> > > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote:
> > > >
> > > > > Core schema does not define type of monitored-battery, so the schemas
> > > > > are expected to reference proper type.
> > > > >
> > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > > ---
> > > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++-
> > > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 +
> > > > > 2 files changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > Applied, thanks.
> > >
> > > NAK. Please drop or revert.
> >
> > Dropping is not a problem.
> >
> > Would you mind providing some context?
>
> I did elsewhere in the series, but simply we don't want to define a
> type for a property multiple times. It should be defined once
> somewhere common.
ACK, thanks.
Dropped.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-11-02 11:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 23:13 [PATCH] dt-bindings: mfd: Expect specific type for monitored-battery Krzysztof Kozlowski
2022-10-28 23:13 ` Krzysztof Kozlowski
2022-10-28 23:13 ` Krzysztof Kozlowski
2022-10-31 8:49 ` Lee Jones
2022-10-31 8:49 ` Lee Jones
2022-10-31 8:49 ` Lee Jones
2022-10-31 19:26 ` Rob Herring
2022-10-31 19:26 ` Rob Herring
2022-10-31 19:26 ` Rob Herring
2022-11-01 10:25 ` Lee Jones
2022-11-01 10:25 ` Lee Jones
2022-11-01 10:25 ` Lee Jones
2022-11-01 17:25 ` Rob Herring
2022-11-01 17:25 ` Rob Herring
2022-11-01 17:25 ` Rob Herring
2022-11-02 11:37 ` Lee Jones [this message]
2022-11-02 11:37 ` Lee Jones
2022-11-02 11:37 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2JWhTcEvNxIwSB6@google.com \
--to=lee@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.