From: Daniel Golle <daniel@makrotopia.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] net: ethernet: mediatek: ppe: add support for flow accounting
Date: Wed, 2 Nov 2022 11:40:01 +0000 [thread overview]
Message-ID: <Y2JXEfRDZO2oPoMT@makrotopia.org> (raw)
In-Reply-To: <20221101204945.35edb8e6@kernel.org>
Hi Jakub,
On Tue, Nov 01, 2022 at 08:49:45PM -0700, Jakub Kicinski wrote:
> On Wed, 2 Nov 2022 00:58:01 +0000 Daniel Golle wrote:
> > The PPE units found in MT7622 and newer support packet and byte
> > accounting of hw-offloaded flows. Add support for reading those
> > counters as found in MediaTek's SDK[1].
> >
> > [1]: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/bc6a6a375c800dc2b80e1a325a2c732d1737df92
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> > v4: declare function mtk_mib_entry_read as static
> > v3: don't bother to set 'false' values in any zero-initialized struct
> > use mtk_foe_entry_ib2
> > both changes were requested by Felix Fietkau
> >
> > v2: fix wrong variable name in return value check spotted by Denis Kirjanov
>
> Please read the FAQ:
>
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
I'm sorry for re-submitting the fixes to frequently. I'll give it more
time in future.
>
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#running-all-the-builds-and-checks-locally-is-a-pain-can-i-post-my-patches-and-have-the-patchwork-bot-validate-them
>
It wasn't my intention to out-source testing to the patchwork bot.
I do run checks as recommended locally, which includes checkpatch.pl,
build and run-time testing. And though in this case an unneeded export
of a function was also indicated by my local compiler, I must have
missed it in the output of the kernel build. I will try to improve my
workflow in such a way that it will be less likely to miss new compiler
warnings.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] net: ethernet: mediatek: ppe: add support for flow accounting
Date: Wed, 2 Nov 2022 11:40:01 +0000 [thread overview]
Message-ID: <Y2JXEfRDZO2oPoMT@makrotopia.org> (raw)
In-Reply-To: <20221101204945.35edb8e6@kernel.org>
Hi Jakub,
On Tue, Nov 01, 2022 at 08:49:45PM -0700, Jakub Kicinski wrote:
> On Wed, 2 Nov 2022 00:58:01 +0000 Daniel Golle wrote:
> > The PPE units found in MT7622 and newer support packet and byte
> > accounting of hw-offloaded flows. Add support for reading those
> > counters as found in MediaTek's SDK[1].
> >
> > [1]: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/bc6a6a375c800dc2b80e1a325a2c732d1737df92
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> > v4: declare function mtk_mib_entry_read as static
> > v3: don't bother to set 'false' values in any zero-initialized struct
> > use mtk_foe_entry_ib2
> > both changes were requested by Felix Fietkau
> >
> > v2: fix wrong variable name in return value check spotted by Denis Kirjanov
>
> Please read the FAQ:
>
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
I'm sorry for re-submitting the fixes to frequently. I'll give it more
time in future.
>
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#running-all-the-builds-and-checks-locally-is-a-pain-can-i-post-my-patches-and-have-the-patchwork-bot-validate-them
>
It wasn't my intention to out-source testing to the patchwork bot.
I do run checks as recommended locally, which includes checkpatch.pl,
build and run-time testing. And though in this case an unneeded export
of a function was also indicated by my local compiler, I must have
missed it in the output of the kernel build. I will try to improve my
workflow in such a way that it will be less likely to miss new compiler
warnings.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-02 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 0:58 [PATCH v4] net: ethernet: mediatek: ppe: add support for flow accounting Daniel Golle
2022-11-02 0:58 ` Daniel Golle
2022-11-02 3:49 ` Jakub Kicinski
2022-11-02 3:49 ` Jakub Kicinski
2022-11-02 11:40 ` Daniel Golle [this message]
2022-11-02 11:40 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2JXEfRDZO2oPoMT@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.